From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 0488D2BC8 for ; Tue, 27 Mar 2018 18:24:17 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7204520FCD; Tue, 27 Mar 2018 12:24:16 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 27 Mar 2018 12:24:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=n9pxySnO3ifK2/r5jATtyeqOzG gkrZhCnu/khxN15No=; b=lK5vNAE2IWn8bcS2kkhD5ob1clArab6SL8ilzO7b3q YonTzPrWYRznPNoNgWMARU/bzUYY73n2smTddEce/CHKPeGsZKzSm3SpXFaDyjUS C+P4TPf0/JvCxOfdi5ff2XtuIG9S8F2yRuV0CHvJWKoFC+n1G9/77flJQoLqz/Ft o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=n9pxyS nO3ifK2/r5jATtyeqOzGgkrZhCnu/khxN15No=; b=TUOp6xUMe3dc4PqKmtCa0M HyDM1lKDsdqgytsvz9iBv7d8UurCDi5m6GCyIGSfT8f1cFG1Wp2eh1kj4F+dAAKX ch5nQorw91Fbgt4HYb9LOfJspqTefm8IPgqOxauXFLN/vFtLQTnkwy82XDkntB5E YA/YYK+vsH9S/Deyh/7rp6OxCz7uID2RAxhxWFDxR3iUjFbOt5hPmvnmV7/LaRxt bzJ6XUeB8Z8Hy69dUjIkYp71FIThzHPZRH0xldwlQMpEA50fvs7inpyqiEdPsTXF UZ0+MlUbUDXP9qaegg/+d+sxfRiuOCBL7VAJBi2HRs79YeprpO34YfXN1ii8ZLTQ == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AE04BE446B; Tue, 27 Mar 2018 12:24:15 -0400 (EDT) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org, Bruce Richardson , chaozhu@linux.vnet.ibm.com, gowrishankar.m@linux.vnet.ibm.com Date: Tue, 27 Mar 2018 18:24:00 +0200 Message-ID: <507411072.Cm6Xjx9PLX@xps> In-Reply-To: <9ff09ae09b3e9e1b149f73a693b552f8c94a01a2.1521722141.git.anatoly.burakov@intel.com> References: <9755302ee8a1439a152408d4b1c69cc1012153e4.1521715978.git.anatoly.burakov@intel.com> <9ff09ae09b3e9e1b149f73a693b552f8c94a01a2.1521722141.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6] eal: provide API for querying valid socket id's X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Mar 2018 16:24:18 -0000 22/03/2018 13:36, Anatoly Burakov: > --- a/lib/librte_eal/common/include/rte_eal.h > +++ b/lib/librte_eal/common/include/rte_eal.h > @@ -57,6 +57,9 @@ enum rte_proc_type_t { > struct rte_config { > uint32_t master_lcore; /**< Id of the master lcore */ > uint32_t lcore_count; /**< Number of available logical cores. */ > + uint32_t numa_node_count; /**< Number of detected NUMA nodes. */ > + uint32_t numa_nodes[RTE_MAX_NUMA_NODES]; > + /**< List of detected numa nodes. */ Please keep this comment on the same line if it's below 99 chars. > --- a/lib/librte_eal/common/include/rte_lcore.h > +++ b/lib/librte_eal/common/include/rte_lcore.h > @@ -132,6 +132,36 @@ rte_lcore_index(int lcore_id) > unsigned rte_socket_id(void); > > /** > + * Return number of physical sockets detected on the system. > + * > + * Note that number of nodes may not be correspondent to their physical id's: > + * for example, a system may report two socket id's, but the actual socket id's > + * may be 0 and 8. > + * > + * @return > + * the number of physical sockets as recognized by EAL > + */ > +unsigned int __rte_experimental > +rte_num_socket_ids(void); I suggest rte_socket_count() as function name. > +/** > + * Return socket id with a particular index. > + * > + * This will return socket id at a particular position in list of all detected > + * physical socket id's. For example, on a machine with sockets [0, 8], passing > + * 1 as a parameter will return 8. > + * > + * @param idx > + * index of physical socket id to return > + * > + * @return > + * - physical socket id as recognized by EAL > + * - -1 on error, with errno set to EINVAL > + */ > +int __rte_experimental > +rte_socket_id_by_idx(unsigned int idx); OK for this function. > --- a/lib/librte_eal/linuxapp/eal/Makefile > +++ b/lib/librte_eal/linuxapp/eal/Makefile > -LIBABIVER := 6 > +LIBABIVER := 7 When changing the ABI version, you need to update the release notes. There is also a deprecation notice to remove. > --- a/lib/librte_eal/rte_eal_version.map > +++ b/lib/librte_eal/rte_eal_version.map > @@ -229,6 +229,8 @@ EXPERIMENTAL { > rte_mp_request; > rte_mp_request_async; > rte_mp_reply; > + rte_num_socket_ids; > + rte_socket_id_by_idx; This one is not in the alphabetical order. > rte_service_attr_get; > rte_service_attr_reset_all; > rte_service_component_register;