From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 6A8CC1B6A9
 for <dev@dpdk.org>; Tue, 10 Apr 2018 12:15:11 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id DC4B920E92;
 Tue, 10 Apr 2018 06:15:10 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Tue, 10 Apr 2018 06:15:10 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=07jb5oO9WqUhpTHU4kJ9HaKsgx
 BGVV3AFoBdQwLX7Eg=; b=PHjfnHP1O2XSqzatJvfJTCYonH8t+IWkK95TMh2gDN
 RbWkbVGTvOTWJ5lDltyUCwYzEHMgesjYKovRgxctlyOKSWv8/omkcqlOm2H17St/
 2ssmZMmRRsDpVqTab8FjwvmKMW4HhWucZbKMznhbjxM4c4bWiXSOIYD6hCC1R9Sk
 8=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=07jb5o
 O9WqUhpTHU4kJ9HaKsgxBGVV3AFoBdQwLX7Eg=; b=ZbICIhAGbo4K7x3jnwwc0+
 xPYCA0WOQPSaQFZL7KBvdGnJXIAZNk8DEZVIDSXxpSQzoynA3TAmiMKJQetC7f0z
 MN4nPRTrYwTb0T4DVjyzWFyobJqUjgNhWl8mhcBag8B2xqun5uJJ+0HKXRaRktqX
 YHZkaG8IReATwc9HXtN5S1/2RhYShupE27ehEJjbbk0KdLn60Ga54PpVHWxcpden
 FqQnkbWtrESide7ydEolwQVTnIrCH8agjixQiedhkH6QYjzMTX3z77G+aGAX9tno
 7zvNYKcAlRcV+06FxSpbikF0Q49FkeNxNEG4zttjaD4B6EBALORFoGojuERE2TFg
 ==
X-ME-Sender: <xms:ro7MWsqcwVatBjlqG0lrCdYiKAPIl5S3CnwNIC-e9oO1tt3J9cX-zw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 2DF50E443C;
 Tue, 10 Apr 2018 06:15:10 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Jasvinder Singh <jasvinder.singh@intel.com>
Cc: dev@dpdk.org, cristian.dumitrescu@intel.com
Date: Tue, 10 Apr 2018 12:15:08 +0200
Message-ID: <50779258.T1JUn8BQf7@xps>
In-Reply-To: <20180410095132.130232-1-jasvinder.singh@intel.com>
References: <20180409120632.38567-1-jasvinder.singh@intel.com>
 <20180410095132.130232-1-jasvinder.singh@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix freebsd build
	error
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Apr 2018 10:15:11 -0000

10/04/2018 11:51, Jasvinder Singh:
> IP_Pipeline app is not supported in FreeBSD environment. Therefore,
> skip it while building the sample apps on FreeBSD.
[...]
> --- a/examples/ip_pipeline/Makefile
> +++ b/examples/ip_pipeline/Makefile
> @@ -67,6 +67,13 @@ RTE_TARGET ?= x86_64-native-linuxapp-gcc
>  
>  include $(RTE_SDK)/mk/rte.vars.mk
>  
> +ifneq ($(CONFIG_RTE_EXEC_ENV),"linuxapp")

You can use CONFIG_RTE_EXEC_ENV_LINUXAPP

> +$(info This application can only operate in a linuxapp environment, \
> +please change the definition of the RTE_TARGET environment variable)
> +all:
> +clean:
> +else


Copy of my previous comment:
"
It is not skipping the example, just throwing an error (which is needed).

You should add a test in examples/Makefile to really skip it.
"

In this v2, you replaced the error by an info message.
Error was better in my opinion.