From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 99DF21B54F; Wed, 17 Apr 2019 09:53:05 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BBB533082133; Wed, 17 Apr 2019 07:53:04 +0000 (UTC) Received: from [10.36.112.28] (ovpn-112-28.ams2.redhat.com [10.36.112.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C3BF51001DF3; Wed, 17 Apr 2019 07:53:01 +0000 (UTC) To: Aaron Conole , dev@dpdk.org Cc: stable@dpdk.org, Tiwei Bie , Zhihong Wang , Pengzhen Liu References: <20190415144818.26600-1-aconole@redhat.com> From: Maxime Coquelin Message-ID: <507c1ead-c6f7-7ce8-83f6-6c749539a436@redhat.com> Date: Wed, 17 Apr 2019 09:52:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190415144818.26600-1-aconole@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Wed, 17 Apr 2019 07:53:04 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] net/virtio: fix dangling pointer on failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Apr 2019 07:53:06 -0000 On 4/15/19 4:48 PM, Aaron Conole wrote: > When eth_virtio_dev_init() is cleaning up, it does not correctly set > the mac_addrs variable to NULL, which will lead to a double free. > > Found during unit-test fixes. > > Fixes: 43d18765c027 ("net/virtio: fix memory leak on failure") > Cc: stable@dpdk.org > Reported-by: Michael Santana > Signed-off-by: Aaron Conole > --- > drivers/net/virtio/virtio_ethdev.c | 1 + > 1 file changed, 1 insertion(+) Applied to dpdk-next-virtio/master. Thanks, Maxime From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D8254A00E6 for ; Wed, 17 Apr 2019 09:53:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 43B781B59E; Wed, 17 Apr 2019 09:53:07 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 99DF21B54F; Wed, 17 Apr 2019 09:53:05 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BBB533082133; Wed, 17 Apr 2019 07:53:04 +0000 (UTC) Received: from [10.36.112.28] (ovpn-112-28.ams2.redhat.com [10.36.112.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C3BF51001DF3; Wed, 17 Apr 2019 07:53:01 +0000 (UTC) To: Aaron Conole , dev@dpdk.org Cc: stable@dpdk.org, Tiwei Bie , Zhihong Wang , Pengzhen Liu References: <20190415144818.26600-1-aconole@redhat.com> From: Maxime Coquelin Message-ID: <507c1ead-c6f7-7ce8-83f6-6c749539a436@redhat.com> Date: Wed, 17 Apr 2019 09:52:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190415144818.26600-1-aconole@redhat.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Wed, 17 Apr 2019 07:53:04 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] net/virtio: fix dangling pointer on failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190417075259.B2TgL-icE8MfoxJqPVVHtBvpWnX-Nk46ja_ZTwP_3ec@z> On 4/15/19 4:48 PM, Aaron Conole wrote: > When eth_virtio_dev_init() is cleaning up, it does not correctly set > the mac_addrs variable to NULL, which will lead to a double free. > > Found during unit-test fixes. > > Fixes: 43d18765c027 ("net/virtio: fix memory leak on failure") > Cc: stable@dpdk.org > Reported-by: Michael Santana > Signed-off-by: Aaron Conole > --- > drivers/net/virtio/virtio_ethdev.c | 1 + > 1 file changed, 1 insertion(+) Applied to dpdk-next-virtio/master. Thanks, Maxime