From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15D1643261; Wed, 1 Nov 2023 14:36:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D073240151; Wed, 1 Nov 2023 14:36:11 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2045.outbound.protection.outlook.com [40.107.237.45]) by mails.dpdk.org (Postfix) with ESMTP id 65794400EF for ; Wed, 1 Nov 2023 14:36:10 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oULi+zIqNM3PrKF2SBvB/6xpCpci8Jb5I+6jh54IR1uXvdksELAQQ1Zms4Lbi8AiAcFjEuPI19ArPLUToUmx5gkzjHelDseMmVSaE/LYhIboZ294TIybGAMGanffC+xvrhOxBM1tSDa2RFtsw0VL/COJcIjFBoMJhAjjSsWdwXms23/wyBH8aWZx/9K2CMJVSD4uy3uFgXjfL1h3NpugppZQ/X4Rc73phfSZQywuiC7pbtVExDY4QSzxw3sSV4FwB8QEqVuhzcp5lGtiQKsuMYXJOQSn2Mfak95bAS4I7pwfgnM1uDHY8WPzz7rGqTMwtV4V6tpa8NWEs4sdyGsSXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s/B8R8PMQx2lAm7ur/E3OvZXvuXwGbtr1TUfVWqKDh4=; b=Q0gzHyM2lNZUj2wnJ6paJGGrpBAF9ABEEVsL2JixlSt53DSNjDEVtTqu1vBcokT2kdDu52p7fNRl7bY8WY9DVG6zSZSIkN5EqLiXGWMoIhmK0MJrGPANkLL0hlYTAu+NhNmqyVsvIUU2fTrssi4TcHAs01jpc16r1VwLuwz9HPrKw1MyGQ7NXbzZ5h3omJ8cTtttm/X6n3fHcZC730arSeB3bW/5WjihwNCNz5sXVkY6WMHIB721xGEvl1dQUj4UUf8VDsXANK5QIh1daVNCx1v86gNo8Hh61pbrjAnWLFew8eWDQlboBucb5FTFzK8kARzwFZVXk38e6G+F8sJZwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s/B8R8PMQx2lAm7ur/E3OvZXvuXwGbtr1TUfVWqKDh4=; b=GPao9L1xwD1W1NRzWAv0O5p+tDLCTO5sWispumJKZ5SZEBQ6HEoNMaqxYCRVtfBMaHlieDYO8y6v3Y+wKmnWqLbxh7Ebnv9o/V6Q68B48D7YjeXmA7s2dTXUj2iZ/5yFN91d2YFEkDZZs856/q+M8l68kgQCAzKMAQbhOXG9D+A= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA0PR12MB9045.namprd12.prod.outlook.com (2603:10b6:208:406::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.29; Wed, 1 Nov 2023 13:36:08 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.6954.019; Wed, 1 Nov 2023 13:36:08 +0000 Message-ID: <508c5f6d-7afa-4c78-a6d8-9e9e66917e77@amd.com> Date: Wed, 1 Nov 2023 13:36:01 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 03/10] ethdev: support setting and querying RSS algorithm Content-Language: en-US To: Jie Hai , dev@dpdk.org, Thomas Monjalon , Andrew Rybchenko , Ori Kam Cc: lihuisong@huawei.com, fengchengwen@huawei.com, liudongdong3@huawei.com References: <20230315110033.30143-1-liudongdong3@huawei.com> <20231101074039.3088716-1-haijie1@huawei.com> <20231101074039.3088716-4-haijie1@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20231101074039.3088716-4-haijie1@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR4P281CA0327.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:eb::11) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA0PR12MB9045:EE_ X-MS-Office365-Filtering-Correlation-Id: b4a01a8d-5d09-4406-2fc6-08dbdadf80ff X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DaJu+KBaXf5/5xVXy11DciG1lbi2+WP+T7Vyqq/OGN7dIKbpSliYXeFqsA7SWN4B8VgwZKktqDdpXfBo05aPtOYnGWogmIibxHBs4FbtuF7fmLn3w0VYHPXiUaUkxS9Dd9CLYrkFmJoQ31l2HfAdNG9uUgUSIjvYL5TrzacuYUNMS2h5gPoYMH0DCQQmvbAD+3qj0m5ko0QU7uyHchtJd1UBkU9G9VBmDdMNW8Ueb6ESTFcZDX3GzrMuTuqLqej7wbhsBzmhLV1FGFI0KZc8S/ibG2RrQsYv8aMnEMB3OmKsgEA15VtQ3IHe2HVS6yP8m8EQIiNCvhjKHlBuo4ET7CIj+EqswXiYWctKVv43qS1ZcpPhPRYu1nPERBROfUnJa5I5LhvojeHoxYrB00s5ZdZkqVGISbIDQNu2kS3c5bQcwVYOPwSuIwWSAv+vuE624mH2udsSijjZaYfxJSRg9BY5UusUD5SjCJp1YPOpXb5fOuNRA5Q2z+vYs0aEE0MXv2nCOT3b6Vum4m426zIlvMLe+5Uu32gYQnnrp/0AiMFhuTbWxxzIMJCkGfKB63sO0zboUSxhCrVkC9kfGi4Yr73hkRHfed+0xR5qPCrY/zYObVP05y4PpTV75QO4mBtYmHE7YsnvGLTqsUT5l3Ch2A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(136003)(39860400002)(346002)(366004)(376002)(230922051799003)(451199024)(64100799003)(1800799009)(186009)(8676002)(8936002)(4326008)(316002)(110136005)(66476007)(66556008)(66946007)(2906002)(41300700001)(44832011)(86362001)(5660300002)(31696002)(83380400001)(38100700002)(26005)(2616005)(31686004)(36756003)(478600001)(6506007)(6486002)(53546011)(6512007)(6666004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S1gyMzgydWJ6dlRXaCszM01uZGNlWEtCV0VxNGhPQ3hYUFMxb3dOOEd1TUlq?= =?utf-8?B?RTY5K0FhRGJ4Y0dHdkZLMldRQmliaGRBbzU2bTJHcWhlYXFtSExqbU1oOUZR?= =?utf-8?B?SzJoSFRydndtYnVkUHE5V2Rna0N5ckhCN3pYN2pOYTZNQ1JXckI3dW40bUwy?= =?utf-8?B?K210V3dtbFBCTFVsU0R1RVNKdUhBZ2JRTGJPQmRTdGt2UVZmWnFReW5pWU9h?= =?utf-8?B?SWg5VkM2NUpCY2FWMzZhMFA5R3VyUi9LcWZPWTZqTnZsSlZZcGFBbTBnZndH?= =?utf-8?B?QytyYjR0RHFoM0VYS09Ya2dyV1NJek44ckNMbDQ5dUhMN0p6cERlYmI0dnNm?= =?utf-8?B?SWhCRU00bUxtN1lkSGZrR3owd25lRUNqMnZQeEttb0ZvdGlFRWhveXM3YXVH?= =?utf-8?B?Z1Bidys1bGpjVVI4Z3BWL2RvejlKMHNxR3BNYzl6OEVPdHhtOVNITWdRQ1Jo?= =?utf-8?B?aTJkS1pNbzEvM2c1Ym4yTDVQa0liZXQ4L0pjSXZCNjBJOWxNWUh0VEliam1W?= =?utf-8?B?bWQ0NnE5TXlsWFpHSHdwV04rbjU1ZWVDTEpwdGZrbzQ3N0hNTnE5R1VWUWJI?= =?utf-8?B?TkhtQ3BYVzczQjlwS3hlUWg3WVhpM1VPVVZBNnI4UkIyNEx0c0tyMkJ4Z2Mz?= =?utf-8?B?ak40M0lnQ0ppRWdLK0RTbjhEN2hyckUzOGNuUUJVY3B2UFhtM3JQQmlSWjZn?= =?utf-8?B?aExTTmJaWmM2MWlTcUZDVGc1b2o2bmIvdXFyekxMSGZMMGRWQWxqeFNINVIy?= =?utf-8?B?eFVycVAvMVlyU0x1RVNVWVJXKzlmYmpEK0cwUWNHN1BpclFSMWc4Wmx5OEt0?= =?utf-8?B?N25Ja2h6QWU4Q1RtcWNNRysxR2ZEeHR3allqMS9wcnZhaXFaaUhYVWtDNWNL?= =?utf-8?B?U2ZXMUdPdGd0V0J0b1JmQk5nNUI5OEZXdi9pQlZLVVg4Wjg2eUxLV3c3NVVF?= =?utf-8?B?OCtMeTVscmRwNHdGdE1rb2V5UHJ5VCsrOHFNdnJrc0xhMHEybW5nMC84QlJi?= =?utf-8?B?VldvZUJ3WWFpdDZ1bEFSV2lkUkZ2K25nT3N4eThaT3dHN0JaZTlUc2FyNGdP?= =?utf-8?B?TUlWQzZXc01uOVpyU3dCazFGR3ZmTHRsK29UK1V3QkM0RE1jcVdreFhZbThj?= =?utf-8?B?eksrWjBJcTN5RUc2WUVEdWFpS3B4T0I1ODZtaW5kK01aaUxUSzc3YVhkYVRP?= =?utf-8?B?K1JIdlcwMXdNU3FYM2tMUE1ySk9iMG9JUWFJdTB5ZWtpNU9nYXhLZlBCczMv?= =?utf-8?B?NXRnU0pCTFFFQ1RFMkw2WDlJWkdqYVVRaElrR3kxanorMUlFaGlmUG9yTW9S?= =?utf-8?B?WG1vTTJKZG5FakRLR0tYbVZvQS92UnAxNjg0eG1QajdrUjNlcUlWdmV3Zkl6?= =?utf-8?B?dTNQSHBHVnBRTGlZT3pHNFVKNm5vZXVkdFRPeENaT21HeHR6MnFuNlVzZWFy?= =?utf-8?B?M1dpRmFlcm5xNDRYd2RYdTRVeE1FdzhDcEdISk5hY2MwVFUzZVc0YmlneURN?= =?utf-8?B?R3pmQ0RuRkttaEIyTWRvVUxlbFVBYUJGYlRLd21BQ3NNNFhhMmNBSGE1K1ln?= =?utf-8?B?R3Axb0xvNGZtTXRvSG1VczJmNlNaMjdrcE9wa0RBN0ZlM0VMTXpNTkdwdm80?= =?utf-8?B?QjYzMGttSk8xTDRwbUd6eEs3RnRHQjlWMDVaRmxQV3JLMXNPWGZRZFJNb0Fl?= =?utf-8?B?M3BTRUFwelg2cC9LOENiVnNiY2x6M1U0VG9RbHVTZS8yQ2F0ay9NQlRjSVBa?= =?utf-8?B?ZjZlR2JUVUxrWU1GR2NCMkVwVEdKL0ZHcVcvTFpxcCszdGdGMVNZTkp3WHgw?= =?utf-8?B?dFY3SnExYTRsVkoxeUNMWEdLOW1xRmNqeElUbnFBeTJ4WGNhVlk0MGh2WnVW?= =?utf-8?B?NzU5eU93Z0RQcUd6Z09zRHd5VWRYbVdiQ1lySzlCNHpZREl1VmptNmpQamUz?= =?utf-8?B?NkN1bm5nK3BSTE5SL3lTdXlBbmFJMEs5cGNKWTk2R05lc0JPMExVa1M0OXhX?= =?utf-8?B?Nmw3RHREbGM1U1VGQlltWm5zYUtwdTlJWVBKVXpNM1NCOWlNS2pIZE9Vckkv?= =?utf-8?B?QzJWaUlJbzhXVTFQRU9QdUZ0U1M5NDQ5Z1FxTmE2Z0pLaGdNeVAwaTBsbTA2?= =?utf-8?Q?cIELwMYpwf+8Hkop4HS+OBEfk?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4a01a8d-5d09-4406-2fc6-08dbdadf80ff X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2023 13:36:08.2165 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: T4R8Lrw8OOeuX8zjwTMG4/WZefO3c25QJNKJzYmvyOucQMDXoqcKAzITz73OE9wa X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB9045 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/1/2023 7:40 AM, Jie Hai wrote: > Currently, rte_eth_rss_conf supports configuring and querying > RSS hash functions, rss key and it's length, but not RSS hash > algorithm. > > The structure ``rte_eth_dev_info`` is extended by adding a new > field "rss_algo_capa". Drivers are responsible for reporting this > capa and configurations of RSS hash algorithm can be verified based > on the capability. The default value of "rss_algo_capa" is > RTE_ETH_HASH_ALGO_CAPA_MASK(DEFAULT) if drivers do not report it. > > The structure ``rte_eth_rss_conf`` is extended by adding a new > field "algorithm". This represents the RSS algorithms to apply. > If the value of "algorithm" used for configuration is a gibberish > value, drivers should report the error. > > To check whether the drivers report valid "algorithm", it is set > to default value before querying in rte_eth_dev_rss_hash_conf_get(). > > Signed-off-by: Jie Hai > Signed-off-by: Dongdong Liu > Acked-by: Huisong Li > --- > doc/guides/rel_notes/release_23_11.rst | 5 +++++ > lib/ethdev/rte_ethdev.c | 26 +++++++++++++++++++++++ > lib/ethdev/rte_ethdev.h | 29 ++++++++++++++++++++++++++ > lib/ethdev/rte_flow.c | 1 - > lib/ethdev/rte_flow.h | 26 ++--------------------- > 5 files changed, 62 insertions(+), 25 deletions(-) > > diff --git a/doc/guides/rel_notes/release_23_11.rst b/doc/guides/rel_notes/release_23_11.rst > index 95db98d098d8..e207786044f9 100644 > --- a/doc/guides/rel_notes/release_23_11.rst > +++ b/doc/guides/rel_notes/release_23_11.rst > @@ -372,6 +372,11 @@ ABI Changes > * security: struct ``rte_security_ipsec_sa_options`` was updated > due to inline out-of-place feature addition. > > +* ethdev: Added "rss_algo_capa" field to ``rte_eth_dev_info`` structure for > +* reporting RSS hash algorithm capability. > + > +* ethdev: Added "algorithm" field to ``rte_eth_rss_conf`` structure for RSS > + hash algorithm. > As well as ABI change, can you also update the "New Features", to document getting hash algorithm capability and setting hash algorithm support added? Also please add an empty line here. > Known Issues > ------------ > diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c > index 07bb35833ba6..f9bd99d07eb1 100644 > --- a/lib/ethdev/rte_ethdev.c > +++ b/lib/ethdev/rte_ethdev.c > @@ -1269,6 +1269,7 @@ int > rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q, > const struct rte_eth_conf *dev_conf) > { > + enum rte_eth_hash_function algorithm; > struct rte_eth_dev *dev; > struct rte_eth_dev_info dev_info; > struct rte_eth_conf orig_conf; > @@ -1510,6 +1511,18 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q, > goto rollback; > } > > + algorithm = dev_conf->rx_adv_conf.rss_conf.algorithm; > + if (RTE_ETH_HASH_ALGO_TO_CAPA(algorithm) == 0 || > "RTE_ETH_HASH_ALGO_TO_CAPA(algorithm)" can't be zero for valid "enum rte_eth_hash_function" values, I assume above check is for the case algorith > 31, as it will result zero. My concern is, this is undefined behaviour (shift left >= 32) and some compiler can complain about it, instead of relying this can you please add explicit "0 <= algorithm < 32" check?