From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 6CA8D9E7 for ; Thu, 10 Nov 2016 15:32:19 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id u144so53034916wmu.1 for ; Thu, 10 Nov 2016 06:32:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=Pb8vuNrQ9xFRmD5zt2xL8scdDFnrki2a116Q+vBYv4w=; b=UhekNH1qIT9KXCS9EwAjuI27qlLsIba2AcZVEtOTukw4r4cq0Z3UStfGOY4q+KwX1V nNIOwxm0SQYQXkFIjapyOzIeOTMIWcc93yTzFPfQDXUgGJGcmAKgotJWWfY4yRL94H1u 3f6yuqHLnsCEJDZcDXRMi2LwTBeWqllHfkDVQ6BMeTAEyYVlUqJ8vQPsnqnMkpPupWGq u2j98ywmuAliSnJf65hgMzEawGe4gmHUdXZ91jfsYyZnA8dYlEav51Mi5JKAlNvT2QxJ MetISaY6uMRT8C5Kwusjhqm7Gv+xb5jwZRl4QzSNRo3RXG7HCi3Retc6rnu6pASVZDGm iNwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=Pb8vuNrQ9xFRmD5zt2xL8scdDFnrki2a116Q+vBYv4w=; b=cNJinhODpeChEfcAtvikbBY6TRolyKcEdkbGQFVIMqDDOzwUAVGQaGypAF7EmSFJDu veBq32UFhzo92kv5v5nKzOMFx/hQmVm48E8W5RNNNVMIavV96Iv8epRyvx4mmXx29Ga0 EYRLCzUPJcum4DNCRZYZ0XhfoCevf0yWT3/E3M1ftN6BuJErYNVb/7Xa1AllTih3e6Qa i2gjYcI66n2Snvg2VHKoP26pdt6QYrJn7q8qpUSxzcQEE7fjjbinyCsualp4Kmdf0F3W D2Q+eIWBPsJ63MfRXv0NaXW+GcIYik85rtFr4+E5DhJi46MVB8HSbC2Q/Qdw/0gQ7TDJ /uYw== X-Gm-Message-State: ABUngveuYybzfyianwbH7eMWKAWTCZYHkEB2f88BgnHxAXoJqPx93wqpxd7GmTBTczP0giPv X-Received: by 10.194.20.99 with SMTP id m3mr1376161wje.161.1478788338799; Thu, 10 Nov 2016 06:32:18 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id j6sm5782487wjk.25.2016.11.10.06.32.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Nov 2016 06:32:18 -0800 (PST) From: Thomas Monjalon To: "Mori, Naoyuki" Cc: dev@dpdk.org, "bjorn.topel@gmail.com" , "Yao, Lei A" , "Topel, Bjorn" , "Zhang, Helin" , "Ananyev, Konstantin" , "Xu, Qian Q" , "Wu, Jingjing" Date: Thu, 10 Nov 2016 15:32:17 +0100 Message-ID: <50996464.o08F9XFMCf@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <5952EEAD-ED55-4C0B-86EB-945B87637CD2@intel.com> References: <5952EEAD-ED55-4C0B-86EB-945B87637CD2@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: force CRC stripping for i40evf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Nov 2016 14:32:19 -0000 2016-11-10 13:50, Mori, Naoyuki: > Hi, > > > Thomas wrote: > > > Just to make it sure, you mean returning an error in the driver when > > > a configuration cannot be applied, right? > > > > Yes, as in 1bbcc5d21129 ("i40evf: report error for unsupported CRC > > stripping config"), where -EINVAL is returned. > > > > Bj?rn > > On my experience, OvS+DPDK has same issue. > You cannot run OvS on i40evf due to this CRC config mismatch, while OvS on ixgbevf works fine. > So, changing on i40evf PMD side would have more benefit, I believe. No I think OVS should handle the configuration error. We could also add a function to query this capability before configuring.