DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Panu Matilainen <pmatilai@redhat.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 10/12] mk: install examples
Date: Thu, 03 Dec 2015 14:32:53 +0100	[thread overview]
Message-ID: <5099957.difSTsvb7d@xps13> (raw)
In-Reply-To: <56604155.9080007@redhat.com>

2015-12-03 15:19, Panu Matilainen:
> On 12/03/2015 07:02 AM, Thomas Monjalon wrote:
> > The examples are part of the installed documentation.
> >
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> > ---
> >   mk/rte.sdkinstall.mk | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk
> > index 902a933..13fa819 100644
> > --- a/mk/rte.sdkinstall.mk
> > +++ b/mk/rte.sdkinstall.mk
> > @@ -154,3 +154,4 @@ ifneq ($(wildcard $O/doc/*/*/*pdf),)
> >   	$(Q)$(call rte_mkdir,     $(DESTDIR)$(docdir)/guides)
> >   	$(Q)cp -a $O/doc/*/*/*pdf $(DESTDIR)$(docdir)/guides
> >   endif
> > +	$(Q)cp -a $(RTE_SDK)/examples $(DESTDIR)$(datadir)
> >
> 
> If examples are considered documentation (and I agree on that), then 
> shouldn't they be installed in $(docdir) instead?

I was hesitating. I think it's strange to install some code in
/usr/share/doc/.
It's not really important and may be changed easily at any time.

  reply	other threads:[~2015-12-03 13:34 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-02  3:57 [dpdk-dev] [PATCH 00/10] standard make install Thomas Monjalon
2015-12-02  3:57 ` [dpdk-dev] [PATCH 01/10] mk: remove multi-target install Thomas Monjalon
2015-12-02  3:57 ` [dpdk-dev] [PATCH 02/10] mk: move installation procedure in install rule Thomas Monjalon
2015-12-02  3:57 ` [dpdk-dev] [PATCH 03/10] mk: install a standard cutomizable tree Thomas Monjalon
2015-12-02 10:27   ` Panu Matilainen
2015-12-02 11:25     ` Thomas Monjalon
2015-12-02 12:54       ` Panu Matilainen
2015-12-02 13:05         ` Thomas Monjalon
2015-12-02 13:29           ` Panu Matilainen
2015-12-02  3:57 ` [dpdk-dev] [PATCH 04/10] mk: introduce new install syntax Thomas Monjalon
2015-12-02  3:57 ` [dpdk-dev] [PATCH 05/10] mk: split install rule Thomas Monjalon
2015-12-02  3:57 ` [dpdk-dev] [PATCH 06/10] mk: install kernel modules Thomas Monjalon
2015-12-02  9:53   ` Panu Matilainen
2015-12-02 10:09     ` Thomas Monjalon
2015-12-02  3:57 ` [dpdk-dev] [PATCH 07/10] mk: install binding tool in sbin directory Thomas Monjalon
2015-12-02  9:58   ` Panu Matilainen
2015-12-02  3:57 ` [dpdk-dev] [PATCH 08/10] mk: install doc Thomas Monjalon
2015-12-02  3:57 ` [dpdk-dev] [PATCH 09/10] mk: install examples Thomas Monjalon
2015-12-02  3:57 ` [dpdk-dev] [PATCH 10/10] app/proc_info: rename binary with prefix Thomas Monjalon
2015-12-02  7:44 ` [dpdk-dev] [PATCH 00/10] standard make install Panu Matilainen
2015-12-02  9:25   ` Thomas Monjalon
2015-12-02  9:47     ` Panu Matilainen
2015-12-02 10:07       ` Thomas Monjalon
2015-12-03  5:01 ` [dpdk-dev] [PATCH v2 00/12] " Thomas Monjalon
2015-12-03  5:01   ` [dpdk-dev] [PATCH v2 01/12] mk: remove testall Thomas Monjalon
2015-12-03  5:01   ` [dpdk-dev] [PATCH v2 02/12] mk: remove multi-target install Thomas Monjalon
2015-12-03  5:02   ` [dpdk-dev] [PATCH v2 03/12] mk: move installation procedure in install rule Thomas Monjalon
2015-12-03  5:02   ` [dpdk-dev] [PATCH v2 04/12] mk: install a standard cutomizable tree Thomas Monjalon
2015-12-03  5:02   ` [dpdk-dev] [PATCH v2 05/12] mk: introduce new install syntax Thomas Monjalon
2015-12-03  5:02   ` [dpdk-dev] [PATCH v2 06/12] mk: split install rule Thomas Monjalon
2015-12-03  5:02   ` [dpdk-dev] [PATCH v2 07/12] mk: install kernel modules Thomas Monjalon
2015-12-03  5:02   ` [dpdk-dev] [PATCH v2 08/12] mk: install binding tool in sbin directory Thomas Monjalon
2015-12-03  5:02   ` [dpdk-dev] [PATCH v2 09/12] mk: install doc Thomas Monjalon
2015-12-03  5:02   ` [dpdk-dev] [PATCH v2 10/12] mk: install examples Thomas Monjalon
2015-12-03 13:19     ` Panu Matilainen
2015-12-03 13:32       ` Thomas Monjalon [this message]
2015-12-03 13:35         ` Panu Matilainen
2015-12-03  5:02   ` [dpdk-dev] [PATCH v2 11/12] app/proc_info: rename binary with prefix Thomas Monjalon
2015-12-03  5:02   ` [dpdk-dev] [PATCH v2 12/12] pkg: update RPM with standard install Thomas Monjalon
2015-12-03 10:57   ` [dpdk-dev] [PATCH v2 00/12] standard make install Bruce Richardson
2015-12-03 11:02     ` Thomas Monjalon
2015-12-03 11:06       ` Thomas Monjalon
2015-12-03 11:10         ` Bruce Richardson
2015-12-03 11:07       ` Bruce Richardson
2015-12-03 13:26   ` Panu Matilainen
2015-12-03 13:34     ` Thomas Monjalon
2015-12-03 15:52       ` Arevalo, Mario Alfredo C
2015-12-03 13:45   ` [dpdk-dev] [PATCH v3 00/13] " Thomas Monjalon
2015-12-03 13:45     ` [dpdk-dev] [PATCH v3 01/13] mk: remove testall Thomas Monjalon
2015-12-03 13:45     ` [dpdk-dev] [PATCH v3 02/13] mk: remove multi-target install Thomas Monjalon
2015-12-03 13:45     ` [dpdk-dev] [PATCH v3 03/13] mk: move installation procedure in install rule Thomas Monjalon
2015-12-03 13:45     ` [dpdk-dev] [PATCH v3 04/13] mk: install a standard cutomizable tree Thomas Monjalon
2015-12-03 13:45     ` [dpdk-dev] [PATCH v3 05/13] mk: introduce new install syntax Thomas Monjalon
2015-12-03 13:45     ` [dpdk-dev] [PATCH v3 06/13] mk: split install rule Thomas Monjalon
2015-12-07 23:22       ` Arevalo, Mario Alfredo C
2015-12-07 23:51         ` Thomas Monjalon
2015-12-03 13:45     ` [dpdk-dev] [PATCH v3 07/13] mk: install kernel modules Thomas Monjalon
2015-12-03 13:45     ` [dpdk-dev] [PATCH v3 08/13] mk: install binding tool in sbin directory Thomas Monjalon
2015-12-03 13:45     ` [dpdk-dev] [PATCH v3 09/13] mk: install doc Thomas Monjalon
2015-12-03 13:45     ` [dpdk-dev] [PATCH v3 10/13] mk: install examples Thomas Monjalon
2015-12-03 13:45     ` [dpdk-dev] [PATCH v3 11/13] app/proc_info: rename binary with prefix Thomas Monjalon
2015-12-03 13:45     ` [dpdk-dev] [PATCH v3 12/13] pkg: update RPM with standard install Thomas Monjalon
2015-12-03 13:45     ` [dpdk-dev] [PATCH v3 13/13] maintainers: take responsibility for build system Thomas Monjalon
2015-12-04  9:40       ` Olivier MATZ
2015-12-03 15:31     ` [dpdk-dev] [PATCH v3 00/13] standard make install Bruce Richardson
2015-12-03 17:05       ` Thomas Monjalon
2015-12-06 15:00     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5099957.difSTsvb7d@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=pmatilai@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).