From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 8011CA045E for ; Fri, 31 May 2019 14:42:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AE276493D; Fri, 31 May 2019 14:42:01 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 6764F375B for ; Fri, 31 May 2019 14:42:00 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 May 2019 05:41:59 -0700 X-ExtLoop1: 1 Received: from mszychow-mobl1.ger.corp.intel.com (HELO [10.252.13.140]) ([10.252.13.140]) by orsmga004.jf.intel.com with ESMTP; 31 May 2019 05:41:57 -0700 To: Reshma Pattan , dev@dpdk.org Cc: anatoly.burakov@intel.com References: <20190517160757.28098-1-reshma.pattan@intel.com> From: "Laatz, Kevin" Message-ID: <50a97a4a-4feb-0922-8442-2346cfba2540@intel.com> Date: Fri, 31 May 2019 13:41:56 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190517160757.28098-1-reshma.pattan@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] lib/telemetry: add support to fetch global metrics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 17/05/2019 17:07, Reshma Pattan wrote: > telemetry has support for fetching port based stats > from metrics library. > > Metrics library also has global stats which are > not fetched by telemetry, so extend telemetry to > fetch the global metrics. > > Signed-off-by: Reshma Pattan > --- > doc/guides/howto/telemetry.rst | 9 +- > doc/guides/rel_notes/release_19_08.rst | 5 + > lib/librte_telemetry/rte_telemetry.c | 119 ++++++++++++---- > lib/librte_telemetry/rte_telemetry_internal.h | 31 ++++- > lib/librte_telemetry/rte_telemetry_parser.c | 130 +++++++++++++++--- > usertools/dpdk-telemetry-client.py | 13 +- > 6 files changed, 253 insertions(+), 54 deletions(-) Looks good to me, thanks! Acked-by: Kevin Laatz