From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B53AA04B5; Wed, 13 Jan 2021 05:09:30 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 170F7140DF4; Wed, 13 Jan 2021 05:09:30 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id DF85A140DF2; Wed, 13 Jan 2021 05:09:27 +0100 (CET) IronPort-SDR: TlEGXkldfEFubR6brV0IOEv7+40GFvz7Y6D0GxRSSmVn4JC0TpxF8FjCkwEnOG1ubukhD4A31v 0UXdVF/KpwdQ== X-IronPort-AV: E=McAfee;i="6000,8403,9862"; a="157923343" X-IronPort-AV: E=Sophos;i="5.79,343,1602572400"; d="scan'208";a="157923343" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2021 20:09:26 -0800 IronPort-SDR: 4m0BwzfGyjzEPxJ0y8jQV+CPmMCQo1tpSvLV0FzhAqHgF+L/hmbLqWCbQ6kkkvCHPRvDejy6v2 N0OFo49/d7AA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,343,1602572400"; d="scan'208";a="353306578" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga008.fm.intel.com with ESMTP; 12 Jan 2021 20:09:26 -0800 Received: from shsmsx604.ccr.corp.intel.com (10.109.6.214) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 12 Jan 2021 20:09:25 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX604.ccr.corp.intel.com (10.109.6.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 13 Jan 2021 12:09:23 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.1713.004; Wed, 13 Jan 2021 12:09:23 +0800 From: "Zhang, Qi Z" To: Weifeng Li , "Xing, Beilei" , "Guo, Jia" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/i40e: fix SFP I X722 with FW4.16 Thread-Index: AQHW5yw0DbGD9Bz9zkePyehJ5Ekx4aok8y7A Date: Wed, 13 Jan 2021 04:09:23 +0000 Message-ID: <50c03a97fb73443f865cd524ee5153b2@intel.com> References: <20210110083417.1276-1-liweifeng96@126.com> In-Reply-To: <20210110083417.1276-1-liweifeng96@126.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix SFP I X722 with FW4.16 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Weifeng Li > Sent: Sunday, January 10, 2021 4:34 PM > To: Xing, Beilei ; Guo, Jia > Cc: dev@dpdk.org; Weifeng Li ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/i40e: fix SFP I X722 with FW4.16 >=20 > When NVM API version is 1.7 or above adminq operation to set TPID is set = as > supported. This cause using adminq instead of registers. > For SFP_I_X722 FW4.16, reported NVM API version is 1.8, and this cause > adminq operation to set as supported but it is not supported on FW4.16 > Additional check added for SFP_I_X722 to not enable adminq operation. The commit log can be simplified to=20 Disable "802.1ad frames ability" for SFP_I_X722 as it does not support. >=20 > Fixes: 9efa8d28b4da ("net/i40e: fix SFP X722 with FW4.16") > Cc: stable@dpdk.org >=20 > Signed-off-by: Weifeng Li > --- > drivers/net/i40e/i40e_ethdev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index 1462248..a07879c 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -1550,7 +1550,8 @@ eth_i40e_dev_init(struct rte_eth_dev *dev, void > *init_params __rte_unused) > return -EIO; > } > /* Firmware of SFP x722 does not support adminq option */ This is not the problem of you patch, but the comment is totally misleading= , what does "adminq option" means? could you help to correct in v2?, I40E_HW_FLAG_802_1AD_CAPABLE should means= "802.1ad frames ability" > - if (hw->device_id =3D=3D I40E_DEV_ID_SFP_X722) > + if (hw->device_id =3D=3D I40E_DEV_ID_SFP_X722 || > + hw->device_id =3D=3D I40E_DEV_ID_SFP_I_X722) > hw->flags &=3D ~I40E_HW_FLAG_802_1AD_CAPABLE; >=20 > PMD_INIT_LOG(INFO, "FW %d.%d API %d.%d NVM %02d.%02d.%02d > eetrack %04x", > -- > 2.9.5