From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id BC09A2B99 for ; Mon, 4 Dec 2017 21:01:17 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Dec 2017 12:01:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,361,1508828400"; d="scan'208";a="8990194" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.178]) ([10.241.225.178]) by FMSMGA003.fm.intel.com with ESMTP; 04 Dec 2017 12:01:16 -0800 To: Jingjing Wu , dev@dpdk.org Cc: wenzhuo.lu@intel.com References: <1508488012-82704-1-git-send-email-jingjing.wu@intel.com> <1511505206-97333-1-git-send-email-jingjing.wu@intel.com> <1511505206-97333-13-git-send-email-jingjing.wu@intel.com> From: Ferruh Yigit Message-ID: <50cc7331-b737-4cc7-9a02-7f78a7c38206@intel.com> Date: Mon, 4 Dec 2017 12:01:16 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1511505206-97333-13-git-send-email-jingjing.wu@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 12/14] net/avf: enable sse vector Rx Tx func X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Dec 2017 20:01:18 -0000 On 11/23/2017 10:33 PM, Jingjing Wu wrote: > Signed-off-by: Jingjing Wu <...> > @@ -233,6 +233,7 @@ CONFIG_RTE_LIBRTE_AVF_DEBUG_TX=n > CONFIG_RTE_LIBRTE_AVF_DEBUG_TX_FREE=n > CONFIG_RTE_LIBRTE_AVF_DEBUG_RX=n > CONFIG_RTE_LIBRTE_AVF_16BYTE_RX_DESC=n > +CONFIG_RTE_LIBRTE_AVF_INC_VECTOR=y Can you please move this just below CONFIG_RTE_LIBRTE_AVF_PMD, since this enable/disable vector PMD more important than debug configs. <...> > +#ifdef RTE_LIBRTE_AVF_INC_VECTOR > +static inline bool > +check_rx_vec_allow(struct avf_rx_queue *rxq) > +{ > + if (rxq->rx_free_thresh >= AVF_VPMD_RX_MAX_BURST && > + rxq->nb_rx_desc % rxq->rx_free_thresh == 0) { > + PMD_INIT_LOG(DEBUG, "Vector Rx" > + " can be enabled on this rxq."); > + return TRUE; > + } > + > + PMD_INIT_LOG(DEBUG, "Vector Rx" > + " cannot be enabled on this rxq."); Can merge these two lines. <...> > > -/* choose rx function*/ > +/* choose tx function*/ Can you please fix this when added in patch 4/14? <...> > + rte_mempool_put_bulk(free[0]->pool, > + (void *)free, Is void * cast required? <...>