From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AEB53A00C5; Thu, 15 Sep 2022 12:20:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A02024021D; Thu, 15 Sep 2022 12:20:27 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id C319B40156 for ; Thu, 15 Sep 2022 12:20:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663237225; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=joIuis6v20cLBlhdS4bwhdwzFLe/VgoFrqXPOPJAjuM=; b=NwVSSP8Bd6/6ose4y8uNa1YoWdyWTc0CgNN0q+cBaOEMBnacb6xUbXsw30I2Xq1k4OTdRw b5UOHODbUD5tXBootN+/Rx9G3FeXazBi6qOKhFSXYgw+tearuaezjNyjoIE40gku0S5wJz ZamRRZIZMY3x4jZSkA4s4iBKmmnU3So= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-453-hTMX9FdRO3SxjhhL1-0OsQ-1; Thu, 15 Sep 2022 06:20:22 -0400 X-MC-Unique: hTMX9FdRO3SxjhhL1-0OsQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 013DE801231; Thu, 15 Sep 2022 10:20:22 +0000 (UTC) Received: from [10.39.208.12] (unknown [10.39.208.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BF1AA1121314; Thu, 15 Sep 2022 10:20:20 +0000 (UTC) Message-ID: <50d32063-a0e5-8271-b57d-f486f68e3a62@redhat.com> Date: Thu, 15 Sep 2022 12:20:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2 29/37] baseband/acc100: update device info To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com References: <20220820023157.189047-1-hernan.vargas@intel.com> <20220820023157.189047-30-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20220820023157.189047-30-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/20/22 04:31, Hernan Vargas wrote: > Remove unused capabilities, use dummy operation as start count for > number of queues. > > Signed-off-by: Hernan Vargas > --- > drivers/baseband/acc100/rte_acc100_pmd.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c > index 7b23529ec3..4ce4c9d218 100644 > --- a/drivers/baseband/acc100/rte_acc100_pmd.c > +++ b/drivers/baseband/acc100/rte_acc100_pmd.c > @@ -1079,7 +1079,6 @@ acc100_dev_info_get(struct rte_bbdev *dev, > { > struct acc100_device *d = dev->data->dev_private; > int i; > - > static const struct rte_bbdev_op_cap bbdev_capabilities[] = { > { > .type = RTE_BBDEV_OP_TURBO_DEC, > @@ -1091,7 +1090,6 @@ acc100_dev_info_get(struct rte_bbdev *dev, > RTE_BBDEV_TURBO_EARLY_TERMINATION | > RTE_BBDEV_TURBO_DEC_INTERRUPTS | > RTE_BBDEV_TURBO_NEG_LLR_1_BIT_IN | > - RTE_BBDEV_TURBO_MAP_DEC | > RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP | > RTE_BBDEV_TURBO_DEC_CRC_24B_DROP | > RTE_BBDEV_TURBO_DEC_SCATTER_GATHER, > @@ -1186,12 +1184,13 @@ acc100_dev_info_get(struct rte_bbdev *dev, > d->acc100_conf.q_ul_5g.num_qgroups; > dev_info->num_queues[RTE_BBDEV_OP_LDPC_ENC] = d->acc100_conf.q_dl_5g.num_aqs_per_groups * > d->acc100_conf.q_dl_5g.num_qgroups; > + dev_info->num_queues[RTE_BBDEV_OP_FFT] = 0; > dev_info->queue_priority[RTE_BBDEV_OP_TURBO_DEC] = d->acc100_conf.q_ul_4g.num_qgroups; > dev_info->queue_priority[RTE_BBDEV_OP_TURBO_ENC] = d->acc100_conf.q_dl_4g.num_qgroups; > dev_info->queue_priority[RTE_BBDEV_OP_LDPC_DEC] = d->acc100_conf.q_ul_5g.num_qgroups; > dev_info->queue_priority[RTE_BBDEV_OP_LDPC_ENC] = d->acc100_conf.q_dl_5g.num_qgroups; > dev_info->max_num_queues = 0; > - for (i = RTE_BBDEV_OP_TURBO_DEC; i < RTE_BBDEV_OP_LDPC_ENC; i++) > + for (i = RTE_BBDEV_OP_NONE; i <= RTE_BBDEV_OP_LDPC_ENC; i++) > dev_info->max_num_queues += dev_info->num_queues[i]; > dev_info->queue_size_lim = ACC100_MAX_QUEUE_DEPTH; > dev_info->hardware_accelerated = true; Reviewed-by: Maxime Coquelin Thanks, Maxime