From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5542EA0C48; Mon, 14 Jun 2021 22:56:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0F6844067E; Mon, 14 Jun 2021 22:56:12 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 401274067A for ; Mon, 14 Jun 2021 22:56:11 +0200 (CEST) Received: from [192.168.1.71] (unknown [188.170.85.171]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 706FB7F504; Mon, 14 Jun 2021 23:56:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 706FB7F504 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1623704170; bh=xrfRs/nyoAcdWS3zzWntIFLtD1fPvQzv+jrytWyAAhc=; h=Subject:To:References:From:Date:In-Reply-To; b=NhcgliTsMaiBHPdCJS2/XJidybJFo7lxoJ6Wk8wVTCrbTelYDUZW9fKY4Y/aKDz+6 wBloUvueE8F9dtC+DtxzQ1iwZQMjF7OYzJAWloGdkzPPqjGmEwYEmpkOAFWdZBPIB4 bdsLGqHPdy7CK/S/t6Jiz+ZB75GbsaFExtMVt/9Y= To: Jiawen Wu , dev@dpdk.org References: <20210602094108.1575640-1-jiawenwu@trustnetic.com> From: Andrew Rybchenko Message-ID: <51042147-7378-f633-ac31-edfb03231f77@oktetlabs.ru> Date: Mon, 14 Jun 2021 23:56:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210602094108.1575640-1-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 00/24] net: ngbe PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/2/21 12:40 PM, Jiawen Wu wrote: > This patch set provides a skeleton of ngbe PMD, > which adapted to Wangxun WX1860 series NICs. My main concerns for the patch series except style notes is a separation info patches. Every patch should be testable. I should be able to stop at any patch in the series, do build and test functionality added by the patch. It should be no dead code. Split should be feature based and different features should be added by different patches. Above requirements are not that strict for base driver. Of course, it would be useful to follow it, but not strictly required since sometimes it is very hard to do. As for the PMD specific code, it should be done this way. Otherwise, it is almost impossible to review it and understand if something is lost or missing or inconsistent. Of course, closely related features with share almost all its code may be added together. Initially the driver should be built up to the working state with absolute minimum feature set. No offloads, no extra configuration options. It should be able to probe, configure, start, Rx, Tx, stop, reconfigure, start again etc, close. Subsequent patches should add features one by one: loopback, deferrred start, various offloads, ptype etc.