From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C619BA0C47; Thu, 14 Oct 2021 14:05:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4F1AF4112E; Thu, 14 Oct 2021 14:05:08 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 777BA40041 for ; Thu, 14 Oct 2021 14:05:06 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id EF9C85C015B; Thu, 14 Oct 2021 08:05:04 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 14 Oct 2021 08:05:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 4VfXTfjOyYvi9WIU8UbcmttiBvRtX2jiBn3bN8X58TM=; b=CS7DMKHZ7amr8cyW OSGda455Bv1qn3/jfCNnjWX+ojKgNF4oHwdHu2O53XiuwO1M46Fb4EZlvGqd5G4+ gPn4ZYCu19BGlXSXuYdwV7DpOZk/AH5k5KWoMag5QFKT6lF6HoIZuppEeB5v8wFt qXNYUItNccV+k/zrFH3DdduuxLN1kvhiS0m3x2GhmGVHTbxTTh5X0kgqT83/l1l6 bzm7bSmnLOL8yu+Yn3G9sbbvAUeT0lp9wRkuERkUKiIxFoog61X8rEka0KsryI2c jBHJiJi1GLYAAWcXshB6ZzGEafHTDoe9vVGx3gmmECbD8VEXxeSlPyXSEYnKIMli aggZfw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=4VfXTfjOyYvi9WIU8UbcmttiBvRtX2jiBn3bN8X58 TM=; b=UO2B7pYxoUizHQ51zz6yW8cMEh5kZoo8pMVIge46xk4o7PvX6kW5L9TKE PWX06rsUGnx3Yr1SuXCSv/kk/t0W2dh+M6wiSjncWmQQ+BmrodYiSdhDeQbaHbqV +HasMNDc62TxL0FDMfjMefp5gTiOYUtyTdwRUZla/ENS0TWqR0/zesd/PTUzIees 7fPIGPI0y7nqSPklcO9GnJZ5iiodhC7hgI6q4pPXLq+xRKCot4fmC3/k531ysjS1 xfsGVdCwU98aTDR15UHBdeE5vEDvPoYWxxT1ZVrKjhyxQe2+CrLdsgCh6GNbpyl3 mzkS6ATxearSZIpXVsgyRrfw0ZbNA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvdduvddggeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 14 Oct 2021 08:05:02 -0400 (EDT) From: Thomas Monjalon To: Harman Kalra Cc: David Marchand , "dev@dpdk.org" , Raslan Darawsheh , Ray Kinsella , Dmitry Kozlyuk , "viacheslavo@nvidia.com" , "matan@nvidia.com" Date: Thu, 14 Oct 2021 14:04:59 +0200 Message-ID: <5109147.Qdy3pJ9HuF@thomas> In-Reply-To: References: <20210826145726.102081-1-hkalra@marvell.com> <2130106.uiXJXLAz8d@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v1 2/7] eal/interrupts: implement get set APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/10/2021 12:44, Harman Kalra: > > > But just for understanding, as David suggested that we preserve keep > > > this flag then why not use it, have rte_malloc and malloc bits and make a > > decision. > > > Let driver has the flexibility to choose. Do you see any harm in this? > > > > Which flag? > > In V2, I have replaced the bool arg with an 32bit flag in alloc api: > struct rte_intr_handle *rte_intr_instance_alloc(uint32_t flags); > > Declared some flags which can be passed by the consumer > /** Interrupt instance allocation flags > * @see rte_intr_instance_alloc > */ > /** Allocate interrupt instance from traditional heap */ > #define RTE_INTR_ALLOC_TRAD_HEAP 0x00000000 > /** Allocate interrupt instance using DPDK memory management APIs */ > #define RTE_INTR_ALLOC_DPDK_ALLOCATOR 0x00000001 > > As a future enhancement, if more options to the allocation is required by user, > new flags can be added. I am not sure we need such flag.