From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0055.outbound.protection.outlook.com [104.47.36.55]) by dpdk.org (Postfix) with ESMTP id DCB061B803 for ; Wed, 25 Oct 2017 07:13:32 +0200 (CEST) Received: from BN3PR03CA0095.namprd03.prod.outlook.com (10.174.66.13) by MWHPR03MB2702.namprd03.prod.outlook.com (10.168.207.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.156.4; Wed, 25 Oct 2017 05:13:31 +0000 Received: from BN1BFFO11FD006.protection.gbl (2a01:111:f400:7c10::1:195) by BN3PR03CA0095.outlook.office365.com (2603:10b6:400:4::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.156.4 via Frontend Transport; Wed, 25 Oct 2017 05:13:31 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1BFFO11FD006.mail.protection.outlook.com (10.58.144.69) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.156.4 via Frontend Transport; Wed, 25 Oct 2017 05:13:30 +0000 Received: from [10.232.133.65] (B10814-12.ap.freescale.net [10.232.133.65]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v9P5DPHp019890; Tue, 24 Oct 2017 22:13:25 -0700 To: Akhil Goyal , References: <20171014221734.15511-1-akhil.goyal@nxp.com> <20171024141545.30837-1-akhil.goyal@nxp.com> <20171024141545.30837-2-akhil.goyal@nxp.com> CC: , , , , , , , , , , , From: Hemant Agrawal Message-ID: <51222096-8849-9f3e-0b74-4cd5383ba5f3@nxp.com> Date: Wed, 25 Oct 2017 10:43:24 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20171024141545.30837-2-akhil.goyal@nxp.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131533820111472756; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7966004)(336005)(39380400002)(39860400002)(376002)(346002)(2980300002)(1110001)(1109001)(339900001)(24454002)(199003)(189002)(8936002)(65826007)(50986999)(229853002)(5660300001)(77096006)(4326008)(54356999)(76176999)(2950100002)(7416002)(65806001)(6246003)(47776003)(106466001)(65956001)(230700001)(356003)(97736004)(53936002)(189998001)(33646002)(31686004)(86362001)(305945005)(23746002)(50466002)(68736007)(15650500001)(105606002)(31696002)(8676002)(36756003)(81156014)(81166006)(316002)(85426001)(83506002)(53546010)(58126008)(64126003)(54906003)(104016004)(2906002)(5890100001)(110136005)(498600001)(8656006); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR03MB2702; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD006; 1:E+7phDWcbyv0co7esQApg0FYOxjciAXYiQWZChdjGWefsNcLRvoxzVMxmsau2jbIa/xHdAncwS1aiYKTdBQTsZ2wphg2e1k+sONTNhbaD0SGIakR/N9x6RGz17Kgjoc2 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 028a38ca-a780-424d-c874-08d51b672228 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4628075)(201703131517081)(2017052603199); SRVR:MWHPR03MB2702; X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2702; 3:339mQDPJQeJQdSB0ok/97/rR96pB64xyLYxBXJDYl+84j41llsJy168JUu2oWnPVIE/xlEHtA+5Ei05NXsNbmmZijGmOx+hysw/qlzq6R+IDOiJ1fm39QWyc26wKz3xtbu2EGBREu8orI9x2jzqLsT/7IUUYR8VyqTHyVrWaN5hGondEJRciXHTXOb6wGzX9RsTWY5c10sp0LwZW4Q+K3sfMaRX7JgYnxyjUpYgLXG9PxrLKBRVEfPpp/fZn7cV3+BVJMhrzSWwRqgup0I3GiCPZ4bKDWxgLWiBAMW9jYKD0Y7JOef16leJC0E8COCcmBR3iyUzL8e/6dPsJH8qctSFiVEcb2VBx+oUhUSP+eCA=; 25:DGIkYTcF4Kv7rpVZVvcBXMhNw83dGuZcpUHK/2c37NyNPuGJ27p2Mhph8qa2H1Z5lOmdJ/zdaTAS+uQduxrZPlWzVU8574OE0CDI/jPQmWqFby7OYlXMffsnwZ7bEdR2cbXlBesChEAo6+YlEoMCx3UUv6fgY6qEMkWxqi72QzE32MWjAh9kUhOJk7LivKtUzEYOKSvHK5QZABV9ax66nNR0oypXQ8ZmdLVoX2/dIc5QA4n9tiN0v2VHtnIBO2vWnh3gS2nju+8k6gDWlYir8lMTCk4ow8DUclEyTt/TjijsrD045CrqLaFenRlbkCEawTkNwk0UsuUVuPgstGM3aQ== X-MS-TrafficTypeDiagnostic: MWHPR03MB2702: X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2702; 31:1yC6D+nrJLQXxWPTJhmIyZkuIY7hN8hfByZ6h3SbLsshsc1Uqj//r0LxY0EL/l4lrQtgVhlBh/AhNuR82OsebRmpq5j7YDxlG62MuZkBKzsiCYp8POlgcTGZ4Pa6K9fSCslza2ehzmlG4yofriT05aykwPePUOHxc5DCSaYwdD3bgJyaIV9TkAsaPyRbyaQy/zN1kfYRrb0xp9GIW8QxKEQAiI1yyZ21ABHWXW2v27Y=; 4:1RhXDXCDB2A42BYAfybWDyt+iA/c4tvBBDMvka77rg5O+Tf/93h0jaaR27vY5edCUmJs5dOA63vpKxnNRgNCzpkZTwfW8I4prI0Pw4b68HZ1hhjVZ52phgYFp9a2RkqLwv+FFu6ugJ6JWw3bfDN0HamqoWyMumTy/fV28mroyd47wvufEU9rEe5IdhTAS2Nm4NkOAhveUaxO3UTBN/p+8yTvraxg7Hwu75eZeFxZcwM+PR2Ge22sF/I28w59wHWo0/p/3GZnCVMU025V4R8eqeuDM6rCuH/0mAru5Tigf1vyUMo5lVBL2q+2wIWgRFbrUHbr6uCKjD9LEfoO7Hh88+sGgWYSmb8cWANQMz3rmgFKVWbwbWzorYsYYh9MSeb3 X-Exchange-Antispam-Report-Test: UriScan:(192374486261705)(185117386973197)(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(5005006)(8121501046)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(3231020)(6055026)(6096035)(20161123559100)(20161123563025)(20161123561025)(20161123556025)(201703131430075)(201703131433075)(201703131441075)(201703131448075)(201703161259150)(20161123565025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:MWHPR03MB2702; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:MWHPR03MB2702; X-Forefront-PRVS: 0471B73328 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; MWHPR03MB2702; 23:jyFApoPgazanCiozcTskJXWvGPHo9fHmWGNeD?= =?Windows-1252?Q?iIzNmCJc/pV1G1AJcehV3Ip1vyg8A94wh2Vl9rd2WAMrGIAWA1wSmSHo?= =?Windows-1252?Q?BByuelqrd8j2Pnjk8WriVYJcxJWnsZIfste2ahPsdv2ir5rI+xdwUkE1?= =?Windows-1252?Q?dRz4VI3CJls8iqxxrnPXTO7aEeluKDv/6oe82qYcuwcE7nNN5dGwPQsO?= =?Windows-1252?Q?FwKTX8WwP5sl0X6yesR05xtruhXqit6JdcEPCv7tCNBCfn+STqLTmyVl?= =?Windows-1252?Q?zrSbW9bOFUWygREsM6ebALV6PXHoDx2rZ+N4s3smp2Y3zQaVJfm0eVat?= =?Windows-1252?Q?YU32bhv3pmE3PjoeAIIFLolsYTDaheIvRilNgd7LnylG5PCvKg7rO0py?= =?Windows-1252?Q?FCe1IvPK5/oay7C476zzuTZMMlXaTID8KVmN7iwGZdV8BGYD6U6bv17N?= =?Windows-1252?Q?GUUW7hU9FcAtXZZ32wwFTiVxg5FtcbvPsK2vxeIC4Dhq8dXG9dk9CN78?= =?Windows-1252?Q?WiUTHbcyzXDd4Ohdvt3D0gSZHQAApyRB/nn6T4Xsy3zwlytzJfYqvRTM?= =?Windows-1252?Q?RQb6fJqPpK8RVqq3oJwbSD7UsPhJAaXE99WigzOrHRrA4ACkZz0fwY78?= =?Windows-1252?Q?hyS0bwbOzQxo5uwxlbn/QLIQ9KPN6cUlDcGT4RkPLdp369vqoz+ia+RQ?= =?Windows-1252?Q?xeq21A8qBW+ilYeG8ltPBXC1F9+ZOXBIVBIFboPK87mH9iPxffofJHD/?= =?Windows-1252?Q?BdHDQZ2HnIAre0NpnrdiHBJZ6kp9vukiLyAE2oSyCkZsHKcFBuexdVUi?= =?Windows-1252?Q?0TZDsmoEAlAWwDDfsWLE04iirMT3BvJA1jMUsJ8fcClSMwhCUeSoR0T1?= =?Windows-1252?Q?4VPc0widFtA/zcjYnNtbOaYQkOQDjI3wjZKReNag+Z9wUWvlUe2MpBsu?= =?Windows-1252?Q?OEj8R7sPSXlWqrDCB/A/Psg8+hRbhFhbrnTMZYMbxkoyxWlqYn+P/FZq?= =?Windows-1252?Q?zlWh1i14FXOrV7lnqHd2Bsm2CjxCHJuWXZnfIUJunGgrs+V2HwSvlrPD?= =?Windows-1252?Q?oMPCzRaliUACG9ZngDgvHQYonLJ5U6pGGq9+tIvw46e4HlnOR4kLMcYo?= =?Windows-1252?Q?mZoDXsvJuYh1ZoEsjZHS0awjzJ440fwB+5m/dceVZV/MvxqM3jOV9d7G?= =?Windows-1252?Q?RClS/DcWqqRu8wLWioe0dGnHqFbEfc3zKamuVq1PncNqGBt+TbKTh+G5?= =?Windows-1252?Q?eT0daBDQwPEXyGPMkOajrENE76IIBKIzpOi268BCo+u1XLQukEePSh58?= =?Windows-1252?Q?pcuNu279UO4xg/YjthctouDxFCRmjrzlERlEkUt5P8TT/8l8CwgQFkKN?= =?Windows-1252?Q?54lY2QXM5Dfg43Yl3QkDf8AvimMS11kn1/2zQAM08EvputDLC8hK0nHb?= =?Windows-1252?Q?SempBybIy9NTkTXz0QXoy3OM9xJOR/xRzM74wBu5ok4xl+jpoGPsC+pX?= =?Windows-1252?Q?s+ZHvJbK8rNuCHlzAW/mbop9wHGHuNx3yV2SscvlBdvQpdYA4Yph1bhG?= =?Windows-1252?Q?cOaqSxK2YSIgF0=3D?= X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2702; 6:ZHQtrO0iEhD3NslCPp4pBSpC3O/vo7BXi3O9+azKYqF0SpHox0SJd0JWCrM4HvrAA+dezPe0qQr5Pds2DhPxzj1Dz1r24bAF+lTAdBj3fCOJ5Lz5PEzzYxeAhjEKRqPreUrhPmF93qvd2iJ4d7CsL4ckxLXQsEPpv573MVSuo59QODEPAwMvRJuHD1pFobN4Yw6QpuMIVJfH+Fsc5cfWBY3IMN4xSbNBFSN39hpy9v9Ik5u2LhjZokhbzTsAn3EIv38gZRBVxRiV3maDqw1ilaaP9O+VjAnTdzhxcjQpM68pRauXTo9KPJQ2HRz2e6KB3itKhVBsWP/TTNVA8Ip9Vw==; 5:V85LYamZ8KF0cNXCf/ENhwhcJ6lpXc3DK3XUjWOjizqjEZJo60tak9aHgt9uOvcH6Bc/E/4C1zLKGubs4wme0b+zmfQ6vkY8aXrAhuSfzhpzsM/O/57pxlxcTSLlF1m+VnAHXtFYgXnJkdaZAUDTSw==; 24:/evFnyMg/vxRGRtq2uGpWt0F0l/f+7P2cGji7LYky8lVQE/Yw279KA6ooOWhCsMttluYeN/G66Mr4+GzakfHT5t3uKh+7/YLPnV7s2PIDIk=; 7:t3JOlTj7VBW1FOTkHFMw+xY/fRqNH15DiLjyDju9sCETXX6Ztr+tx670oT3+C3P1+oSkMFxTEYExp1MKOkuB7ia8WMPlFPOO4QCEf5dZMLYr4Y6b9RqukSfyA4B+ZEGGQk7v8PqG31YeQ1mhU5l5XZr9aWQde9jTuVc5c1YXFFLYaNA3aDS0H9Lq6l9XN2t0+vqmZGSAV0WO/XHwhM+N6/jr0tAMaZYHw0MIWWmoJp4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2017 05:13:30.8352 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 028a38ca-a780-424d-c874-08d51b672228 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2702 Subject: Re: [dpdk-dev] [PATCH v5 01/11] lib/rte_security: add security library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2017 05:13:33 -0000 Hi Akhil, Some minor comments. On 10/24/2017 7:45 PM, Akhil Goyal wrote: > rte_security library provides APIs for security session > create/free for protocol offload or offloaded crypto > operation to ethernet device. > > Signed-off-by: Akhil Goyal > Signed-off-by: Boris Pismenny > Signed-off-by: Radu Nicolau > Signed-off-by: Declan Doherty > Signed-off-by: Aviad Yehezkel > --- .. > diff --git a/lib/librte_security/rte_security.h b/lib/librte_security/rte_security.h > new file mode 100644 > index 0000000..87b39fb > --- /dev/null > +++ b/lib/librte_security/rte_security.h > @@ -0,0 +1,528 @@ > +/*- > + * BSD LICENSE > + * > + * Copyright 2017 NXP. > + * Copyright(c) 2017 Intel Corporation. All rights reserved. > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions > + * are met: > + * > + * * Redistributions of source code must retain the above copyright > + * notice, this list of conditions and the following disclaimer. > + * * Redistributions in binary form must reproduce the above copyright > + * notice, this list of conditions and the following disclaimer in > + * the documentation and/or other materials provided with the > + * distribution. > + * * Neither the name of NXP nor the names of its > + * contributors may be used to endorse or promote products derived > + * from this software without specific prior written permission. > + * > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR > + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT > + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, > + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, > + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY > + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > + */ > + > +#ifndef _RTE_SECURITY_H_ > +#define _RTE_SECURITY_H_ > + > +/** > + * @file rte_security.h > + * > + * RTE Security Common Definitions > + * minor comment: better to add: @b EXPERIMENTAL: this API may change without prior notice > + */ > + > +#ifdef __cplusplus > +extern "C" { > +#endif > + .. > + > +/** > + * Create security session as specified by the session configuration > + * > + * @param instance security instance > + * @param conf session configuration parameters > + * @param mp mempool to allocate session objects from can you fix the spacing for *mp* details here? > + * @return > + * - On success, pointer to session > + * - On failure, NULL > + */ > +struct rte_security_session * > +rte_security_session_create(struct rte_security_ctx *instance, > + struct rte_security_session_conf *conf, > + struct rte_mempool *mp); > + > diff --git a/lib/librte_security/rte_security_driver.h b/lib/librte_security/rte_security_driver.h > new file mode 100644 > index 0000000..78814fa > --- /dev/null > +++ b/lib/librte_security/rte_security_driver.h > @@ -0,0 +1,155 @@ > +/*- > + * BSD LICENSE > + * > + * Copyright(c) 2017 Intel Corporation. All rights reserved. > + * Copyright 2017 NXP. > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions > + * are met: > + * > + * * Redistributions of source code must retain the above copyright > + * notice, this list of conditions and the following disclaimer. > + * * Redistributions in binary form must reproduce the above copyright > + * notice, this list of conditions and the following disclaimer in > + * the documentation and/or other materials provided with the > + * distribution. > + * * Neither the name of Intel Corporation nor the names of its > + * contributors may be used to endorse or promote products derived > + * from this software without specific prior written permission. > + * > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR > + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT > + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, > + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, > + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY > + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > + */ > + > +#ifndef _RTE_SECURITY_DRIVER_H_ > +#define _RTE_SECURITY_DRIVER_H_ > + > +/** > + * @file rte_security_driver.h > + * > + * RTE Security Common Definitions RTE Security driver related common function definitions. @b EXPERIMENTAL: these API may change without prior notice > diff --git a/lib/librte_security/rte_security_version.map b/lib/librte_security/rte_security_version.map > new file mode 100644 > index 0000000..8af7fc1 > --- /dev/null > +++ b/lib/librte_security/rte_security_version.map > @@ -0,0 +1,13 @@ > +DPDK_17.11 { This should be EXPERIMENTAL > + global: > + > + rte_security_attach_session; > + rte_security_capabilities_get; > + rte_security_capability_get; > + rte_security_session_create; > + rte_security_session_destroy; > + rte_security_session_stats_get; > + rte_security_session_update; > + rte_security_set_pkt_metadata; > + > +}; >