From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2090545CCC; Sun, 10 Nov 2024 01:04:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B6AE8402A0; Sun, 10 Nov 2024 01:04:58 +0100 (CET) Received: from fout-b7-smtp.messagingengine.com (fout-b7-smtp.messagingengine.com [202.12.124.150]) by mails.dpdk.org (Postfix) with ESMTP id 9C6CC40291 for ; Sun, 10 Nov 2024 01:04:57 +0100 (CET) Received: from phl-compute-12.internal (phl-compute-12.phl.internal [10.202.2.52]) by mailfout.stl.internal (Postfix) with ESMTP id 9F9FB114010D; Sat, 9 Nov 2024 19:04:56 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-12.internal (MEProxy); Sat, 09 Nov 2024 19:04:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1731197096; x=1731283496; bh=ZJrdApYmMrp1qsLNFKZmsYueJhJJ+esGr9z/UMDa8Ms=; b= VSbCFzdXsXs/glh0JffdYSNlc0yxeaNRJUcQSUpZa9d7lncHIgIkbZgzNindQgP1 keqyV5qXkFynonjUn8f2Iu+pELFRM7CKn5IUXBmJG8OW/lyMBwCoERHGgVgRHbwy q1Q/eyL9VPEcC547nohTKH4M4ww4euK43c7B4rlVIW9uNbXnvpab5KPUPh7UumLm PO5u91jBG3mgc0J7S3dqfuOqinpF3egJHCDFt5q/hMiuUeOV2zLeVT7SePflmXXQ Lx57hORv90++WSv1I+AXlIpzOtMooBXHUs+I5HOctJ3ujgnauwEb52cIvyhOpX6E kCHO0Q6uVJ5dn1ikHNGedw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1731197096; x= 1731283496; bh=ZJrdApYmMrp1qsLNFKZmsYueJhJJ+esGr9z/UMDa8Ms=; b=V Aw4AGOCcLoil7gDDzn5S4rtwlQM6F+67wNOHMz4vAKaSy9/AFRZMg7aN7IBRJg/L t6K03QDlE0AUZIa9fjPPygDVbzKMPNk3BKPK/6NzK4RApRLHHT8LuJmUztmuiNRk BOf+jE4yoTOSlkipMlV8pk3pQJslS6EIZVlJafOZAap0zUdxejrNdvA8Z2F0x4Ov qP8TWV+3X3LlzLqa7RdoBpVcRPaMHd9eR+s2MPCNQ2RRiefPAfquAjZWUJMaUHxC bETeWa9Z0/QNUomPvjtrVgIP7+FPuYwbAWo8etzzUcWrCu5mrLP/Q8kSwj8YW0zI ANqTyjmXMswVpCgTUGrTw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrtdelgddujecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdejnecu hfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlh honhdrnhgvtheqnecuggftrfgrthhtvghrnhepjeduveehieevuddutdevfffgtdegkeeu veejffejgedtgeegkefgvdeugfefkeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthdpnhgs pghrtghpthhtohepjedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohephhgvmhgrnh htrdgrghhrrgifrghlsehngihprdgtohhmpdhrtghpthhtohepshgrtghhihhnrdhsrgig vghnrgesnhigphdrtghomhdprhgtphhtthhopehrohhhihhtrdhrrghjsehngihprdgtoh hmpdhrtghpthhtohepvhgrnhhshhhikhgrrdhshhhukhhlrgesnhigphdrtghomhdprhgt phhtthhopeguvghvseguphgukhdrohhrghdprhgtphhtthhopegrnhgrthholhihrdgsuh hrrghkohhvsehinhhtvghlrdgtohhmpdhrtghpthhtohepuggrvhhiugdrmhgrrhgthhgr nhgusehrvgguhhgrthdrtghomh X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 9 Nov 2024 19:04:54 -0500 (EST) From: Thomas Monjalon To: Hemant Agrawal , Sachin Saxena , Rohit Raj , vanshika.shukla@nxp.com Cc: dev@dpdk.org, Anatoly Burakov , David Marchand Subject: Re: [v5 06/42] bus/fslmc: add close API to close DPAA2 device Date: Sun, 10 Nov 2024 01:04:52 +0100 Message-ID: <5125916.3VsfAaAtOV@thomas> In-Reply-To: <20241023115955.1207617-7-vanshika.shukla@nxp.com> References: <20241022191256.516818-1-vanshika.shukla@nxp.com> <20241023115955.1207617-1-vanshika.shukla@nxp.com> <20241023115955.1207617-7-vanshika.shukla@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 23/10/2024 13:59, vanshika.shukla@nxp.com: > +static int > +rte_fslmc_close(void) > +{ > + int ret = 0; > + > + ret = fslmc_vfio_close_group(); > + if (ret) > + DPAA2_BUS_ERR("Unable to close devices %d", ret); > + > + return 0; > +} You should not try to close if there is no devices on this bus. The error message is polluting cleanup for everybody. I change to info log level for now while merging.