From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A1CBEA0C4E; Tue, 2 Nov 2021 18:07:27 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E3FE4069F; Tue, 2 Nov 2021 18:07:27 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id E769F40689 for ; Tue, 2 Nov 2021 18:07:25 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10156"; a="230034355" X-IronPort-AV: E=Sophos;i="5.87,203,1631602800"; d="scan'208";a="230034355" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2021 09:22:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,203,1631602800"; d="scan'208";a="728410370" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga006.fm.intel.com with ESMTP; 02 Nov 2021 09:22:47 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 2 Nov 2021 09:22:47 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 2 Nov 2021 09:22:46 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 2 Nov 2021 09:22:46 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 2 Nov 2021 09:22:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EyVI8uFDRhksQPsqkJaYPqZJbj8jbKhinIUCQQWfGBlQAy5P+Tz3oj3deu5YgPuU9OqaFwm3JRgUjP+hYJf3/68gwbw19wrd5RgvbR24QP28n9ya95vSUROjqPuL6cTeVJOSSSS66O2FlNd4fFiEKLh1vrmlQvkxImshG8ehsUX0Z101Sqq0IhupOEnw2JRpoQdaqKiVj7FWydLwFdaKbzjWrQGPRPItVEHqrVY5uDCDj4fyY0s+f8aZhQ3rQ5m7D5n92y2HQ0IyjCtE2InIunthKzdBrCSv1mU0PtIJ5NVsjgMr3PWq3qozjL4IHRCjth7YJevDOqpjT4Pr3K/93Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VQ2wa0AesEUpt/CvkiQfppGjkcLU4kCU7VtNGq7qk4k=; b=fB4US2FMXME9HUZBSNnOROZ7vsWXEJI4gE7vFrBXXlPpxnkpTaA/qevo0q6aQi3x3FG3XqPX+6hcjW9BRAMJJZK6zKANpbcV6Kq+TjzW/0n2H6BKY/twbQ3HNrlcnAvN1eJB8dkJUL5VIDEUb2nonW89jwynGSuSybjl8gY7e4l6R7wJCU2REoVX0eCwZhcqWrk2x+Cyhhx7cD3Pv8eOShzI42e7hM22y/vKOX3TVjvn8mfAMWZ+CWxEeXFzPcXYpUC5VAGIkp/HLbgtXxQL6pPy5dUh3V6ue4wCxaHxue6waZutBJOJYBUGHagtZMpRvQbFsvsHWs4jpXTefEUcnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VQ2wa0AesEUpt/CvkiQfppGjkcLU4kCU7VtNGq7qk4k=; b=NJlHyUUoV66rSq7T9/xfM27EMwg4lyiRDQU7UJxurauhPA/NFXJmz2Rs7YeB1SGx8kD8uFC1n22pF5F179ZNrewmq4xvhiTe9wjXnF/XFhXwsKqkd4GVMNi9NHHre+klJ1MZu8e90XLpXlZw0N+IvCIH2n1RsM2mPZIL8APJElE= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4981.namprd11.prod.outlook.com (2603:10b6:510:39::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.13; Tue, 2 Nov 2021 16:22:44 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4649.020; Tue, 2 Nov 2021 16:22:43 +0000 Message-ID: <512734d7-9177-75fd-1d89-cefc356e0e3e@intel.com> Date: Tue, 2 Nov 2021 16:22:35 +0000 Content-Language: en-US To: Junfeng Guo , , , CC: , References: <20211101083612.2380503-5-junfeng.guo@intel.com> <20211102053918.4063391-1-junfeng.guo@intel.com> <20211102053918.4063391-5-junfeng.guo@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211102053918.4063391-5-junfeng.guo@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DBBPR09CA0014.eurprd09.prod.outlook.com (2603:10a6:10:c0::26) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DBBPR09CA0014.eurprd09.prod.outlook.com (2603:10a6:10:c0::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.17 via Frontend Transport; Tue, 2 Nov 2021 16:22:42 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 358a8b6e-e9c6-4e62-9958-08d99e1cffa9 X-MS-TrafficTypeDiagnostic: PH0PR11MB4981: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3826; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2f0UnEbWcsqXgUQX3xR0OJLc4Gv16Jm754rCxImQ4TU84NUvD7GeWl52r+jzYZZCRtb92f2SPjh4m12SkotBgwIxc9oIU+StGS3/1EDlLFdKsr0C5zxLIMKRLpCdRpLH9cF3x0M+5hm6onACqwbEMOTyTFUYfpq55OZUkIzOCvrzo9Wk5N8q99+4bcMy9P6RLVQAz+7nBetKzd1KzOqa8j+BTBhlB1DJU3hA271cRIjVLrXTNUlaUCzA1KhorVmCctcBJS0MDPJlLT2cg58TQrVF/wha6ikgiijMpWM5zJfh8ydrK2N+JtcQMK5/nk9e3Afrp1rMfiIp4nFCYQqSwTMfkhO/8YhwcGGULGtZiqNcPG0lAspUgXmvNsN2ULJOd0AdOLQakydt3bVN6ewUwihyAW0+af2uYt87gQMuoq31tKmZOn2pur5V9M25Wk1hUtWGLAA9QOrCqqH10qYGYDwi1AHpBCIEut84fuuAOzeauTPKT5TsPn9cqD+oaD8u8DQZbdfrGTBd5RWddCI10xfRGh+k65jmfYkXl9iwFTJYRX1HQuuWK9c9iVL8D1nW3mRNpZmUa3TtS3vink1YdU7SfQdbmWnjxZEegw1iZz0uEbDn67PsWA940UnXp2zYSOTnbSUP1SroJlcJZYm6CTYN4QFh+bFHTQDnx5GSnqzywx2hBPsipCo80x2S1ZlhQ5xLWInvO1yU0jW2/PFnPQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(6666004)(66556008)(956004)(36756003)(2616005)(316002)(86362001)(82960400001)(107886003)(44832011)(2906002)(66946007)(16576012)(4326008)(8676002)(31686004)(8936002)(6486002)(31696002)(26005)(53546011)(5660300002)(6636002)(66476007)(186003)(38100700002)(508600001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SDhISnNyVWQvK1RQY3BPRm10OUU1aEc0NG5KVmpNTFF2NEt1c2dRaW9tbUoy?= =?utf-8?B?bjBtYXpRT1lWRlZmYnBGVzF2aSsyTkY1NDJwMDRsRlBFMWZZTWFsVDBGTHlx?= =?utf-8?B?SnYrcGhBUWs5VzgxOGdFR2hHT3JLOVVIaHpRK0RnYkFTRFpXSHhIZVRIYzEx?= =?utf-8?B?TGN1cCtqTXVERlNESWo4OTYvT3dEKzR6eUt1OExsOW42UVMyY1FhOHNPWlpO?= =?utf-8?B?SURtYTNjL1lITm5TRVd5dkVvNUc4QmlMN2pnM0JLV2dvb05GZmg1RktJa1Fj?= =?utf-8?B?ZFE4YnV6eTFZdGZEUWdST3lkVzN5azZmSVhCUll1dStkaGl1Q3paOEh1TVV5?= =?utf-8?B?QWlKY2FrdnN0U1pyZjRhVjFyTGxBTm5RN0QwM2Vpa3A4UGM5QzNOK0hQNDNa?= =?utf-8?B?UFA0SXUzemlLVTFzMUNBZ1JrMWw5M3RiQjhaNW44VXBJeE95REhETDY3Sk1q?= =?utf-8?B?K1FEcTFYTzhsakVEeDdjVVJTWEFCSEVFUkNOTTYrZGo3cjZEUGM5d3RYVXhh?= =?utf-8?B?TUtGTVU4L0NvZkRQUmU2TjhqdWpIdWs5OG1QbHZDV2lJTTl4Y2pTbmhxVzBu?= =?utf-8?B?NzZQTDRyQ1RXVmtLc29tZHA4UjhsOEdZYlFrOEFZNDVaUnBEbFlSZ1pJaVNL?= =?utf-8?B?Q2pmRm0zMnhrWXhJZjFwaFUrN09LV25hWkF3QS8rM1F5SC91dndWWFhldFdv?= =?utf-8?B?b2VFdGxjcmdYM2NkbU5WcXRKeHRNNnFZOHE5UkRyUzNzZHVJUTJHZXliYWVr?= =?utf-8?B?elMvbEdTdERFRWI5NEhOSFRmUm9WZmttNUF0V2FvMVgrZlZWd3crMkJkWi9w?= =?utf-8?B?SllWb0NOS0lOK3VWdnlOODB5WEJqUVJxVnAxSEIwamNGYXhTRWdXRFBKMUxm?= =?utf-8?B?NjlNTlNGZFh1RUFIU04xMkRKa2thVFNtaFR0YjdxN2dZYWJJZEs5OFFtN2Q0?= =?utf-8?B?UHdDcjAwTDZJbFR6c1RSUEhxWW9FTEJ3OUJSZFpYNXlRbjFsbUdtTUUwS2E1?= =?utf-8?B?QUdzajE4cGo4b1lMWkp4NUQyN3RUb2NXM25GRWxLUWNPSmdib21jVUFoMlFp?= =?utf-8?B?OUZ2eXdoTzE0dDdoNkRTeGU3NGEyNWxKYlJIa3pueGlDYjVDcERsRUl5TDhz?= =?utf-8?B?R2lpeDNpVHNSMDFYQWJPNTNHTVAvZDY4aVh0ZVBNZDhPQU4wMG43bURUdXo5?= =?utf-8?B?STJqMXZrZkg1RGhJRSs4OXNrV3dHemxSS1NTSml4bHJYR011c0Yxckc2bmZy?= =?utf-8?B?VHZDcVlnMzNwUzgyYWxxNUNUYzRsRGFzdkpJR1czbFp5b283WVZvUDgrVTdN?= =?utf-8?B?RzRsZGpZR2g2S04xRVZnS3g3M21hMXErYUYzUERiU1dhVCtxNytkTFg5aDZH?= =?utf-8?B?NVBwV0pLSmVsZ3pibExUdkJoVkl6Yy9McDdFVlg1ZHRUakMwcmFRLzZtRjlk?= =?utf-8?B?L3RSM1A0dnpCVERFQlY3dW0xTjlvVjl4aWsyeU80TEM1Y0JveXJSVnViaW9N?= =?utf-8?B?a05ZYVFzVUIzanJGNXRmamNUNFBCQThqQllSOTl0THRMdGpYMFAxWFIraUNI?= =?utf-8?B?dURsYmN5a0tsV25JL29sY3BMdFB6eDFVbEVOa082c2pYODlOalU3ZFdCcWdn?= =?utf-8?B?aE12NEViWnNoY3ZCYTNLaHZqUWpaczdlL3FHTmtJbGdkNUVxRVV5OVkyQnAv?= =?utf-8?B?OXBCM21iQzNQK01hUWpVMDR4OHYxMUgrVTNxVzdFMitJTGRsclQ5WEtxRmlP?= =?utf-8?B?cmt6ZlZoTi95SHEvdkxxcmxVbHFTbHl5MHFZbmlMYzRpekpUWWtraitnMnNl?= =?utf-8?B?d0w0U3VEK3JTR3VnaytXUHI5NjhlVHNRN3J3dmtnUmV2cHAyaS9BRHV4VjBZ?= =?utf-8?B?ckprZW5hRUx4L0o2enVsSzF5aDUvZlhBNUdjMjM3clN5TU1jMks0eGZ2K1Nj?= =?utf-8?B?SVJlNXB4Sk9xQkJKUTJUaTJmL2gzNlJwdWhKQ0VGa1NWeklKdWpWK01sb2lN?= =?utf-8?B?MW03RjdCTW9oaUY1T0xhN05XS1M0Yi8zYmJ6cGVYa21iYzZ2dm1ITXFudkpz?= =?utf-8?B?RWt6c1oxQTFwSmQ4YlFPVGJuRWxhWXlhbXd0aklINXpST3h2dHc0WExVbXlW?= =?utf-8?B?SG1Vdm9VYS9PbjdoUlVYWGwwWUVXTmZ6UWN5S2I3YVRqWWRHVjZXdEZFcVpX?= =?utf-8?Q?SQuaeOeh7UYyCDieojBTRyM=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 358a8b6e-e9c6-4e62-9958-08d99e1cffa9 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2021 16:22:43.8240 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: u13yss7w2DN6OQBHC0ZwtBhuYVU9dZ3ntA8HXsh0lzEVx7iDsPV+/zZ2rq4CjlZUoK5raPP3nDwEGESuTycyfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4981 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v9 4/4] net/ice: enable protocol agnostic flow offloading in FDIR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/2/2021 5:39 AM, Junfeng Guo wrote: > @@ -1733,6 +1862,101 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad, > &input_set_i : &input_set_o; > > switch (item_type) { > + case RTE_FLOW_ITEM_TYPE_RAW: > + raw_spec = item->spec; > + raw_mask = item->mask; > + > + if (item_num != 1) > + break; > + > + /* convert raw spec & mask from byte string to int */ > + unsigned char *tmp_spec = > + (uint8_t *)(uintptr_t)raw_spec->pattern; > + unsigned char *tmp_mask = > + (uint8_t *)(uintptr_t)raw_mask->pattern; > + uint16_t udp_port = 0; > + uint16_t tmp_val = 0; > + uint8_t pkt_len = 0; > + uint8_t tmp = 0; > + int i, j; Hi Junfeng, Qi, Jingjing, Beilei, This is causing build error with icc. Mainly the problem is switch case doesn't provide a scope, in C they are just like labels. So these variables are valid for all switch statement and compiler complains that some cases are not initializing these variables. Can you please either: 1- move these variables above switch 2- Create a scope after 'case' with '{}' 2 can be done as: case RTE_FLOW_ITEM_TYPE_RAW: { <...> break; }