From: Thomas Monjalon <thomas@monjalon.net>
To: "Juraj Linkeš" <juraj.linkes@pantheon.tech>,
"Bruce Richardson" <bruce.richardson@intel.com>
Cc: dev@dpdk.org, david.marchand@redhat.com,
Honnappa.Nagarahalli@arm.com, Ruifeng.Wang@arm.com,
ferruh.yigit@intel.com, jerinjacobk@gmail.com
Subject: Re: [dpdk-dev] [PATCH v7] build: use platform for generic and native builds
Date: Fri, 09 Jul 2021 14:30:51 +0200 [thread overview]
Message-ID: <5130808.toJiOpdy7k@thomas> (raw)
In-Reply-To: <YOWzLVr+6tnUSxYU@bricha3-MOBL.ger.corp.intel.com>
07/07/2021 15:59, Bruce Richardson:
> On Tue, Jul 06, 2021 at 11:44:28AM +0200, Juraj Linkeš wrote:
> > The current meson option 'machine' should only specify the ISA, which is
> > not sufficient for Arm, where setting ISA implies other settings as well
> > (and is used in Arm configuration as such).
> > Use the existing 'platform' meson option to differentiate the type of
> > the build (native/generic) and set ISA accordingly, unless the user
> > chooses to override it with a new option, 'cpu_instruction_set'.
> > The 'machine' option set the ISA in x86 builds and set native/default
> > 'build type' in aarch64 builds. These two new variables, 'platform' and
> > 'cpu_instruction_set', now properly set both ISA and build type for all
> > architectures in a uniform manner.
> > The 'machine' option also doesn't describe very well what it sets. The
> > new option, 'cpu_instruction_set', is much more descriptive. Keep
> > 'machine' for backwards compatibility.
> >
> > Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks.
I did few doc formatting improvements and removed some mentions to Arm
as a SoC is not necessarily Arm (Risc-V is coming).
next prev parent reply other threads:[~2021-07-09 12:30 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 15:47 [dpdk-dev] [RFC PATCH v1] build: add platform meson option Juraj Linkeš
2020-11-26 16:02 ` Bruce Richardson
2020-11-27 8:31 ` Juraj Linkeš
2020-11-27 14:07 ` Bruce Richardson
2020-12-23 11:23 ` Juraj Linkeš
2021-01-04 11:52 ` [dpdk-dev] [RFC PATCH v2] " Juraj Linkeš
2021-01-04 11:59 ` Juraj Linkeš
2021-01-05 22:17 ` David Christensen
2021-01-06 14:42 ` Bruce Richardson
2021-02-19 9:11 ` Juraj Linkeš
2021-02-22 21:25 ` David Christensen
2021-02-23 8:45 ` Juraj Linkeš
2021-02-23 9:43 ` Bruce Richardson
2021-02-25 12:51 ` Juraj Linkeš
2021-02-25 12:54 ` Bruce Richardson
2021-02-25 12:57 ` Juraj Linkeš
2021-03-29 11:03 ` [dpdk-dev] [PATCH v3] " Juraj Linkeš
2021-03-29 12:50 ` [dpdk-dev] [PATCH v4] " Juraj Linkeš
2021-03-31 12:16 ` Juraj Linkeš
2021-03-31 12:19 ` Juraj Linkeš
2021-03-31 12:39 ` Bruce Richardson
2021-04-15 13:32 ` Juraj Linkeš
2021-04-15 13:51 ` Bruce Richardson
2021-04-20 8:08 ` [dpdk-dev] [PATCH v5] build: use platform option for generic and native Juraj Linkeš
2021-04-20 8:16 ` Juraj Linkeš
2021-04-20 8:36 ` Thomas Monjalon
2021-04-21 8:37 ` Juraj Linkeš
2021-04-22 8:34 ` Wang, Yinan
2021-06-30 13:09 ` [dpdk-dev] [PATCH v6] build: use platform for generic and native builds Juraj Linkeš
2021-07-06 9:44 ` [dpdk-dev] [PATCH v7] " Juraj Linkeš
2021-07-07 13:59 ` Bruce Richardson
2021-07-09 12:30 ` Thomas Monjalon [this message]
2021-07-09 13:55 ` Juraj Linkeš
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5130808.toJiOpdy7k@thomas \
--to=thomas@monjalon.net \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinjacobk@gmail.com \
--cc=juraj.linkes@pantheon.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).