From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41])
 by dpdk.org (Postfix) with ESMTP id D34FB30D
 for <dev@dpdk.org>; Tue, 27 May 2014 18:36:43 +0200 (CEST)
Received: by mail-wg0-f41.google.com with SMTP id z12so9609397wgg.0
 for <dev@dpdk.org>; Tue, 27 May 2014 09:36:54 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=V0tQOoEE9Us33XYwMRr750wS5X+TeiognOlBhiTGiQo=;
 b=iMxNQo3z0zZWHrdo1OlHzko1yj4cyBCpmlEDhrbTw8Kl3ipnl7NcTtDa7rCMYgXiE+
 db1Qm9ePNFBhFwidtubustiGsl9irvPXqeMIkNdPsdcb62S9hB3XqMIOj3t8Tztdt9Y6
 BxdwuBeJxAFT8nfenDnKJilLSwajhSTpwb9ti8I0FsMVREyE7fb1Lc/AupXt8VlGr9MD
 2iuPPP/zgfHfQHikERejVvJyl7AWizIYliKXWYBg0fYfW6RdStdrzefLOzTQnsLRkLYZ
 HYOmjSYxVRMJWy+ZLPiblaVBdX5SdAmZipvkjNmkuhD5EsiL6Gv8wHje7yxpW+y3cgNU
 3UaA==
X-Gm-Message-State: ALoCoQkhFOJYrgQWensa/SzWhdW6tVyXYzshFkmUvaZPFAnLMKa7SmyQINa1013aB3lo9t3EX/d8
X-Received: by 10.180.75.7 with SMTP id y7mr23405226wiv.4.1401208614725;
 Tue, 27 May 2014 09:36:54 -0700 (PDT)
Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id b19sm9634972wic.5.2014.05.27.09.36.53
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 27 May 2014 09:36:54 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Date: Tue, 27 May 2014 18:36:50 +0200
Message-ID: <5134615.BLJHLAVTpl@xps13>
Organization: 6WIND
User-Agent: KMail/4.13 (Linux/3.14.4-1-ARCH; KDE/4.13.0; x86_64; ; )
In-Reply-To: <C6ECDF3AB251BE4894318F4E451236976CC9351C@IRSMSX101.ger.corp.intel.com>
References: <C6ECDF3AB251BE4894318F4E45123697592AA9BE@IRSMSX101.ger.corp.intel.com>
 <6426409.afQ7rpamsg@xps13>
 <C6ECDF3AB251BE4894318F4E451236976CC9351C@IRSMSX101.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 08/16] Add support for mapping devices
	through VFIO.
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 27 May 2014 16:36:44 -0000

2014-05-27 16:21, Burakov, Anatoly:

> > You are defining some variables in a .h file. I think it is a problem.
> 
> I have managed to move everything to .c files, except for "struct
> mapped_pci_res_list *pci_res_list;" - which I need in both uio and vfio .c
> files. I don't think I'll be able to move it out of the eal_pci_init header
> file. Should declaring it as extern be fine as a compromise?

I think it's acceptable.
Like this one:
	extern struct pci_device_list pci_device_list;

-- 
Thomas