From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 85D9B1B4C9 for ; Fri, 29 Jun 2018 16:28:53 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 161F921BEB; Fri, 29 Jun 2018 10:28:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 29 Jun 2018 10:28:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=H7Q7pXYgtWB3fOWet9iyc7KJV6 AZx4t/fO+aGiWYe+Y=; b=RXV4gce9gBqFWWjbmfA1FZm56pKeg6gBlWOfOEkh4X BNOByHVaTYb38fIPsTL4nt6XoBMaFs5KA8YJ8vOnrOvIa1wwJ2TWF4SbZEI21qnC 7tq7zWN9eRy+7upPXFRMP8nCB/P5YumQCjJlUtmW+sOUKLvvArp6/pWYGZ0M3BJh k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=H7Q7pX YgtWB3fOWet9iyc7KJV6AZx4t/fO+aGiWYe+Y=; b=Sfwv/JL+vRf+YGhdkbXqYG egI6T7Dwb9wrAtQzCRF2jLxKwDDXQybG1aD21iHgUj5HoOy3NhzPLhajsE0HHR9j aRZddyPdCVeQqpwOeo3AfpjvTJIwKthNhhtqhhUyJU/JxKbalIaLXJoA4W/YGan2 xSKlNAjtRefx6Gc1bgrJNrmzB23RRkCUt2j0tuYCz8BDri1ow9uKYEFjVmmLOsu2 7yQR6rfeu4uE6ivYOtbZFJPiM37jHMmePi/FBkm75yTvHD7aAL6x5h4tW9EDA5eU R0Tws2YHEyD8n8F/Atl+FHg28ZCo287mXF8O3dIgkaAw9vRTHWR2MuJSSOPe7XNA == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 75A05E47DC; Fri, 29 Jun 2018 10:28:51 -0400 (EDT) From: Thomas Monjalon To: "Iremonger, Bernard" Cc: Maxime Coquelin , "dev@dpdk.org" , "ailan@redhat.com" , "jan.scheurich@ericsson.com" , "vkaplans@redhat.com" , "Richardson, Bruce" , "Ananyev, Konstantin" , "Yigit, Ferruh" , Jens Freimann Date: Fri, 29 Jun 2018 16:28:49 +0200 Message-ID: <5136032.mYA4okFhoJ@xps> In-Reply-To: <8CEF83825BEC744B83065625E567D7C260CBAC13@IRSMSX108.ger.corp.intel.com> References: <20180623080840.315-1-maxime.coquelin@redhat.com> <195bb20b-441a-571e-8925-6db0a8af56c2@redhat.com> <8CEF83825BEC744B83065625E567D7C260CBAC13@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 1/2] testpmd: add forwarding mode to simulate a noisy neighbour X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jun 2018 14:28:53 -0000 29/06/2018 16:05, Iremonger, Bernard: > Hi Maxime, Thomas, > > > > Subject: Re: [PATCH v4 1/2] testpmd: add forwarding mode to simulate a noisy > > neighbour > > > > Hi Bernard, > > > > On 06/26/2018 01:09 PM, Iremonger, Bernard wrote: > > > checkpatch.pl is showing the following warnings: > > > > > > WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 > > > #122: FILE: app/test-pmd/noisy_vnf.c:1: > > > +/* SPDX-License-Identifier: BSD-3-Clause > > > > I'm not sure to get what is wrong here, any thoughts? > > > > I have looked at code and compared it with other license headers and it looks ok to me. > > Hi Thomas, > > Could you take a look please to see if you can spot something. You should use devtools/checkpatches.sh, it is configured to ignore SPDX warnings among other things.