From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B916A04A5; Tue, 16 Jun 2020 22:35:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 21BD61BFAD; Tue, 16 Jun 2020 22:35:56 +0200 (CEST) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by dpdk.org (Postfix) with ESMTP id BACCE1BFAC for ; Tue, 16 Jun 2020 22:35:54 +0200 (CEST) Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 05GKW4Sk066249; Tue, 16 Jun 2020 16:35:53 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 31q1b1f6w6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 Jun 2020 16:35:53 -0400 Received: from m0098399.ppops.net (m0098399.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 05GKW7Xm066576; Tue, 16 Jun 2020 16:35:53 -0400 Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0a-001b2d01.pphosted.com with ESMTP id 31q1b1f6vx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 Jun 2020 16:35:53 -0400 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 05GKOp5Z005619; Tue, 16 Jun 2020 20:35:52 GMT Received: from b01cxnp22036.gho.pok.ibm.com (b01cxnp22036.gho.pok.ibm.com [9.57.198.26]) by ppma04dal.us.ibm.com with ESMTP id 31mpe9gdka-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 Jun 2020 20:35:52 +0000 Received: from b01ledav001.gho.pok.ibm.com (b01ledav001.gho.pok.ibm.com [9.57.199.106]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 05GKZpnP15270664 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 16 Jun 2020 20:35:51 GMT Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AA12428058; Tue, 16 Jun 2020 20:35:51 +0000 (GMT) Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 30C172805A; Tue, 16 Jun 2020 20:35:51 +0000 (GMT) Received: from Davids-MBP.randomparity.org (unknown [9.211.152.140]) by b01ledav001.gho.pok.ibm.com (Postfix) with ESMTP; Tue, 16 Jun 2020 20:35:51 +0000 (GMT) To: Thomas Monjalon Cc: dev@dpdk.org, david.marchand@redhat.com, bruce.richardson@intel.com References: <20200614225747.3839569-1-thomas@monjalon.net> <20200614225747.3839569-4-thomas@monjalon.net> <9b811c9b-5b56-57a7-c939-6e5dbf888447@linux.vnet.ibm.com> <5942466.NH09dW5kea@thomas> From: David Christensen Message-ID: <513cfa03-f16f-9051-72b3-ea1dc379d902@linux.vnet.ibm.com> Date: Tue, 16 Jun 2020 13:35:50 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <5942466.NH09dW5kea@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216, 18.0.687 definitions=2020-06-16_12:2020-06-16, 2020-06-16 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 spamscore=0 mlxscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0 cotscore=-2147483648 adultscore=0 bulkscore=0 clxscore=1015 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006160140 Subject: Re: [dpdk-dev] [PATCH 3/4] devtools: add ppc64 in meson build test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >>> +# ppc configurations >>> +for f in $srcdir/config/ppc/ppc* ; do >>> + build build-$(basename $f | cut -d'-' -f-2) $f $use_shared >>> +done >>> + >> >> The entire script file is poorly structured for multi-architecture >> builds. The script fails on PPC64LE even before your changes: > > This script supports only builds from x86 Linux so far. > This patch is adding cross-compilation of ppc from x86, > and it works fine. Which distro and packages are used for testing? I tried it with Ubuntu 20.04 but the cross-compiler is named differently (powerpc64le-linux-gnu-gcc instead of powerpc64le-linux-gcc). >> I think the logic of looping through supported configs for test builds >> is the right one, but more changes are required for multi-architecture >> support in this script. For now I'd abandon the PPC/ARM support >> entirely in this script. > > I am adding PPC compilation check to avoid having PPC broken, > because after asking for many years to IBM execs, > there is still no PPC CI integrated in DPDK patchwork. > If you don't think this small step is going in the right direction, > then I will stop bothering about PPC support, > and we should probably completely drop PPC support I guess. Sorry, I didn't understand the context behind the change request nor how the script is used. I appreciate the effort behind the change and would like to help where I can. Dave