From: Thomas Monjalon <thomas@monjalon.net>
To: Pu Xu <583493798@qq.com>
Cc: dev@dpdk.org, "cuanduo@126.com" <cuanduo@126.com>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [PATCH] ip_frag: fix fragmenting ipv4 packet with header option
Date: Wed, 24 Mar 2021 22:30:17 +0100 [thread overview]
Message-ID: <5140426.dOB98B4sCM@thomas> (raw)
In-Reply-To: <27420753.GspcrUYuLZ@thomas>
24/05/2020 17:27, Thomas Monjalon:
> 01/05/2020 22:43, Ananyev, Konstantin:
> >
> > >
> > > When fragmenting ipv4 packet, the data offset should be calculated through
> > > the ihl field in ip header rather than using sizeof(struct rte_ipv4_hdr).
> > >
> > > Fixes: 4c38e5532a07 ("ip_frag: refactor IPv4 fragmentation into a proper library")
> > > Cc: anatoly.burakov@intel.com
> > > Cc: stable@dpdk.org
> > > ---
> >
> > Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
>
> The patch cannot be merged because it is missing a Signed-off-by line.
>
> In general, please follow the contributions guideline here:
> http://core.dpdk.org/contribute/#send
>
> Would be appreciated to number subsequent versions of the patches,
> and use --in-reply-to to keep them threaded.
Are we going to celebrate one year birthday of this patch? :)
How can we proceed?
next prev parent reply other threads:[~2021-03-24 21:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 16:11 Pu Xu
2020-05-01 20:43 ` Ananyev, Konstantin
2020-05-24 15:27 ` Thomas Monjalon
2021-03-24 21:30 ` Thomas Monjalon [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-01 16:16 Pu Xu
2020-05-01 13:50 Pu Xu
2020-05-01 13:27 Pu Xu
2020-05-01 15:32 ` Ananyev, Konstantin
2020-05-01 0:12 Pu Xu
2020-05-01 10:58 ` Ananyev, Konstantin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5140426.dOB98B4sCM@thomas \
--to=thomas@monjalon.net \
--cc=583493798@qq.com \
--cc=anatoly.burakov@intel.com \
--cc=cuanduo@126.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).