From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3347AA0A02; Wed, 24 Mar 2021 22:30:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2094E140D0D; Wed, 24 Mar 2021 22:30:22 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id B0DAC4014F; Wed, 24 Mar 2021 22:30:20 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 604DB5C00ED; Wed, 24 Mar 2021 17:30:20 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 24 Mar 2021 17:30:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= ei4nwQiWtKvSs639r/yhHI/2Zp28JxroA7iTG/Dvyz8=; b=GMhss8mlYFRRnrNs c9RE6BltnDIKsESqOin2vH+1eg88V2oP85ZQ7JJmLCPguiIHoGr8OJP7yxN15PlA dna+y0aTHNj76w5ctXgpn9btDXTp8ff3MY+oCWiBP3T6zt3DMLqVxLYzLHNAbCya ArwexssnQCD+HRnSK3GFLes20ITsY6uzGqSX2IZCZoY7/jZKqg4IXs1DpW9c19K8 jz80E/8BO3qcxVD9WTHfKpQqbixE1pyUM8wuOOji2XwXapOjujImUXp/+TnzoCBV 1+6G83Lwh5uCeqWbTH1ILswrHVvtCMixhPaH0dRV9+tLZP5iQPysbrO3G6CEsrxu 1R+SQg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=ei4nwQiWtKvSs639r/yhHI/2Zp28JxroA7iTG/Dvy z8=; b=lKUxRHJ7Tv4BRUwAjWfQCszbAgInt4is0ulcnfa2LfhtBoNPpodzCkzWK ivsM/kSWCsWoaTI4U/2LRjiLHYPgxFpgpGeBzODZSv+CVb65XplqxIxHSI1E77M/ +GvDFLjYK+3GKMYd8ovCgatFY6STV6fK8khzbgba6ogSCNuy/6iL8G5Ib+rS0I+6 K/azRccBA4a2jyTNCtGG2RFx1zbVoL4oAx45tQpG2LQfgZavGw1nG+Cpl8jOSbge aTYZrLfYklt441vNftjJVkxM2lxE5o5ztivJSC0XJPnVXL3tgsQEnScy1x50T2Ll uhPDFLf4iQtk2VDosG7tRdc5HJRbw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudegkedgudeglecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeffvdffjeeuteelfeeileduudeugfetjeelveefkeejfeeigeeh teffvdekfeegudenucffohhmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefge drvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhl fhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9B547108005C; Wed, 24 Mar 2021 17:30:18 -0400 (EDT) From: Thomas Monjalon To: Pu Xu <583493798@qq.com> Cc: dev@dpdk.org, "cuanduo@126.com" , "Burakov, Anatoly" , "stable@dpdk.org" , "Ananyev, Konstantin" Date: Wed, 24 Mar 2021 22:30:17 +0100 Message-ID: <5140426.dOB98B4sCM@thomas> In-Reply-To: <27420753.GspcrUYuLZ@thomas> References: <20200501161107.33786-1-583493798@qq.com> <27420753.GspcrUYuLZ@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ip_frag: fix fragmenting ipv4 packet with header option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 24/05/2020 17:27, Thomas Monjalon: > 01/05/2020 22:43, Ananyev, Konstantin: > > > > > > > > When fragmenting ipv4 packet, the data offset should be calculated through > > > the ihl field in ip header rather than using sizeof(struct rte_ipv4_hdr). > > > > > > Fixes: 4c38e5532a07 ("ip_frag: refactor IPv4 fragmentation into a proper library") > > > Cc: anatoly.burakov@intel.com > > > Cc: stable@dpdk.org > > > --- > > > > Acked-by: Konstantin Ananyev > > The patch cannot be merged because it is missing a Signed-off-by line. > > In general, please follow the contributions guideline here: > http://core.dpdk.org/contribute/#send > > Would be appreciated to number subsequent versions of the patches, > and use --in-reply-to to keep them threaded. Are we going to celebrate one year birthday of this patch? :) How can we proceed?