From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 2BF89235 for ; Wed, 22 Nov 2017 01:09:11 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2017 16:09:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,432,1505804400"; d="scan'208";a="4999107" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.224.243]) ([10.241.224.243]) by orsmga003.jf.intel.com with ESMTP; 21 Nov 2017 16:09:08 -0800 To: Jingjing Wu , dev@dpdk.org Cc: wenzhuo.lu@intel.com, Olivier MATZ References: <1508488012-82704-1-git-send-email-jingjing.wu@intel.com> <1508488012-82704-9-git-send-email-jingjing.wu@intel.com> From: Ferruh Yigit Message-ID: <5141b2ac-be19-8b69-ff66-2bdcc0770685@intel.com> Date: Tue, 21 Nov 2017 16:09:08 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1508488012-82704-9-git-send-email-jingjing.wu@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [RFC 8/9] net/avf: enable ops to check queue info and status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Nov 2017 00:09:12 -0000 On 10/20/2017 1:26 AM, Jingjing Wu wrote: > - rxq_info_get > - txq_info_get > - rx_queue_count > - rx_descriptor_done > - rx_descriptor_status > - tx_descriptor_status + some documentation. <...> > @@ -28,8 +28,8 @@ > (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > -I40E/IXGBE/IGB Virtual Function Driver AVF doesn't cover ixgbe/igb virtual functions right? Perhaps it can be good to keep information for them. <...> > @@ -132,7 +132,15 @@ static const struct eth_dev_ops avf_eth_dev_ops = { > .reta_query = avf_dev_rss_reta_query, > .rss_hash_update = avf_dev_rss_hash_update, > .rss_hash_conf_get = avf_dev_rss_hash_conf_get, > + .rxq_info_get = avf_dev_rxq_info_get, > + .txq_info_get = avf_dev_txq_info_get, > + .rx_queue_count = avf_dev_rxq_count, > + .rx_descriptor_done = avf_dev_rx_desc_done, If you implemented "rx_descriptor_status" no need to implement "rx_descriptor_done", one covers other. cc'ed Olivier if I am missing anything. <...>