From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 0DB78A2EEB
	for <public@inbox.dpdk.org>; Fri, 13 Sep 2019 22:34:00 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 8F9221F037;
	Fri, 13 Sep 2019 22:33:59 +0200 (CEST)
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
 [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id CD5821EFFA
 for <dev@dpdk.org>; Fri, 13 Sep 2019 22:33:57 +0200 (CEST)
X-Virus-Scanned: Proofpoint Essentials engine
Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1-us4.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 2AA5DB40066;
 Fri, 13 Sep 2019 20:33:49 +0000 (UTC)
Received: from [192.168.1.192] (188.242.181.57) by ukex01.SolarFlarecom.com
 (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 13 Sep
 2019 21:33:26 +0100
To: Ferruh Yigit <ferruh.yigit@intel.com>, "John W. Linville"
 <linville@tuxdriver.com>, Xiaolong Ye <xiaolong.ye@intel.com>, Qi Zhang
 <qi.z.zhang@intel.com>, Igor Russkikh <igor.russkikh@aquantia.com>, "Pavel
 Belous" <pavel.belous@aquantia.com>, Allain Legacy
 <allain.legacy@windriver.com>, Matt Peters <matt.peters@windriver.com>, "Ravi
 Kumar" <ravi1.kumar@amd.com>, Rasesh Mody <rmody@marvell.com>, Shahed Shaikh
 <shshaikh@marvell.com>, Ajit Khaparde <ajit.khaparde@broadcom.com>, "Somnath
 Kotur" <somnath.kotur@broadcom.com>, Chas Williams <chas3@att.com>, "Rahul
 Lakkireddy" <rahul.lakkireddy@chelsio.com>, Hemant Agrawal
 <hemant.agrawal@nxp.com>, Sachin Saxena <sachin.saxena@nxp.com>, Wenzhuo Lu
 <wenzhuo.lu@intel.com>, Gagandeep Singh <g.singh@nxp.com>, John Daley
 <johndale@cisco.com>, Hyong Youb Kim <hyonkim@cisco.com>, Gaetan Rivet
 <gaetan.rivet@6wind.com>, Xiao Wang <xiao.w.wang@intel.com>, Ziyang Xuan
 <xuanziyang2@huawei.com>, Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,
 Guoyang Zhou <zhouguoyang@huawei.com>, Beilei Xing <beilei.xing@intel.com>,
 Jingjing Wu <jingjing.wu@intel.com>, Qiming Yang <qiming.yang@intel.com>,
 Rosen Xu <rosen.xu@intel.com>, Konstantin Ananyev
 <konstantin.ananyev@intel.com>, Shijith Thotton <sthotton@marvell.com>,
 Srisivasubramanian Srinivasan <srinivasan@marvell.com>, Matan Azrad
 <matan@mellanox.com>, Shahaf Shuler <shahafs@mellanox.com>, Yongseok Koh
 <yskoh@mellanox.com>, Viacheslav Ovsiienko <viacheslavo@mellanox.com>, "Zyta
 Szpak" <zr@semihalf.com>, Liron Himi <lironh@marvell.com>, Tomasz Duszynski
 <tdu@semihalf.com>, Stephen Hemminger <sthemmin@microsoft.com>, "K. Y.
 Srinivasan" <kys@microsoft.com>, Haiyang Zhang <haiyangz@microsoft.com>,
 Rastislav Cernay <cernay@netcope.com>, Jan Remes <remes@netcope.com>,
 Alejandro Lucero <alejandro.lucero@netronome.com>, Jerin Jacob
 <jerinj@marvell.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>, "Kiran
 Kumar K" <kirankumark@marvell.com>, Keith Wiles <keith.wiles@intel.com>,
 Maciej Czekaj <mczekaj@marvell.com>, Maxime Coquelin
 <maxime.coquelin@redhat.com>, Tiwei Bie <tiwei.bie@intel.com>, Zhihong Wang
 <zhihong.wang@intel.com>, Yong Wang <yongwang@vmware.com>, Thomas Monjalon
 <thomas@monjalon.net>
CC: <dev@dpdk.org>
References: <1567699852-31693-1-git-send-email-arybchenko@solarflare.com>
 <1568030331-16526-1-git-send-email-arybchenko@solarflare.com>
 <1568030331-16526-5-git-send-email-arybchenko@solarflare.com>
 <dc3ffba0-f56c-f852-ccce-07c83dc591b6@intel.com>
From: Andrew Rybchenko <arybchenko@solarflare.com>
Message-ID: <514fc9ad-031c-a920-714f-68cc33c2ad79@solarflare.com>
Date: Fri, 13 Sep 2019 23:33:21 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <dc3ffba0-f56c-f852-ccce-07c83dc591b6@intel.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-Originating-IP: [188.242.181.57]
X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To
 ukex01.SolarFlarecom.com (10.17.10.4)
X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24908.002
X-TM-AS-Result: No-7.237300-8.000000-10
X-TMASE-MatchedRID: VPleTT1nwdTA46G+uSzVzSLVdThWsHxY69aS+7/zbj+qvcIF1TcLYM7/
 vP2uWVRBK/S70kzmfv7rL7s+y7z25R1YpEPWJiyz8VqfAfqY2izUk/02d006RVIxScKXZnK0D5/
 /liPzh0ngYsxc0Oenakj4YJn2mzfPtz7yklcnbSP1WO1NzV/CYFeOOwzb8N/G0Tg95eC4HOU7Oq
 bDvYYMaOLzNWBegCW2RYvisGWbbS+3sNbcHjySQd0H8LFZNFG76sBnwpOylLPkVmnBp+9AX7UK6
 of+mqLvRgswYGN/4OxDdr8ifnH/o+4N/v5QJI5j9WFeq0W4WP82kbezWE6ltfZtqtRuD6yHjYYa
 fbRkqL+igEHy7J4S6ylkreA5r24aYnCi5itk3iprD5+Qup1qU37cGd19dSFd
X-TM-AS-User-Approved-Sender: Yes
X-TM-AS-User-Blocked-Sender: No
X-TMASE-Result: 10--7.237300-8.000000
X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24908.002
X-MDID: 1568406836-RVNELF88XZT5
Subject: Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous
 callbacks to return status
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/13/19 7:43 PM, Ferruh Yigit wrote:
> On 9/9/2019 12:58 PM, Andrew Rybchenko wrote:
>> Enabling/disabling of promiscuous mode is not always successful and
>> it should be taken into account to be able to handle it properly.
>>
>> When correct return status is unclear from driver code, -EAGAIN is used.
>>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> <...>
>
>> @@ -376,8 +384,11 @@ mlx4_rxmode_toggle(struct rte_eth_dev *dev, enum rxmode_toggle toggle)
>>    *
>>    * @param dev
>>    *   Pointer to Ethernet device structure.
>> + *
>> + * @return
>> + *   0 on success, a negative errno value otherwise and rte_errno is set.
>>    */
>> -void
>> +int
>>   mlx4_promiscuous_enable(struct rte_eth_dev *dev)
>>   {
>>   	mlx4_rxmode_toggle(dev, RXMODE_TOGGLE_PROMISC_ON);
>> @@ -388,8 +399,11 @@ mlx4_promiscuous_enable(struct rte_eth_dev *dev)
>>    *
>>    * @param dev
>>    *   Pointer to Ethernet device structure.
>> + *
>> + * @return
>> + *   0 on success, a negative errno value otherwise and rte_errno is set.
>>    */
>> -void
>> +int
>>   mlx4_promiscuous_disable(struct rte_eth_dev *dev)
>>   {
>>   	mlx4_rxmode_toggle(dev, RXMODE_TOGGLE_PROMISC_OFF);
> error: control reaches end of non-void function [-Werror=return-type]

Thanks, will fix in the next version and install libverbs-dev to
be able to test build.