From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C457A0577; Mon, 6 Apr 2020 15:14:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0A9532B96; Mon, 6 Apr 2020 15:14:13 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id DC5162B86 for ; Mon, 6 Apr 2020 15:14:11 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 3253A5800E6; Mon, 6 Apr 2020 09:14:11 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Mon, 06 Apr 2020 09:14:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=GvBfm+t9xIlMu3J/22vpl5JxSo87UevH+z0RzjBZLw8=; b=hlp58muNtSTV /V+3RAK0p7z/zAm+UjbhAhttMuuf/1mV0t8lxHxWU6wd5BAJHgCMNPAOSXO8HiVW UMVR0OOAI17V2v+J04lsK70CV9cc6mBCTKOBh4+ddI1ZDSUI77xx0iYn5iiy46rN LAi2IAMHrqTLH4t+RsmLQGrRP6zaElI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=GvBfm+t9xIlMu3J/22vpl5JxSo87UevH+z0RzjBZL w8=; b=NXLa6uZGlW8S8CIil9EXIMKKuk/7+/jheBzwUusEf4OUcD/Ppzjibx4Df hUvedW7cOaeIH7pkHOpwyo5Ze22kd0YauTtPAOr7mIssIBCSr0bFqV+aVIaBLTu3 TF8RZNgsOYYG9nXRoQ8AvBQBOGBmNE5UQITpMxoBW9EAVD1AeLOgXyg3VLJVwTP1 Jv689oIjfD5yMZCPIbnxwAI/4d01rCT5AibSNGv52+RSQCFtHBL6bJEh77eZYTmU Y+YOSsNveQVtMsjtlNEghTsTCGdCwFul/bETUD4TAon9iAkB/j7WwKqS3qH7qHhD Fg+mZsPRocqbYt+LkftGxF6QZwQUw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudefgdehiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepmhgrihhlqdgrrhgthhhivhgvrdgtohhmnecukfhppeejjedrudefgedrvddt fedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C5A4D306D3F9; Mon, 6 Apr 2020 09:14:01 -0400 (EDT) From: Thomas Monjalon To: Pavan Nikhilesh Bhagavatula Cc: Ori Kam , Jerin Jacob Kollanukkaran , "xiang.w.wang@intel.com" , "dev@dpdk.org" , Shahaf Shuler , "hemant.agrawal@nxp.com" , Opher Reviv , Alex Rosenbaum , Dovrat Zifroni , Prasun Kapoor , "nipun.gupta@nxp.com" , "bruce.richardson@intel.com" , "yang.a.hong@intel.com" , "harry.chang@intel.com" , "gu.jian1@zte.com.cn" , "shanjiangh@chinatelecom.cn" , "zhangy.yun@chinatelecom.cn" , "lixingfu@huachentel.com" , "wushuai@inspur.com" , "yuyingxia@yxlink.com" , "fanchenggang@sunyainfo.com" , "davidfgao@tencent.com" , "liuzhong1@chinaunicom.cn" , "zhaoyong11@huawei.com" , "oc@yunify.com" , "jim@netgate.com" , "hongjun.ni@intel.com" , "j.bromhead@titan-ic.com" , "deri@ntop.org" , "fc@napatech.com" , "arthur.su@lionic.com" , "david.marchand@redhat.com" Date: Mon, 06 Apr 2020 15:14:00 +0200 Message-ID: <5151953.QU4070AmJz@xps> In-Reply-To: References: <1585464438-111285-1-git-send-email-orika@mellanox.com> <2875521.ySyUEvhnHf@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [EXT] [PATCH v1 4/4] regexdev: implement regex rte level functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/04/2020 14:33, Pavan Nikhilesh Bhagavatula: > >> From: Pavan Nikhilesh Bhagavatula > >> > >+uint16_t > >> > >+rte_regexdev_enqueue_burst(uint8_t dev_id, uint16_t qp_id, > >> > >+ struct rte_regex_ops **ops, uint16_t nb_ops) > >> > >+{ > >> > >+ return regex_devices[dev_id]- > >> > >>enqueue(regex_devices[dev_id], qp_id, > >> > >+ ops, nb_ops); > >> > >+} > >> > > >> > Move these functions to .h in-lining them. > >> > Also, please add debug checks @see > >rte_eth_rx_burst/rte_eth_tx_burst. > >> > >> O.K will update. > > > >In general, inlining is a pain for ABI compatibility. > >Please inline only if the gain is very significant. > > > > The performance gain mostly comes from hoisting `regex_devices[dev_id]` load above the > poll loop. > Since, the performance measurement application is still in pipeline and regexdev would be > experimental for next couple of releases I suggest inlining it now and worrying about ABI when > experimental tag needs to be removed. No, we must worry about ABI from the beginning. > We can follow the same path as done by ethdev [https://www.mail-archive.com/dev@dpdk.org/msg142392.html] ethdev is not an argument.