From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF16EA034F; Mon, 29 Mar 2021 23:59:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3A9FD406B4; Mon, 29 Mar 2021 23:59:52 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 22AE84069D for ; Mon, 29 Mar 2021 23:59:51 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 5CC615C016D; Mon, 29 Mar 2021 17:59:49 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 29 Mar 2021 17:59:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= s0Bqq2iD8OSl3DejQ4f5uL2gR+P5kudKcj1O56htOf4=; b=Fipnda/XCjEqyj0j Ding+nUzZVfJFI0tpvhSU4REa96GiUU8vXtCNNl6jM/GeHJEqBF2vAAN4CHkPx61 F2QKxfGffFccIj/8Xnip43uaNmlAFjX79zjCZGKiO8gEc6ykkZZ5RMZfQJc919RA fC5S5DmJwiV8ewSC4pbOUOmZ/o+GiKzPX5MUaW3Nlk4ekMNAjIYPZObigAsBMvO+ BdFQ6rPZLvHc/Uge7Q//I6s2XOY6LK9Q3eS3tvXdjEhSeul12dz2cIw/EuGbQeoh gSaYjjSP/twb0izCoEjdvrhHyCUPAHTCIM2GPx1qof4haEJrubMen4vH1XRrLmAJ 5HNx8Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=s0Bqq2iD8OSl3DejQ4f5uL2gR+P5kudKcj1O56htO f4=; b=au5Bzr5DASKlb2iRIx4JKylQqOeoVkRYU8OTsg5nnxglk+sqpaY8+3e+4 mLYlMMCfTdPNcA+WSr4CN5mVAqfaF8O0ZESnKDB7dTYx7SvVrQzJSrHNW99OolYp 9ZYvCo489RYxZlo3r7TLxVQQFI83YtUrMu6QIyIz6JjcthNEfhOKKuhyg06kC6++ ELeeyxHM08N1XxKrtCNV9o6M77r09Qptl1CZ5JKHC5J0nv1crX9xch9J+LCSIvXI MV0oS0EX5r2QiLCP+xyj2AzLrvfV+bXtq57ho2OIkPvqNcs5obOrc/EgzCRHH4cI 8G1j3wyrKr5+XY1rtKjwk23oypIkQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudehledgtdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 040041080063; Mon, 29 Mar 2021 17:59:47 -0400 (EDT) From: Thomas Monjalon To: Maxime Coquelin Cc: dev@dpdk.org, chenbo.xia@intel.com, patrick.fu@intel.com, amorenoz@redhat.com, shahafs@mellanox.com, viacheslavo@nvidia.com, matan@nvidia.com Date: Mon, 29 Mar 2021 23:59:45 +0200 Message-ID: <5162509.OuVXpe82kn@thomas> In-Reply-To: <20200925123113.68916-2-maxime.coquelin@redhat.com> References: <20200925123113.68916-1-maxime.coquelin@redhat.com> <20200925123113.68916-2-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/8] bus/vdev: add DMA mapping ops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/09/2020 14:31, Maxime Coquelin: > Add DMA map/unmap operation callbacks to the vdev bus, which > could be used by DMA capable vdev drivers. [...] > @@ -551,6 +601,8 @@ static struct rte_bus rte_vdev_bus = { > .plug = vdev_plug, > .unplug = vdev_unplug, > .parse = vdev_parse, > + .dma_map = vdev_dma_map, > + .dma_unmap = vdev_dma_unmap, > .dev_iterate = rte_vdev_dev_iterate, > }; The functions map/unmap look to be the same as in PCI bus driver. I wonder whether it would make sense to move these operations at rte_driver level? It seems we don't need anything specific to PCI or vdev, but just being able to get some class driver private data, right?