DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, david.hunt@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mempool: fix stack handler dequeue
Date: Sun, 29 Jan 2017 23:37:28 +0100	[thread overview]
Message-ID: <5164572.zkQ5vD8MeL@xps13> (raw)
In-Reply-To: <1485191463-22992-1-git-send-email-olivier.matz@6wind.com>

2017-01-23 18:11, Olivier Matz:
> The return value of the stack handler is wrong: it should be 0 on
> success, not the number of objects dequeued.
> 
> This could lead to memory leaks depending on how the caller checks the
> return value (ret < 0 or ret != 0). This was also breaking autotests
> with debug enabled, because the debug cookies are only updated when the
> function returns 0, so the cookies were not updated, leading to
> an abort().
> 
> Fixes: 295a530b0844 ("mempool: add stack mempool handler")
> 
> CC: stable@dpdk.org
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>

Applied, thanks

      reply	other threads:[~2017-01-29 22:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-23 17:11 Olivier Matz
2017-01-29 22:37 ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5164572.zkQ5vD8MeL@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=david.hunt@dpdk.org \
    --cc=dev@dpdk.org \
    --cc=olivier.matz@6wind.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).