From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58C14A0487 for ; Sun, 28 Jul 2019 21:55:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B63481BEEF; Sun, 28 Jul 2019 21:55:48 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 636061BEEB for ; Sun, 28 Jul 2019 21:55:47 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 84F4922050; Sun, 28 Jul 2019 15:55:46 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 28 Jul 2019 15:55:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=UgLQxw8aRmEUWjFy3vJqGAVZ2ZKWyPpCuVxnUGNoodc=; b=Gvlq9T1fomPq j96u2UBdQWvK6g2UYA3YMvD5sh1pC+/lAm5Hh3H21yYyFAjRQMDT8jxt02ECHEfB euCGVsHiRdyzRzpWueT+y2+KZRBOGZhbLZyLdJn/cAUstGHEhJLOsbrWABwGo/FC CV4oN0dfL4gf+WdU/KvYKYbg+kY6R10= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=UgLQxw8aRmEUWjFy3vJqGAVZ2ZKWyPpCuVxnUGNoo dc=; b=KJ2ZdIk4hEcD21IpwWnfpRaWJzuGgYzfFvwH4ARpPG9OKAPnodNNGUO/Q OZV7I2eNBDP68yTb8SssMg+i7wpGuadFu15Yo7RrMBCIghhw3HeVWQIXMQnpSX9w SPnLZms4Il7PhRyYEKgmv6vaBNsPett6QfS9gi66jIrOIY6TENFgYO6tCC+Ss1if Iqlwsy3ElepfTQumkHPZNkNNjTKOoQ94L2WoNFL3T5fcMRfjYtXAP9MVwFVS4TTN SBYN7ewR2e5pBZg4Xci++AkcfIALzRsi2g9vc3+ibjtixmUZ0I2QQGd/3iZXvlpq MqsDpUUgzItCHaXkHeIHzZ+2om4xw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrkeelgddugeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 55C1A80059; Sun, 28 Jul 2019 15:55:44 -0400 (EDT) From: Thomas Monjalon To: "Morrissey, Sean" , "Laatz, Kevin" Cc: David Marchand , "dev@dpdk.org" , Gaetan Rivet Date: Sun, 28 Jul 2019 21:55:43 +0200 Message-ID: <5173895.pTg1DfyaZ9@xps> In-Reply-To: References: <20190724152059.17859-1-sean.morrissey@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] Revert "eal: fix parsing option --telemetry" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/07/2019 10:42, David Marchand: > > > > 24/07/2019 17:20, Sean Morrissey: > > > > > This reverts commit debacba0297fbe214b4185a9791e6a9fdf6642ba. > > > > > > > > > > Reverting this patch as it currently breaks the initialization of > > > > > telemetry, more investigation is ongoing to fix the issue for the > > > > > printed error message for unrecognized argument. > > > > > > > > > > Signed-off-by: Sean Morrissey > > > > > > > > It's very disapointing. > > > > Did you or the reviewer tested the previous patch? > > > > > > > > The reporter of the bug tested this and verified functionality and > > > > closed the internal bug.> > > > > > > > > So the reverted commit is supposed to work? > > > I won't apply this revert until I fully understand what happens. > > > > The patch that I sent up was to remove an "unrecognized > > option telemetry" warning message, which the patch > > removed and was tested to ensure the message was removed. > > Further testing, after the patch was sent up, So the patch was sent and reviewed without testing the functionality. > > revealed that the unix domain socket, > > which is required by telemetry consumers, > > was no longer being created, > > rendering the telemetry functionality non-functional. Why this socket is not created? How is it related to the option parsing? > > On further investigation, the full fix involves > > a change in the EAL command line parameter handling, > > which is probably too risky for RC3. No way you change the command line parsing, except the rte_option which was created for telemetry. The history of this "simple" feature is already full of hesitations which made me hesitate to merge. Please, don't force me to dig in the code, otherwise I will be tempted to do a big "clean-up". > > This revert will allow telemetry to function again, > > but with the erroneous message still in place. > > We will aim to fix in the next release. > > Might be good to look and revisit the rte_option api.