From: Thomas Monjalon <thomas@monjalon.net>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "Guo, Jia" <jia.guo@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
dev@dpdk.org, "Guo, Junfeng" <junfeng.guo@intel.com>,
"Su, Simei" <simei.su@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1] net/iavf: fix hash default set
Date: Wed, 05 Aug 2020 19:40:44 +0200 [thread overview]
Message-ID: <5178903.5kADOQs6Yg@thomas> (raw)
In-Reply-To: <039ED4275CED7440929022BC67E7061154873F82@SHSMSX103.ccr.corp.intel.com>
04/08/2020 06:36, Zhang, Qi Z:
> From: Guo, Jia <jia.guo@intel.com>
> >
> > Different device has different hash capability, it should not be expected that all
> > hash set would be successful to set into all devices by default. So remove the
> > return checking when hash default set. And remove gtpu hash default set, iavf
> > only enable hash for general protocols.
> >
> > Fixes: c94366cfc641 ("net/iavf: add GTPU in default hash")
> > Signed-off-by: Jeff Guo <jia.guo@intel.com>
>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
>
> Applied to dpdk-next-net-intel.
It looks it should be 2 separate patches:
- revert/remove GTPU from default RSS hash
- ignore error in adding protocols to RSS
Please be more careful in patch reviews.
PS: fixing name in Tested-by: Wei Xie <weix.xie@intel.com>
next prev parent reply other threads:[~2020-08-05 17:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 2:58 Jeff Guo
2020-08-04 4:36 ` Zhang, Qi Z
2020-08-05 17:40 ` Thomas Monjalon [this message]
2020-08-04 7:03 ` Xie, WeiX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5178903.5kADOQs6Yg@thomas \
--to=thomas@monjalon.net \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jia.guo@intel.com \
--cc=jingjing.wu@intel.com \
--cc=junfeng.guo@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=simei.su@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).