From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Qiming Chen <chenqiming_huawei@163.com>, <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/pcap: improve rxtx statistics
Date: Wed, 8 Sep 2021 13:29:37 +0100 [thread overview]
Message-ID: <517ca3cd-7303-5254-8853-0425e4572a1b@intel.com> (raw)
In-Reply-To: <20210826032354.1146-1-chenqiming_huawei@163.com>
On 8/26/2021 4:23 AM, Qiming Chen wrote:
> In the receiving direction, if alloc mbuf or jumbo process failed, there
> is no err_pkts count, which makes it difficult to locate the problem.
ack, but patch adds two places that updates the 'err_pkts'. One of them is where
mbuf allocation failed, and for this case there is a specific stats field,
'rx_nombuf'. Can you please update the patch to use this field?
> In the sending direction, if the pcap_sendpacket function returns
> EMSGSIZE, it means that the size of the sent packet exceeds the buffer
> size provided, and the corresponding mbuf needs to be released, otherwise
> it will cause the mbuf to leak.
>
PMD Tx shouldn't free mbufs that are not sent, it is application's
responsibility to free (or resend, or whatever application wants).
Please drop this part of the patch.
> Signed-off-by: Qiming Chen <chenqiming_huawei@163.com>
<...>
next prev parent reply other threads:[~2021-09-08 12:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 3:16 [dpdk-dev] [PATCH] " Qiming Chen
2021-08-26 3:23 ` [dpdk-dev] [PATCH v2] " Qiming Chen
2021-09-08 12:29 ` Ferruh Yigit [this message]
2021-09-09 2:45 ` [dpdk-dev] [PATCH v3] net/pcap: improve rx statistics Qiming Chen
2021-09-09 3:29 ` Stephen Hemminger
2021-09-09 10:20 ` Ferruh Yigit
2021-09-09 4:16 ` [dpdk-dev] [PATCH v4] " Qiming Chen
2021-09-09 8:05 ` Ferruh Yigit
2021-09-09 8:23 ` [dpdk-dev] [PATCH v5] " Qiming Chen
2021-09-09 10:20 ` Ferruh Yigit
2021-09-09 12:28 ` [dpdk-dev] [PATCH v6] " Qiming Chen
2021-09-09 14:45 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517ca3cd-7303-5254-8853-0425e4572a1b@intel.com \
--to=ferruh.yigit@intel.com \
--cc=chenqiming_huawei@163.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).