From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 665C0A0547; Wed, 8 Sep 2021 14:29:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 406A141140; Wed, 8 Sep 2021 14:29:47 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id D617840E25 for ; Wed, 8 Sep 2021 14:29:44 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10100"; a="281484737" X-IronPort-AV: E=Sophos;i="5.85,277,1624345200"; d="scan'208";a="281484737" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2021 05:29:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,277,1624345200"; d="scan'208";a="479147402" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga008.jf.intel.com with ESMTP; 08 Sep 2021 05:29:43 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 8 Sep 2021 05:29:43 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 8 Sep 2021 05:29:43 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 8 Sep 2021 05:29:43 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 8 Sep 2021 05:29:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EWppzRiES3GUDK2FaoISa0SuakoYOcp0KDGDiN05Nw/1NPAdRv2qkaJBcjCQecJ7M4RzbqDG5jtiK7IC6TvsFjgQEUZquRqFYY2LC9eqhZGsqLQWbex1jt/g/G+d/AIpYEiS13Fdy5qLyPAnUXJP5zHbgqkJVH/uJ5Ylh3Qr6qfh9jamxZszGiiu4/de1X2+QkKeLEJYwyWuZ/NwkXU7MSn4rYBZbNPTpCpRjVZiGE8vJrxs3Mv9fISea5X+5Dlagus4Azg/q49WgnfAWtWkTfIju5OfMLkWliJVfcb3K0QhbNIuXf5Hz5Nzpc8FSuottbdtO5bDDeaxfVMFFq/eAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=gLPHh7SEhWME6PuympiYDqPIFX1IqxGk4r+2ZyUbYGs=; b=fP/dQn+pylmIOqNAA5eWz0bIyVxOGJkT8sG60jgA3CHU7XNAgyGjUpZ407zr4zI/3v6W6XLr9OFsTZzHDePHsOCmOM2Bi6sEPM0uhin1U5wC5cl9087N1xS16DIc5suiFgQ4xjYCU8es5oz+PWPf1Ag5+KBcbSaGphZIgZ3/P8LHlM7PDZZpLWHKaD4eA1d6Tnvy1dTqCZYzsLBhtpcU/6Ve9b353WfGT9r/1DLB7x5z4vYsEArr5d5UsHzeziaI8LnpqikCATqRSGTIV0LxI66hrDiVZ81cBSoNpE449rriksYMtgVsy+/MhoHJ6sIqty7n52BivK45lR4COb2G+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gLPHh7SEhWME6PuympiYDqPIFX1IqxGk4r+2ZyUbYGs=; b=m7jQ0/8LvMkcD2WBnmgPNDL7z+UZXXqojxD6q17KpnrIEB2KvBapoLN+w2engs4xIbE6bE1gOCT9UO1EG/F09qW9JvdQUuilYVemB+Nq4NWRopiWofAybsVLe42IwBm0ATtOFuATvxIGtbgb4ZVX+mJXUCTvGIju7sBFyaulnQY= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5174.namprd11.prod.outlook.com (2603:10b6:510:3b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Wed, 8 Sep 2021 12:29:42 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4478.025; Wed, 8 Sep 2021 12:29:42 +0000 To: Qiming Chen , References: <20210826031604.1089-1-chenqiming_huawei@163.com> <20210826032354.1146-1-chenqiming_huawei@163.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <517ca3cd-7303-5254-8853-0425e4572a1b@intel.com> Date: Wed, 8 Sep 2021 13:29:37 +0100 In-Reply-To: <20210826032354.1146-1-chenqiming_huawei@163.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU2PR04CA0268.eurprd04.prod.outlook.com (2603:10a6:10:28e::33) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0268.eurprd04.prod.outlook.com (2603:10a6:10:28e::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Wed, 8 Sep 2021 12:29:41 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6a454af8-afd3-444c-612c-08d972c45577 X-MS-TrafficTypeDiagnostic: PH0PR11MB5174: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X/7VfOQnMrDPL20Y03dK2eEOiix8+frhuVTXc/0TL53dF703goyGIjASV4FB9nMX5x8IQi68ijsU1PhlBS1z55ujzsRUyyuzySfznsFXZQ2THYMKqmnLDp1Yz/lSF0xflSIh12TqmS9zJAyBRqzfI6bKX4FlsYO0p+bVd1D0IoeiaAljqhD3QCPMs8KQwF0CRxxT/iijuk+/SagFTypPyRcCUHDxxvn5Xcl7r4pQQO14ivvALKsR0Vwa5bHu6HhTjyPoDGL7bYqrQuzqX9IgEzD6zWFnbRgKZkf+f1u3B2brknYmPIUoPbxq2iMpgB5K2MDFeK4Vx2vWVHGZLH6Hn35XoLaibh8H3qFDd2U1qo4saeqps64mNiGDeFDU8xhgdIYnPyF11L5QfxgN8alcb+tKBWE9GZ8iKDDhzdNKeoVfH5H2aLN53l00KnyDnrwUg94gJoTDnaAfROA7lxumkztgi04NIYvX74tXQ6ZWZPStdcUupXXZUFEvoWKT2GNAAp23csIa9vOZAWX+wmDcedBKmZCGdndXmpzSv3ZB01hvhJvhGvRmHMJNqGY4z4Bq9lMeDVGHdAJ4wc5UAXaZjcWa7IjECfckiASMIFJeue3oqFxWN/lHgN6mEkv1OSkVkZRx+J0IISorff2wY7+HNLvWOjd/wSi12OZBplbzgxjzD1dcD7jgz00pL4QGxeL3vKh6OFzQm4zS6o9eRDk3Aw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(83380400001)(2616005)(26005)(31696002)(38100700002)(16576012)(66476007)(6666004)(186003)(8676002)(66946007)(8936002)(316002)(956004)(6486002)(53546011)(5660300002)(4744005)(86362001)(31686004)(36756003)(508600001)(44832011)(66556008)(2906002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K3lrT09wL2NPbThweDZxSTR5NWhtRVRkVTIvTGdRaFMrTUtmRTd5QitUcDVS?= =?utf-8?B?eU01NEl5NjVFaE1ZMlNISTJ1V3MzTkpldDdhdW5JcVdUTzFoajZ3MEVNZGo0?= =?utf-8?B?TXRLUVRpbFkzRFVKNEEybFQ0OForNnpDdzVjNlpZKzlERm9SYjE1T29xSlgz?= =?utf-8?B?ditNUGRVQVVORDhhNmlCaWZEbzk0YmxWZnkrb2QrUVVXclh2OGZwSFQ0Rjlu?= =?utf-8?B?NEoyMmlGUjlyZjc0OHBXWmFBRllPcFZsQSs0RUVaSUI2U1RzL1M0ZnIyMzAr?= =?utf-8?B?eklENDVsSjNSc0lJTmZyLzdNSGFrUkwvWThXS0JIczRmR0xRN0lyQ1VEQWhW?= =?utf-8?B?d205OHBkb2NJTnREZmY2TGxiZTU4Y2xDZkJhUGg5c3M5d2NhUk9lQy9heGFl?= =?utf-8?B?UmZsU1JidTlGN2tnNSt6eGNka1ZRY00rS2paNjRrVk9CazZCVm1ScXRVVWpE?= =?utf-8?B?N2UwUGlJbzF0THBKSmZZVTQvTG5IWVFKZDdLUUFISDd3bmdaSTk3OS8wekNE?= =?utf-8?B?YVRNaUNobllSaVhuVXo2RE5YN3hGNDRmTDJaYXZCRTdYSGUyMVoyZTFMZ21F?= =?utf-8?B?TEdhZWlJR3FpZGVESkVIWHVkRzBxRndPS3dmc3lKWFNVdU00VGc4bUhrYTVF?= =?utf-8?B?cU5GWGZERmx3eW40Q3Q3eXRwOHYrNXArdDZWQUg3WFpESW1LVzBXZEN3SzlS?= =?utf-8?B?ckpQZGVNK3VyRGlyMTZxb1d5R2JoMERRcmJkVzAvZENnTXlRMVZFVjQrZ3Ez?= =?utf-8?B?c1lCMmczOU5ubVpKeWZLWXI4RTdhaG9tUTFvaGVoaDRENDkwcXIxamU0SU95?= =?utf-8?B?V0VxYTV0Ykh2MWNXRXdidTJlU0E5ZGVpOVBkbUozN01XVlcrU1hCRmxqcWxK?= =?utf-8?B?enVkUGo2NlpoVXFGTzFldGlOaGhqMUFQVEpoWFFHWEV0dHRaaVk0OFJ6NC9p?= =?utf-8?B?REhGS2EvSHFaMjJSbC80L2FncForWWdtM1NlODlPMUdTQlFoRkx3cVJhblk5?= =?utf-8?B?V21rcjkvOXJ0N3lTL1lEeDFaM3E5YWdJL2FmRWZId3U1ODlTRXRMTTIrQits?= =?utf-8?B?M3UvY3c2Q1d5N1J4NlFaa1FjcEt0TzM0WkVFQ0dobmJ0VnJnLzcrWXM2WXRK?= =?utf-8?B?bVdOOWhPc0hBS010QVVDS2M2bUZYOUpWMTVWeUhQd0ZIODQyRFFVTVRTakV4?= =?utf-8?B?ZmUyNGRQUXhxRitWRTY0aGtINWdKOVBTNWRSWXNweG13RGRRRmh4UUlDck5y?= =?utf-8?B?aFRoL3JEbm5xTGhzWmEydnU4cjQya1cwSzBBZlpVMExkVk5FdUY0LzdWNWF4?= =?utf-8?B?Q1hkcmx1SzgrRzhLcGl3aXFSOThWSmYxT2dPMG5yOVdUM3pWYmdORmorQ0R5?= =?utf-8?B?MFlJVXArU3NQVzZhV09aQ0p4NjE4OWg3VWk0KzExT3VQTmNhOXY3L0JVWGFB?= =?utf-8?B?ZGY3bnZBY08vYUsyU202U2F4d29kQUcwa0RJaGZmbDdabzJOZW1EZW1VdDFV?= =?utf-8?B?VTdabGRQZ0N6V205YjE5dlZVbUI3QmxWZlZPbGVRWUxLS0tSTzhaVXR4VEJZ?= =?utf-8?B?dkkwd1U4elhvbUFWdklVaDIyUnU2RWFKSnBCYXFCNlAydmpqKy95cVBCZjA2?= =?utf-8?B?NmU1SjFJNTVDS0Jaamp1OWpsdGtaWFIrdW4rMGF3aEcyVHRMeDlZWWRaZTBE?= =?utf-8?B?eHRiR2FNSm03OFpCNTBzMEFwN092Ujk3bG4waXBrcWxYKzBjWXZCN1Zvc1Vr?= =?utf-8?Q?DQlgaKFLjsURLgg1Zkjr3mhKygTWfu6BeqIqxqT?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6a454af8-afd3-444c-612c-08d972c45577 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 12:29:42.3674 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Lv+9vYPuyFaGAM/R1j7JCjnbrRpW+Nmuys7K0GWuS6p1iYsPV62jqvUFlSGmoxH7z2fbhFQGdpJrqjeGtm0W7Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5174 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] net/pcap: improve rxtx statistics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/26/2021 4:23 AM, Qiming Chen wrote: > In the receiving direction, if alloc mbuf or jumbo process failed, there > is no err_pkts count, which makes it difficult to locate the problem. ack, but patch adds two places that updates the 'err_pkts'. One of them is where mbuf allocation failed, and for this case there is a specific stats field, 'rx_nombuf'. Can you please update the patch to use this field? > In the sending direction, if the pcap_sendpacket function returns > EMSGSIZE, it means that the size of the sent packet exceeds the buffer > size provided, and the corresponding mbuf needs to be released, otherwise > it will cause the mbuf to leak. > PMD Tx shouldn't free mbufs that are not sent, it is application's responsibility to free (or resend, or whatever application wants). Please drop this part of the patch. > Signed-off-by: Qiming Chen <...>