From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id A16321B83E; Tue, 24 Oct 2017 23:32:42 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2017 14:32:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,429,1503385200"; d="scan'208";a="166618468" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.60]) ([10.241.225.60]) by fmsmga005.fm.intel.com with ESMTP; 24 Oct 2017 14:32:40 -0700 To: Thomas Monjalon Cc: dev@dpdk.org, Jianfeng Tan , Jingjing Wu , Shijith Thotton , Gregory Etelson , Harish Patil , George Prekas , stable@dpdk.org, Sergio Gonzalez Monroy References: <20171017201436.65270-1-ferruh.yigit@intel.com> From: Ferruh Yigit Message-ID: <5180dd9f-9df9-edd5-3feb-c53a51733391@intel.com> Date: Tue, 24 Oct 2017 14:32:40 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171017201436.65270-1-ferruh.yigit@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] igb_uio: revert open and release operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2017 21:32:43 -0000 On 10/17/2017 1:14 PM, Ferruh Yigit wrote: > This reverts commit 6b9ed026a8704b9e5ee5da7997617ef7cc82e114. > This reverts commit 5f6ff30dc5075c49069d684bab229aef7ff0fdc3. > This reverts commit b58eedfc7dd57eef6d12e2c654a52c834f36084a. > > There were bug reports about terminated application may leave device in > undesired state: > http://dpdk.org/ml/archives/dev/2016-November/049745.html > http://dpdk.org/ml/archives/dev/2016-November/050932.html > > And a proposal to fix: > http://dpdk.org/ml/archives/dev/2016-December/051844.html > > Later another proposal triggered the discussion: > http://dpdk.org/ml/archives/dev/2017-May/066317.html > > Finally a fix patch pushed into v17.08: > Commit: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device file") > > Later a regression report sent related to the pushed patch: > http://dpdk.org/ml/archives/dev/2017-September/075236.html > > And a fix for regression integrated into v17.11-rc1: > http://dpdk.org/ml/archives/dev/2017-October/079166.html > Commit: 5f6ff30dc507 ("igb_uio: fix interrupt enablement after FLR in VM") > Commit: 6b9ed026a870 ("igb_uio: fix build with kernel <= 3.17") > > Even after the fix qede PMD reported to be broken: > http://dpdk.org/ml/archives/dev/2017-October/079359.html > > So this patch reverts original fix and related commits. The related > igb_uio code part turns back to v17.05 base. > > Cc: Jianfeng Tan > Cc: Jingjing Wu > Cc: Shijith Thotton > Cc: Gregory Etelson > Cc: Harish Patil > Cc: George Prekas > > Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device file") > Cc: stable@dpdk.org > > Signed-off-by: Ferruh Yigit > --- > It would be nice to solve this issue in LTS release, but being close to > the release and the error report without details makes it hard to work > more on this issue. > > Thanks everyone who spent effort for this, hopefully we can continue to > work on next release cycle. > > Jingjing, there is a i40e commit, was part of igb_uio fix patchset, is > it generic, or needs to be reverted with this patch? > Commit: 8cacf78469a7 ("net/i40e: fix VF initialization error") This patch is no more valid and will be marked as rejected, since instead of revert, agreed on a solution [1]. [1] http://dpdk.org/ml/archives/dev/2017-October/thread.html#79815 http://dpdk.org/dev/patchwork/patch/30654/