DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Patrick Fu <patrick.fu@intel.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, maxime.coquelin@redhat.com,
	bruce.richardson@intel.com, mm6021@att.com,
	zhihong.wang@intel.com, liang-min.wang@intel.com,
	konstantin.ananyev@intel.com, timothy.miskell@intel.com,
	cunming.liang@intel.com, Jiawei Wang <jiaweiw@nvidia.com>,
	Ori Kam <orika@nvidia.com>,
	jerinj@marvell.com, cristian.dumitrescu@intel.com,
	arybchenko@solarflare.com
Subject: Re: [dpdk-dev] [PATCH v1 0/3] lib: introduce traffic mirroring lib
Date: Tue, 22 Sep 2020 09:40:58 +0200	[thread overview]
Message-ID: <5182103.61m7zJCJ6h@thomas> (raw)
In-Reply-To: <20200909002247.864844-1-patrick.fu@intel.com>

Patrick Fu <patrick.fu@intel.com> wrote:
> Network Test Access Point (TAP) is the network monitoring service
> commonly adotpted in SDN-based network infrastructures. When VMs are
> inter-connected over virtual switches, TAP requires vSwitch to mirror
> out network traffics from specific workload VM ports to the TAP
> device/VM ports. Classical mirroring impmentations in vSwitch make an
> extra copy of the source packets, which results in significant degradation
> in the throughput levels vSwitch could normally archieve. Therefore, we
> propose a new set of APIs to support high-throughput packet mirroring
> through hardware offloading.

In the RFC thread, you mentioned you were targetting vhost
where there is no hardware offload.
If it targets hardware offload, it should be in rte_flow.
Even if no device offload, we could implement it in rte_flow.

If you think it does not fit with rte_flow because it is
forwarding traffic between devices, then I think rte_graph
or rte_pipeline may fit.

In general I am against adding a library restricted to some specific
forwarding use cases.



      parent reply	other threads:[~2020-09-22  7:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-09  0:22 Patrick Fu
2020-09-09  0:22 ` [dpdk-dev] [PATCH v1 1/3] lib/mirror: introduce traffic mirror API Patrick Fu
2020-09-09  1:09   ` Wang, Haiyue
2020-09-09  6:02     ` Fu, Patrick
2020-09-21 15:26   ` MEHAN, MUNISH
2020-09-09  0:22 ` [dpdk-dev] [PATCH v1 2/3] lib/mirror: add port based mirroring Patrick Fu
2020-09-09  0:22 ` [dpdk-dev] [PATCH v1 3/3] lib/mirror: add flow " Patrick Fu
2020-09-22  7:40 ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5182103.61m7zJCJ6h@thomas \
    --to=thomas@monjalon.net \
    --cc=arybchenko@solarflare.com \
    --cc=bruce.richardson@intel.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=cunming.liang@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jerinj@marvell.com \
    --cc=jiaweiw@nvidia.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=liang-min.wang@intel.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=mm6021@att.com \
    --cc=orika@nvidia.com \
    --cc=patrick.fu@intel.com \
    --cc=timothy.miskell@intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).