From: Dharmik Thakkar <Dharmik.Thakkar@arm.com>
To: Phil Yang <Phil.Yang@arm.com>
Cc: "erik.g.carrillo@intel.com" <erik.g.carrillo@intel.com>,
dpdk-dev <dev@dpdk.org>,
"jerinj@marvell.com" <jerinj@marvell.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
"drc@linux.vnet.ibm.com" <drc@linux.vnet.ibm.com>,
Ruifeng Wang <Ruifeng.Wang@arm.com>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v2 3/4] eventdev: remove redundant code
Date: Fri, 3 Jul 2020 03:35:59 +0000 [thread overview]
Message-ID: <51A6AAE6-954A-429A-B809-F3D5212CCDAB@arm.com> (raw)
In-Reply-To: <1593667604-12029-3-git-send-email-phil.yang@arm.com>
Hi Phil,
Looks good.
> On Jul 2, 2020, at 12:26 AM, Phil Yang <Phil.Yang@arm.com> wrote:
>
> There is no thread will access these impl_opaque data after timer
> canceled. When new timer armed, it got refilled. So the cleanup
> process is unnecessary.
>
> Signed-off-by: Phil Yang <phil.yang@arm.com>
> ---
> lib/librte_eventdev/rte_event_timer_adapter.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/lib/librte_eventdev/rte_event_timer_adapter.c b/lib/librte_eventdev/rte_event_timer_adapter.c
> index 7cc334c..8909a8c 100644
> --- a/lib/librte_eventdev/rte_event_timer_adapter.c
> +++ b/lib/librte_eventdev/rte_event_timer_adapter.c
> @@ -1167,8 +1167,6 @@ swtim_cancel_burst(const struct rte_event_timer_adapter *adapter,
> rte_mempool_put(sw->tim_pool, (void **)timp);
>
> evtims[i]->state = RTE_EVENT_TIMER_CANCELED;
> - evtims[i]->impl_opaque[0] = 0;
> - evtims[i]->impl_opaque[1] = 0;
>
> rte_smp_wmb();
> }
> —
> 2.7.4
>
Reviewed-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
next prev parent reply other threads:[~2020-07-03 3:36 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 11:19 [dpdk-dev] [PATCH 1/3] eventdev: fix race condition on timer list counter Phil Yang
2020-06-12 11:19 ` [dpdk-dev] [PATCH 2/3] eventdev: use c11 atomics for lcore timer armed flag Phil Yang
2020-06-23 21:01 ` Carrillo, Erik G
2020-06-28 16:12 ` Phil Yang
2020-06-23 21:20 ` Stephen Hemminger
2020-06-23 21:31 ` Carrillo, Erik G
2020-06-28 16:32 ` Phil Yang
2020-06-12 11:19 ` [dpdk-dev] [PATCH 3/3] eventdev: relax smp barriers with c11 atomics Phil Yang
2020-06-22 10:12 ` Phil Yang
2020-06-23 19:38 ` Carrillo, Erik G
2020-06-28 17:33 ` Phil Yang
2020-06-29 18:07 ` Carrillo, Erik G
2020-06-18 15:17 ` [dpdk-dev] [PATCH 1/3] eventdev: fix race condition on timer list counter Carrillo, Erik G
2020-06-18 18:25 ` Honnappa Nagarahalli
2020-06-22 9:48 ` Phil Yang
2020-07-01 11:22 ` Jerin Jacob
2020-07-02 3:28 ` Phil Yang
2020-07-02 3:26 ` Phil Yang
2020-07-02 3:56 ` Honnappa Nagarahalli
2020-07-02 21:15 ` Carrillo, Erik G
2020-07-02 21:30 ` Honnappa Nagarahalli
2020-06-22 9:09 ` Phil Yang
2020-07-02 5:26 ` [dpdk-dev] [PATCH v2 1/4] " Phil Yang
2020-07-02 5:26 ` [dpdk-dev] [PATCH v2 2/4] eventdev: use c11 atomics for lcore timer armed flag Phil Yang
2020-07-02 20:21 ` Carrillo, Erik G
2020-07-02 5:26 ` [dpdk-dev] [PATCH v2 3/4] eventdev: remove redundant code Phil Yang
2020-07-03 3:35 ` Dharmik Thakkar [this message]
2020-07-02 5:26 ` [dpdk-dev] [PATCH v2 4/4] eventdev: relax smp barriers with c11 atomics Phil Yang
2020-07-02 20:30 ` Carrillo, Erik G
2020-07-03 10:50 ` Jerin Jacob
2020-07-06 10:04 ` Thomas Monjalon
2020-07-06 15:32 ` Phil Yang
2020-07-06 15:40 ` Thomas Monjalon
2020-07-07 11:13 ` [dpdk-dev] [PATCH v3 1/4] eventdev: fix race condition on timer list counter Phil Yang
2020-07-07 11:13 ` [dpdk-dev] [PATCH v3 2/4] eventdev: use C11 atomics for lcore timer armed flag Phil Yang
2020-07-07 11:13 ` [dpdk-dev] [PATCH v3 3/4] eventdev: remove redundant code Phil Yang
2020-07-07 11:13 ` [dpdk-dev] [PATCH v3 4/4] eventdev: relax smp barriers with C11 atomics Phil Yang
2020-07-07 14:29 ` Jerin Jacob
2020-07-07 15:56 ` Phil Yang
2020-07-07 15:54 ` [dpdk-dev] [PATCH v4 1/4] eventdev: fix race condition on timer list counter Phil Yang
2020-07-07 15:54 ` [dpdk-dev] [PATCH v4 2/4] eventdev: use C11 atomics for lcore timer armed flag Phil Yang
2020-07-07 15:54 ` [dpdk-dev] [PATCH v4 3/4] eventdev: remove redundant code Phil Yang
2020-07-07 15:54 ` [dpdk-dev] [PATCH v4 4/4] eventdev: relax smp barriers with C11 atomics Phil Yang
2020-07-08 13:30 ` [dpdk-dev] [PATCH v4 1/4] eventdev: fix race condition on timer list counter Jerin Jacob
2020-07-08 15:01 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A6AAE6-954A-429A-B809-F3D5212CCDAB@arm.com \
--to=dharmik.thakkar@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Phil.Yang@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=erik.g.carrillo@intel.com \
--cc=jerinj@marvell.com \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).