From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-x22e.google.com (mail-wg0-x22e.google.com [IPv6:2a00:1450:400c:c00::22e]) by dpdk.org (Postfix) with ESMTP id 0B0D9234 for ; Tue, 4 Jun 2013 11:17:58 +0200 (CEST) Received: by mail-wg0-f46.google.com with SMTP id l18so4112821wgh.25 for ; Tue, 04 Jun 2013 02:18:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:x-gm-message-state; bh=35c3G5EV0THi5kdFa935jNCyAdn0sQ8BDk3djNdKdv8=; b=coimVQn0GQhvNlVWq7EkeooUuZmn4fQBYa7BOeWh62N4PqvSXkAknhqWNLEPzXzFs3 od7rI2IItfVBn/Ssit8sKzjg2+cSiJacUEn+Pwb18dUxmlHPEz8tHkuSAFnnxHZ1wavq GB8u68r1EmKwMvKRVOMGIrEApwMwKMrlC3eX/IZYIa32ITTR9Mv90pDBEAPbqDNcUnu8 XdkJ7jq4s5sU0t1fT8LMV4UFliO4DKxNTGUmPOCQrdfZoeJMrwEttEdMTWJoLdLm3kYq e3gWi6zVcebv/dL3O5gFjbb06n0uVZmi9eySrcN2LXvy8/nBYM8Oz8tuyi4w8hTYB+ok K3VQ== X-Received: by 10.180.109.195 with SMTP id hu3mr490032wib.13.1370337486227; Tue, 04 Jun 2013 02:18:06 -0700 (PDT) Received: from [10.16.0.97] (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id en3sm1388832wid.1.2013.06.04.02.18.04 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 04 Jun 2013 02:18:05 -0700 (PDT) Message-ID: <51ADB0A1.7000705@6wind.com> Date: Tue, 04 Jun 2013 11:17:21 +0200 From: Damien Millescamps User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.2.15) Gecko/20110303 Lightning/1.0b2 Thunderbird/3.1.9 MIME-Version: 1.0 To: dev@dpdk.org References: <20130530171234.301927271@vyatta.com> <51AC5A99.1050207@6wind.com> <20130603084154.70219c8f@nehalam.linuxnetplumber.net> <201306031836.52362.thomas.monjalon@6wind.com> <20130603102629.713d917c@nehalam.linuxnetplumber.net> In-Reply-To: <20130603102629.713d917c@nehalam.linuxnetplumber.net> Content-Type: multipart/alternative; boundary="------------070602010307030507000402" X-Gm-Message-State: ALoCoQnstZILD4rLYmmsCZL9T6q1ErrR+4YwoTj9mTnzlqoi7D5qnSJmg0jTpPXG7fCQS156gTCN Subject: Re: [dpdk-dev] [PATCH 4/7] eal: support different modules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jun 2013 09:17:59 -0000 This is a multi-part message in MIME format. --------------070602010307030507000402 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit On 06/03/2013 07:26 PM, Stephen Hemminger wrote: > There is nothing that says a PMD could load a second module, but why not put > that special case code in the the driver. Or make it a list of strings. There is nothing that says anything about PMD and loading a single module. However, the Getting Started Guide refers to "dymanic kernel tweaks" citing "modules", all in a plural form: /"Running an Intel®DPDK application requires some kernel configuration customization (done at build time) and some dynamic kernel tweaks (modules, procfs)./" A list of strings can be implemented using a "null terminated array", as suggested in my review. So yes, it could be a good solution. -- Damien Millescamps --------------070602010307030507000402 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit
On 06/03/2013 07:26 PM, Stephen Hemminger wrote:
There is nothing that says a PMD could load a second module, but why not put
that special case code in the the driver. Or make it a list of strings.
There is nothing that says anything about PMD and loading a single module. However, the Getting Started Guide refers to "dymanic kernel tweaks" citing "modules", all in a plural form:
"Running an Intel®DPDK application requires some kernel configuration customization (done at build time) and some dynamic kernel tweaks (modules, procfs)."

A list of strings can be implemented using a "null terminated array", as suggested in my review. So yes, it could be a good solution.

--
Damien Millescamps
--------------070602010307030507000402--