From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vincent.jardin@6wind.com>
Received: from mail-ea0-x231.google.com (mail-ea0-x231.google.com
 [IPv6:2a00:1450:4013:c01::231])
 by dpdk.org (Postfix) with ESMTP id AB19E691A
 for <dev@dpdk.org>; Wed,  5 Jun 2013 16:34:25 +0200 (CEST)
Received: by mail-ea0-f177.google.com with SMTP id j14so1223916eak.36
 for <dev@dpdk.org>; Wed, 05 Jun 2013 07:34:33 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=google.com; s=20120113;
 h=message-id:date:from:organization:user-agent:mime-version:to
 :subject:references:in-reply-to:content-type
 :content-transfer-encoding:x-gm-message-state;
 bh=XVBKD61P5TLB1OvgTUBEo7JNTxovZM5rrcEJKiR+NAs=;
 b=FrVSiNW2vSgchLjezBqEMB4h/SU5O61sfXyu/PlFJDmALw+0TKOB4s/oZnDjfgmdkW
 zzNewKSmIFsPWVFUU+sF3FUgH0Rx0FpwqQ+11MCJcI3rXA0XuLUC8/g/WlhpZoKHnoAu
 ZBPHMh2i53VyAByMWu9WFXyTvhlh1qcmqGO6FwDxHtL75D5+Nf2KWM/wUW0S2HiysJDL
 zStsrc4PBwQ5uZ+2pAZ5YovfEOZ14xkLGJH9t4+xXrlb2VuIpXrKIhAyrJ4I8Q8ucyG2
 fxItgAZbZZuJ1KSbOXxdghZSt7OcibRl3LqkIiZInC+4RYlHevN3OIuOxZO1Lcv+hnD3
 yMOw==
X-Received: by 10.14.178.6 with SMTP id e6mr4787749eem.64.1370442873234;
 Wed, 05 Jun 2013 07:34:33 -0700 (PDT)
Received: from saturne.dev.6wind.com (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id
 b14sm27376381ees.16.2013.06.05.07.34.31 for <dev@dpdk.org>
 (version=TLSv1 cipher=RC4-SHA bits=128/128);
 Wed, 05 Jun 2013 07:34:32 -0700 (PDT)
Message-ID: <51AF4C82.2010603@6wind.com>
Date: Wed, 05 Jun 2013 16:34:42 +0200
From: Vincent JARDIN <vincent.jardin@6wind.com>
Organization: www.6wind.com
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:17.0) Gecko/20130311 Thunderbird/17.0.4
MIME-Version: 1.0
To: dev@dpdk.org
References: <20130530171234.301927271@vyatta.com>
 <20130530171626.884622340@vyatta.com>
In-Reply-To: <20130530171626.884622340@vyatta.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Gm-Message-State: ALoCoQndxEH3y0o2aKaV2nKQu5t7uzP1eBB1k5pMrRayLHxB5BCIHJyYtNv8WEWduDotNlzxTANt
Subject: Re: [dpdk-dev] [PATCH 3/7] optimize log/panic
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Jun 2013 14:34:26 -0000

On 30/05/2013 19:12, Stephen Hemminger wrote:
> Both logging and calls to panic are never in the critical path.
> Use the GCC attribute cold to mark these functions as cold,
> which generates more optimised code.
>
> Signed-off-by: Stephen Hemminger<shemminger@vyatta.com>
Reviewed-by: Vincent Jardin <vincent.jardin@6wind.com>

It does not hurt to move both to a cold section. TODO: some other init 
and setup functions should be cold too.