From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <damien.millescamps@6wind.com>
Received: from mail-ea0-x236.google.com (mail-ea0-x236.google.com
 [IPv6:2a00:1450:4013:c01::236])
 by dpdk.org (Postfix) with ESMTP id E5C44532D
 for <dev@dpdk.org>; Wed,  5 Jun 2013 16:50:54 +0200 (CEST)
Received: by mail-ea0-f182.google.com with SMTP id r16so1250506ead.27
 for <dev@dpdk.org>; Wed, 05 Jun 2013 07:50:57 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=google.com; s=20120113;
 h=message-id:date:from:user-agent:mime-version:to:subject:references
 :in-reply-to:content-type:content-transfer-encoding
 :x-gm-message-state;
 bh=PhEpIuk6kdqJZmSZ3McOIzpWyWWPdiWYFePbk0kK25A=;
 b=XRD1iGycVxXm0olUTVOk7Mma9YXsFCSy2HxmvbGuIUZxIZ0Iidb9GaVRQ5kw1QOBwW
 pBqM3uzUnnQkzS2ebILuDaIgAg4GhMWTZTkOLGXjCe1Zx3Pd70cc6afsFiZ4LLuJmmzq
 Us2dESKMo83cGIdLOF8cnGKQRl746novSb2W7Z+UCUqUwGdjFFZR5MFc0/xhfz2WSpsR
 G869SFoAke7VSIciMNdHEWRhYS5aHmj6RL51vLug2/5lvCN1ZQCJlpJmGo6zp8iPor+k
 bsq4qY5mVfN58VOlrDv72P0aRHdDX+LTu5B1ehboLydcXELDEt8m7wM67MHNWiMKwbBw
 1DpQ==
X-Received: by 10.15.44.10 with SMTP id y10mr29995635eev.5.1370443857434;
 Wed, 05 Jun 2013 07:50:57 -0700 (PDT)
Received: from [10.16.0.97] (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id s43sm98118670eem.13.2013.06.05.07.50.55
 for <dev@dpdk.org>
 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Wed, 05 Jun 2013 07:50:56 -0700 (PDT)
Message-ID: <51AF501B.5060306@6wind.com>
Date: Wed, 05 Jun 2013 16:50:03 +0200
From: Damien Millescamps <damien.millescamps@6wind.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US;
 rv:1.9.2.15) Gecko/20110303 Lightning/1.0b2 Thunderbird/3.1.9
MIME-Version: 1.0
To: dev@dpdk.org
References: <20130530171234.301927271@vyatta.com>
 <20130530171627.005239011@vyatta.com>
In-Reply-To: <20130530171627.005239011@vyatta.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Gm-Message-State: ALoCoQmjXmVrtwn8C6siM80ALjr9wWNeKmyL2mJa/pXP8mK+a1HFYwAnDcLGbvpwo1G77acK8Ua/
Subject: Re: [dpdk-dev] [PATCH 5/7] pci: support multiple PCI regions per
 device
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Jun 2013 14:50:55 -0000

Hi Stephen,

Overall this patch is very nice. My only comment on this one is why do
you limit the max number of memory resources to 5 ?
The PCI configuration space permits to store up to 6 base addresses.

> +#define PCI_MEM_RESOURCE 5

Please, can you add a log/comment with your patch, too ?


Cheers,
-- 
Damien Millescamps