From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 5F8CC6D45 for ; Mon, 5 Mar 2018 15:59:35 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Mar 2018 06:59:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,427,1515484800"; d="scan'208";a="180010035" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.62]) ([10.237.221.62]) by orsmga004.jf.intel.com with ESMTP; 05 Mar 2018 06:59:33 -0800 To: Andrew Rybchenko , dev@dpdk.org Cc: Ivan Malov References: <1516899647-8541-1-git-send-email-arybchenko@solarflare.com> <1516899647-8541-3-git-send-email-arybchenko@solarflare.com> From: Ferruh Yigit Message-ID: <51bd745e-5fdd-90fe-b8c0-32f903cecf2d@intel.com> Date: Mon, 5 Mar 2018 14:59:32 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1516899647-8541-3-git-send-email-arybchenko@solarflare.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/6] net/sfc: add support for driver-wide dynamic logging X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Mar 2018 14:59:35 -0000 On 1/25/2018 5:00 PM, Andrew Rybchenko wrote: > From: Ivan Malov > > Signed-off-by: Ivan Malov > Signed-off-by: Andrew Rybchenko > Reviewed-by: Andy Moreton <...> > @@ -2082,3 +2084,14 @@ RTE_PMD_REGISTER_PARAM_STRING(net_sfc_efx, > SFC_KVARG_STATS_UPDATE_PERIOD_MS "= " > SFC_KVARG_MCDI_LOGGING "=" SFC_KVARG_VALUES_BOOL " " > SFC_KVARG_DEBUG_INIT "=" SFC_KVARG_VALUES_BOOL); > + > +RTE_INIT(sfc_driver_register_logtype); > +static void > +sfc_driver_register_logtype(void) > +{ > + int ret; > + > + ret = rte_log_register_type_and_pick_level(SFC_LOGTYPE_PREFIX "driver", > + RTE_LOG_NOTICE); No benefit of using rte_log_register_type_and_pick_level() here, in this stage "opt_loglevel_list" will be empty and this will be same as rte_log_register()