From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 6DC152BB4 for ; Mon, 3 Jul 2017 11:04:36 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jul 2017 02:04:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,302,1496127600"; d="scan'208";a="103932087" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91]) ([10.237.220.91]) by orsmga004.jf.intel.com with ESMTP; 03 Jul 2017 02:04:34 -0700 From: Ferruh Yigit To: Bernard Iremonger , Shrikrishna Khare Cc: Thomas Monjalon , dev@dpdk.org References: <1497280691-18641-1-git-send-email-bernard.iremonger@intel.com> <1497529790-31587-2-git-send-email-bernard.iremonger@intel.com> <2139772.cOZ1VZa0cE@xps> <5c648ffc-7b7b-672c-21c0-e209f2589497@intel.com> Message-ID: <51c5491c-7d40-fe32-d06e-02085f9fbf57@intel.com> Date: Mon, 3 Jul 2017 10:04:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <5c648ffc-7b7b-672c-21c0-e209f2589497@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] ethdev: modify callback process API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jul 2017 09:04:37 -0000 On 7/3/2017 10:01 AM, Ferruh Yigit wrote: > On 7/1/2017 4:19 PM, Thomas Monjalon wrote: >> 15/06/2017 14:29, Bernard Iremonger: >>> From: "Bernard.Iremonger" >>> >>> Change the rte_eth_dev_callback_process function to return int, >>> and add a void *ret_param parameter. >> >> Adding this explanation: >> The new parameter is used by ixgbe and i40e instead of abusing >> the user data of the callback. >> and this title: >> ethdev: add return values to callback process API >> >> And applied, thanks >> > > Hi Bernard, Shrikrishna, > > This patch breaks vmxnet3 build, can you please send a patch to fix it? The build error is on next-net. Main repo looks good. > > Thanks, > ferruh >