From: Luca Vizzarro <Luca.Vizzarro@arm.com>
To: Dean Marx <dmarx@iol.unh.edu>,
probb@iol.unh.edu, npratte@iol.unh.edu, yoan.picchi@foss.arm.com,
Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com
Cc: dev@dpdk.org
Subject: Re: [PATCH v1] dts: fix checksum suite docstring/variable format
Date: Wed, 22 Jan 2025 15:16:05 +0000 [thread overview]
Message-ID: <5203d31b-d600-494b-bb1a-459e7413ba6f@arm.com> (raw)
In-Reply-To: <20250116184322.2750-1-dmarx@iol.unh.edu>
Looks good, thanks. Just one nit.
Reviewed-by: Luca Vizzarro <luca.vizzarro@arm.com>
On 16/01/2025 18:43, Dean Marx wrote:
> @@ -57,7 +57,7 @@ def send_packets_and_verify(
> packet_list: List of Scapy packets to send and verify.
> load: Raw layer load attribute in the sent packet.
> should_receive: Indicates whether the packet should be received
> - by the traffic generator.
> + by the traffic generator.
> """
I am assuming this was unintentional? As it's meant to be the way it was
before. Keep the indentation as it's not a new argument, but part of the
previous one.
prev parent reply other threads:[~2025-01-22 15:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 18:43 Dean Marx
2025-01-22 12:40 ` Paul Szczepanek
2025-01-22 15:16 ` Luca Vizzarro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5203d31b-d600-494b-bb1a-459e7413ba6f@arm.com \
--to=luca.vizzarro@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=dmarx@iol.unh.edu \
--cc=npratte@iol.unh.edu \
--cc=paul.szczepanek@arm.com \
--cc=probb@iol.unh.edu \
--cc=yoan.picchi@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).