From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C3CA9460ED;
	Wed, 22 Jan 2025 16:16:10 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 764A3402D5;
	Wed, 22 Jan 2025 16:16:10 +0100 (CET)
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mails.dpdk.org (Postfix) with ESMTP id 00144402BC
 for <dev@dpdk.org>; Wed, 22 Jan 2025 16:16:08 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CFF3C1007;
 Wed, 22 Jan 2025 07:16:36 -0800 (PST)
Received: from [10.1.32.19] (JR4XG4HTQC.cambridge.arm.com [10.1.32.19])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 471273F66E;
 Wed, 22 Jan 2025 07:16:07 -0800 (PST)
Message-ID: <5203d31b-d600-494b-bb1a-459e7413ba6f@arm.com>
Date: Wed, 22 Jan 2025 15:16:05 +0000
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1] dts: fix checksum suite docstring/variable format
Content-Language: en-GB
To: Dean Marx <dmarx@iol.unh.edu>, probb@iol.unh.edu, npratte@iol.unh.edu,
 yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com,
 paul.szczepanek@arm.com
Cc: dev@dpdk.org
References: <20250116184322.2750-1-dmarx@iol.unh.edu>
From: Luca Vizzarro <Luca.Vizzarro@arm.com>
In-Reply-To: <20250116184322.2750-1-dmarx@iol.unh.edu>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Looks good, thanks. Just one nit.

Reviewed-by: Luca Vizzarro <luca.vizzarro@arm.com>

On 16/01/2025 18:43, Dean Marx wrote:
> @@ -57,7 +57,7 @@ def send_packets_and_verify(
>               packet_list: List of Scapy packets to send and verify.
>               load: Raw layer load attribute in the sent packet.
>               should_receive: Indicates whether the packet should be received
> -                by the traffic generator.
> +            by the traffic generator.
>           """
I am assuming this was unintentional? As it's meant to be the way it was 
before. Keep the indentation as it's not a new argument, but part of the 
previous one.