From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31C09A0471 for ; Tue, 16 Jul 2019 17:07:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E583F2BF5; Tue, 16 Jul 2019 17:06:59 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id AE2DB2BD5; Tue, 16 Jul 2019 17:06:57 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 31E6D21FE7; Tue, 16 Jul 2019 11:06:57 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 16 Jul 2019 11:06:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=sjO7r+fMjeRXjlEO/+noWXcU9ZqZvf8udmfJ4jYKOho=; b=kPfM+FgJZSL+ V6m4TeLJAd2zm0c9iJiuYlX2jec7dOvYt5WX3xbfqQwynNucc5h/G2Jb7oQeWf20 yFUD2TDc9KzHTJ2dJjFW9BpXBS28zEUJqVy/h0mBp0jxQmeTf6yhko7z3JhvlQu3 OgJTj+F9BGtX+sBQY7qqoc33E78tZ2Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=sjO7r+fMjeRXjlEO/+noWXcU9ZqZvf8udmfJ4jYKO ho=; b=n2YYXYJCxwhesx9LqrypXDOACAvJ8mpN9QWvf2JlV2MWtdWdfu87mq2fc sVde76uxyMiXAbtts9kSH5cDRgzKHDtxVoTJmcKa+HIVeaXECNYXmrABf+oLmj+O uSNJnap08aiVqaD/U3Ma5m6qmdewdnFHbywm7684b1UAbxiRzznd+mM7u0ef3y2B f6fM5o8LWb9NVHmU1Qy8p3MWKG8RNvCP25mDmyWdz2919whc1pZpkQ0yVCtpH0/4 FjrAIDqjb7HGAZtVGikaO8Nb4UnWJyQtj+KvrcuQbA+atq/2T1tx1krmyXZwCckt yRSROOF14BuijvKGtOOaMI60vwLeA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddriedtgdekkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 30BDC380075; Tue, 16 Jul 2019 11:06:55 -0400 (EDT) From: Thomas Monjalon To: "Gavin Hu (Arm Technology China)" Cc: Olivier Matz , "dev@dpdk.org" , nd , "jerinj@marvell.com" , "hemant.agrawal@nxp.com" , "Nipun.gupta@nxp.com" , Honnappa Nagarahalli , "i.maximets@samsung.com" , "stable@dpdk.org" Date: Tue, 16 Jul 2019 17:06:53 +0200 Message-ID: <5216267.UWJeh5MzEM@xps> In-Reply-To: References: <20181212062404.30243-1-gavin.hu@arm.com> <20190716113156.nhnirohjmzdbb4wl@platinum> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v9 1/2] ring: add reset API to flush the ring when not in use X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/07/2019 16:03, Gavin Hu (Arm Technology China): > From: Olivier Matz > > On Tue, Jul 16, 2019 at 11:01:21AM +0200, Olivier Matz wrote: > > > On Fri, Jul 12, 2019 at 11:54:36PM +0800, Gavin Hu wrote: > > > > Currently, the flush is done by dequeuing the ring in a while loop. It is > > > > much simpler to flush the queue by resetting the head and tail indices. > > > > > > > > Fixes: af75078fece3 ("first public release") > > > > Cc: stable@dpdk.org > > > > Actually it's not a fix, it adds a new API. > > > > Is the patch in hash library intended to be backported? If yes, as it > > seems to be a performance optimization, you'll need to describe what > > scenario you're fixing and what is the performance gain. If no, the Cc > > stable can be removed. > > As this is not in the data plan, I don't intend to backport. > Do I need to submit a new version to remove the CC: lines? Yes please. You can also remove the "fixes" line in the first patch.