From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7DC52A00E6 for ; Mon, 5 Aug 2019 19:26:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E9F711BDE4; Mon, 5 Aug 2019 19:26:47 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 9E01D1BD52; Mon, 5 Aug 2019 19:26:46 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E4D8520CCC; Mon, 5 Aug 2019 13:26:45 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 05 Aug 2019 13:26:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=tJK4CNWyJSm5yGOO0Dx4cmrPDyhwpRxpHPyi+eod7VQ=; b=QnqLXt1YDVwo IYR2avbhaGZ51rmmgswdFAcZctibucy2HcfKKiDIW2ReiVZboCjuQDx+fG7UjytM j4DZSgYMhUiUaJo7r0dlH+5qmBuY1xjUrGuPoAk+Adb0323euI8CTm3ougOrPyKW /UN6JiiOaaulpsYYDSsYIygf5eHESXg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=tJK4CNWyJSm5yGOO0Dx4cmrPDyhwpRxpHPyi+eod7 VQ=; b=iUvGBNuamGh5dDUSTzejVDgQYAduyIBdTUrvoDv45528P2IQkeD/fsaaO KEAy2uOLoWqsfqCFEqTuOI4prPbvQYD5N/JsSBcIZ0B3WvOkNqcm2vdzCxO5mzHA fQ0kiv2J7ND0cmTR40Z1GHvHf/TV9Ty4pSwmqcVxsN1UimJaCkzQ9dLymTQHNLlG R/Ie9GOyVEwXA+Wh4bioVUpT23BE4E/R5iCZDtzIrGwEsu7FoVD9FNH9jHVx/d71 VY/M17t3H0l0h4mhRvOYM6+dw1pVxCc6sHd5OO04QmHuIa7kbg/Q9co0KQcrLmIy kKoPn7Vxxiy5fAjLsM5M59e7qTMrw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddruddtjedguddufecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc fkphepleefrddvfedrudeirddvvdelnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (229.16.23.93.rev.sfr.net [93.23.16.229]) by mail.messagingengine.com (Postfix) with ESMTPA id 287908005C; Mon, 5 Aug 2019 13:26:42 -0400 (EDT) From: Thomas Monjalon To: Hemant Agrawal Cc: dev@dpdk.org, Maxime Coquelin , Olivier Matz , "matan@mellanox.com" , "stable@dpdk.org" , Stephen Hemminger Date: Mon, 05 Aug 2019 19:26:36 +0200 Message-ID: <52178578.ScOzJIhHJ0@xps> In-Reply-To: References: <20190725110645.8817-1-hemant.agrawal@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH BUG 335 3/3] net/virtio: fix compilation error with 0 headroom X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/08/2019 15:07, Maxime Coquelin: > On 8/1/19 10:09 AM, Hemant Agrawal wrote: > >> On 7/26/19 2:25 PM, Olivier Matz wrote: > >>> On Thu, Jul 25, 2019 at 04:36:45PM +0530, Hemant Agrawal wrote: > >>>> When using RTE_PKTMBUF_HEADROOM as 0, virito ethdev driver throws > >>>> compilation error > >>>> virtio_ethdev.c:1851:2: note: in expansion of macro =E2=80=98RTE_BUI= LD_BUG_ON=E2=80=99 > >>>> RTE_BUILD_BUG_ON(RTE_PKTMBUF_HEADROOM > >>>> < sizeof(struct virtio_net_hdr_mrg_rxbuf)); > >>>> > >>>> This patch change it into run-time check. [...] > >>>> > >>>> Fixes: 198ab33677c9 ("net/virtio: move device initialization in a > >>>> function") > >>> > >>> I think the proper commit is: > >>> Fixes: dec08c28c0b3 ("virtio: check packet headroom at compile time") > >> > >> Indeed. > >> > >>> It looks this patch more or less reverts this old commit. > >>> +CC Stephen > >> > >> I wonder whether we could have a warning at build time so that the one= who > >> builds DPDK is aware some driver may not be usable, in addition to the > >> below patch that fails virtio-net init. > >=20 > > [Hemant] I will also prefer compile time check instead of run-time chec= k for any non-default configs. > > If someone is modifying the config, he can very well disable the driver= s, which don't like those settings.=20 > >=20 > > However, earlier discussion w.r.t this bug moved in other direction to = make DPDK compliable for all cases and allow regress testing. >=20 > Ok, I don't have a strong opinion on this, so feel free to apply this > patch as is. We can add a build-ime warning later if we find it useful. >=20 > Acked-by: Maxime Coquelin Series applied, thanks. I think the right fix should be a check in meson.