From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02E0BA00E6 for <public@inbox.dpdk.org>; Wed, 7 Aug 2019 14:07:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 60F922BF1; Wed, 7 Aug 2019 14:07:40 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 343DE1DBE for <dev@dpdk.org>; Wed, 7 Aug 2019 14:07:38 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 730EE21B55; Wed, 7 Aug 2019 08:07:37 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 07 Aug 2019 08:07:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=yjQJbW3U0DZHAUwQxEKCJL4QQUtNYsLLPR6Sn4d6BFo=; b=WTDprSdOCQDM aaBym9cJLc5bH6cLz/IaYr13q37FbmjaMCL8xAtx4TavIB6NFmM0DKynrU/d12Bn RO1dinUzX+jzqL69KP6qmOo4JKt9PCoLBQQ0wXR4MT6XnKyhXIiPZrUbkJABb2mf 32rsT8S+juA3JubH1r9sr2mqcijC/I8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=yjQJbW3U0DZHAUwQxEKCJL4QQUtNYsLLPR6Sn4d6B Fo=; b=a6rf92Ouuq9+GLJJN3TdRizKdJ91UHhNwfXCFkjbrGOZEKWY3gdWMDY46 DV6ZS481AEI/5A91NMWfMO/vt6om3YzPWlV9CIvrKJoA459C83A0QjF/twfCj6Ij 3lmLUocfEQwzBgKhoUofd+D1l885cqjN4awJly4WkVVntm+OuejENl9qRyW7IWMs spFDR7L4PVHQ0jsJieOsi7cKTAG2c8HanBMM2fLXdVwDa0d3di5dyyP2YgrpE+XT kEDKhYBkz4A7aA+X1oOi6JOu6V823FaI9J0tUktBr5JnUQ7XajVta2pQ7rBoival 3Dh+ahmocMRW4UxC33JKxt3JBh+zA== X-ME-Sender: <xms:CL9KXbR3Iozfg_UCGZ-3qkvlWBEVTuVmn5FSSlJoaj_f5RSMovqUxA> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudduvddggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeelfedriedrudegledruddugeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhm rghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: <xmx:CL9KXRClTbVaZz5lX82y_V1wplmhoM-w5-TE4qBCJl35dplRGT9dsw> <xmx:CL9KXb2UxsAzGSwPA0TMfv7vIpaFKWI-bu3epW7rV1ndFX1o9DYMZA> <xmx:CL9KXfUrapFt-QXceeALd7T5b3e5M47oPHX6_nrSNfbXoTpiTleiaQ> <xmx:Cb9KXR7MsxAcS_hkmeIoi4dMRiNLBU-Cnw7F_MknqcxqB9i-F1hL1g> Received: from xps.localnet (114.149.6.93.rev.sfr.net [93.6.149.114]) by mail.messagingengine.com (Postfix) with ESMTPA id 737C1380079; Wed, 7 Aug 2019 08:07:35 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Gagandeep Singh <g.singh@nxp.com> Cc: David Marchand <david.marchand@redhat.com>, dev <dev@dpdk.org>, "Burakov, Anatoly" <anatoly.burakov@intel.com>, Olivier Matz <olivier.matz@6wind.com>, Andrew Rybchenko <arybchenko@solarflare.com>, Nipun Gupta <nipun.gupta@nxp.com> Date: Wed, 07 Aug 2019 14:07:32 +0200 Message-ID: <52183700.OczlixnxyG@xps> In-Reply-To: <CAJFAV8wQ1qKRU=t3XGDZWWDaTCPwKx_DearV_rqAp-CKErW_Tg@mail.gmail.com> References: <20190807101204.21614-1-g.singh@nxp.com> <CAJFAV8wQ1qKRU=t3XGDZWWDaTCPwKx_DearV_rqAp-CKErW_Tg@mail.gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: change max hugepage sizes to 4 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 07/08/2019 14:00, David Marchand: > On Wed, Aug 7, 2019 at 12:26 PM Gagandeep Singh <g.singh@nxp.com> wrote: > > > > DPDK currently is supporting maximum 3 hugepage, > > sizes whereas system can support more than this e.g. > > 64K, 2M, 32M and 1G. > > You can mention ARM platform here, and that this issue starts with > kernel 5.2 (and I would try to mention this in the title as well). > This is better than an annotation that will be lost. > > > > Having these four hugepage sizes available to use by DPDK, > > which is valid in case of '--in-memory' EAL option or > > using 4 separate mount points for each hugepage size; > > hugepage_info_init() API reports an error. > > Can you describe what is the impact from a user point of view rather > than mentioning this internal function? Yes please, we need to understand how much it is critical. Should we Cc stable@dpdk.org for backport? Should it be merged at the last minute in 19.08? > > This change increases the maximum supported mount points > > to 4. > > I suppose this fix does the trick for you. > However, we are in internal structures and I can't think of an impact > on datapath. > So we might as well use dynamic allocations rather than just enlarge this array. > > Did you consider this?