From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD435A04B5; Thu, 29 Oct 2020 20:31:19 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D9F68C960; Thu, 29 Oct 2020 20:31:17 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id A99F6C95E for ; Thu, 29 Oct 2020 20:31:16 +0100 (CET) IronPort-SDR: Il7YpnOStiPX9/yVhjw4dyhqiSKALJovIEma5mKfZsdAZjC0J2wKsZUYBkSz/dHKwBjCSnL280 mzeoOQnzmihA== X-IronPort-AV: E=McAfee;i="6000,8403,9789"; a="253204180" X-IronPort-AV: E=Sophos;i="5.77,430,1596524400"; d="scan'208";a="253204180" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2020 12:31:14 -0700 IronPort-SDR: Y69QJzC4DyjZ9ogdLy6+qlg8S0SjYtQnACsHV+E3RttXTYRflldhlvhgC5keos2XCR4XeY5OlZ aQfcy9283vyA== X-IronPort-AV: E=Sophos;i="5.77,430,1596524400"; d="scan'208";a="536789626" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.251.183]) ([10.213.251.183]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2020 12:31:13 -0700 To: Hariprasad Govindharajan , dev@dpdk.org Cc: anatoly.burakov@intel.com, bluca@debian.org References: <1601909255-26251-1-git-send-email-hariprasad.govindharajan@intel.com> <1603999017-43206-1-git-send-email-hariprasad.govindharajan@intel.com> From: Ferruh Yigit Message-ID: <521fb9a4-7565-d533-8d89-c9539d52d87d@intel.com> Date: Thu, 29 Oct 2020 19:31:09 +0000 MIME-Version: 1.0 In-Reply-To: <1603999017-43206-1-git-send-email-hariprasad.govindharajan@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [DPDK_KMODS v5] linux/igb_uio: add Makefile to build the kernel module X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/29/2020 7:16 PM, Hariprasad Govindharajan wrote: > With DPDK 20.11 release, the igb_uio module is no more part of DPDK. > There are use cases where this module is required, for example while > testing the virtual ports in OvS, the virtual ports are bound to > igb_uio module inside a VM. So, this patch provides a Makefile > which can be used to build this module and use as needed. > > Since there is no more dependency on DPDK headers, this module can be > built simply by running make in the source dir > > Signed-off-by: Hariprasad Govindharajan Hi Hariprasad, Can you please make this two patches, first one to move the enum/macro from DPDK to igb_uio.c to remove the dependency. Second on is the Makefile. <...> > @@ -15,7 +15,25 @@ > #include > #include > > -#include > +/** > + * These enums and MACRO definitions are copied from the > + * file rte_pci_dev_features.h > + */ > + > +/* interrupt mode */ > + > +enum rte_intr_mode { > + RTE_INTR_MODE_NONE = 0, > + RTE_INTR_MODE_LEGACY, > + RTE_INTR_MODE_MSI, > + RTE_INTR_MODE_MSIX > +}; Can you please fix the indentation? > + > +#define RTE_INTR_MODE_NONE_NAME "none" > +#define RTE_INTR_MODE_LEGACY_NAME "legacy" > +#define RTE_INTR_MODE_MSI_NAME "msi" > +#define RTE_INTR_MODE_MSIX_NAME "msix" > + > > #include "compat.h" > >