Re: [dpdk-dev] [PATCH] test/compress: fix coverity warnings

["Dybkowski, AdamX" <adamx.dybkowski@intel.com>]

Hi Fiona.

> -----Original Message-----
> From: Trahe, Fiona
> Sent: Thursday, 25 July, 2019 15:56
> To: Dybkowski, AdamX <adamx.dybkowski@intel.com>; dev@dpdk.org;
> akhil.goyal@nxp.com
> Cc: Trahe, Fiona <fiona.trahe@intel.com>
> Subject: RE: [PATCH] test/compress: fix coverity warnings
> 
> Hi Adam,
> 
> > -----Original Message-----
> > From: Dybkowski, AdamX
> > Sent: Tuesday, July 23, 2019 11:54 AM
> > To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>;
> > akhil.goyal@nxp.com
> > Cc: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> > Subject: [PATCH] test/compress: fix coverity warnings
> >
> > CID 340857: Null pointer dereferences (NULL_RETURNS)
> >
> > CID 340856: (CONSTANT_EXPRESSION_RESULT)
> >
> > Fixes: 3be12ea52ad8 ("test/compress: improve debug trace setup")
> >
> > Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> > ---
> >  app/test/test_compressdev.c | 10 ++++++++--
> >  1 file changed, 8 insertions(+), 2 deletions(-)
> >
> > diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c
> > index 65889c242..992eac8e0 100644
> > --- a/app/test/test_compressdev.c
> > +++ b/app/test/test_compressdev.c
> > @@ -755,6 +755,12 @@ test_deflate_comp_decomp(const struct
> interim_data_params *int_data,
> >  	char *contig_buf = NULL;
> >  	uint64_t compress_checksum[num_bufs];
> >
> > +	if (capa == NULL) {
> > +		RTE_LOG(ERR, USER1,
> > +			"Compress device does not support DEFLATE\n");
> > +		return -1;
> [Fiona] shouldn't you return -ENOTSUP?
[Adam] All other errors end with returning -1 (see the ret_status variable which is initialized to -1).
That's why I handle the error case the same way. This is inside the test suite, not a PMD.