From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1202BA04F8; Fri, 20 Dec 2019 13:46:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7BAC72BF9; Fri, 20 Dec 2019 13:46:45 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id D66E61C01 for ; Fri, 20 Dec 2019 13:46:43 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Dec 2019 04:46:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,335,1571727600"; d="scan'208";a="248679306" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga002.fm.intel.com with ESMTP; 20 Dec 2019 04:46:37 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.165]) by IRSMSX154.ger.corp.intel.com ([169.254.12.207]) with mapi id 14.03.0439.000; Fri, 20 Dec 2019 12:46:37 +0000 From: "Dybkowski, AdamX" To: "Trahe, Fiona" , "dev@dpdk.org" , "akhil.goyal@nxp.com" , "Doherty, Declan" Thread-Topic: [PATCH] test/crypto: add operation status checks Thread-Index: AQHVtyvZ8S+UYql0GUat+tVDinb9KqfC9nCAgAABMoA= Date: Fri, 20 Dec 2019 12:46:36 +0000 Message-ID: <522B1A062D56224ABC0C6BDBCD64D9D373F9F182@irsmsx105.ger.corp.intel.com> References: <20191220115004.2713-1-adamx.dybkowski@intel.com> In-Reply-To: Accept-Language: pl-PL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] test/crypto: add operation status checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Fiona. Answers inline below. > -----Original Message----- > From: Trahe, Fiona > Sent: Friday, 20 December, 2019 13:39 > To: Dybkowski, AdamX ; dev@dpdk.org; > akhil.goyal@nxp.com; Doherty, Declan > Cc: Trahe, Fiona > Subject: RE: [PATCH] test/crypto: add operation status checks >=20 > Hi Adam, >=20 >=20 > > -----Original Message----- > > From: Dybkowski, AdamX > > Sent: Friday, December 20, 2019 11:50 AM > > To: dev@dpdk.org; Trahe, Fiona ; > > akhil.goyal@nxp.com; Doherty, Declan > > Cc: Dybkowski, AdamX > > Subject: [PATCH] test/crypto: add operation status checks > > > > This patch adds checking of the symmetric crypto operation status that > > was silently skipped before. It fixes the wireless algorithms session > > creation (SNOW3G, KASUMI, ZUC) and passing of the digest data for the > > verification by PMD. > > > [Fiona] This should be marked as a fix for backporting [Adam] OK, will do in v2. >=20 > > Signed-off-by: Adam Dybkowski > > --- > > app/test/test_cryptodev.c | 96 > > +++++++++++++++++++++------------------ > > 1 file changed, 52 insertions(+), 44 deletions(-) > > > > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c > > index 1b561456d..241a1f97a 100644 > > --- a/app/test/test_cryptodev.c > > +++ b/app/test/test_cryptodev.c > > @@ -143,7 +143,7 @@ static struct rte_crypto_op * > > process_crypto_request(uint8_t dev_id, struct rte_crypto_op *op) { > > if (rte_cryptodev_enqueue_burst(dev_id, 0, &op, 1) !=3D 1) { > > -printf("Error sending packet for encryption"); > > +printf("Error sending packet for encryption\n"); > [Fiona] Can you replace this with RTE_LOG while you're modifying it pleas= e [Adam] OK, will do in v2. > > return NULL; > > } > > > > @@ -152,6 +152,11 @@ process_crypto_request(uint8_t dev_id, struct > > rte_crypto_op *op) while (rte_cryptodev_dequeue_burst(dev_id, 0, &op, > > 1) =3D=3D 0) rte_pause(); > > > > +if (op->status !=3D RTE_CRYPTO_OP_STATUS_SUCCESS) { RTE_LOG(DEBUG, > > +USER1, "Operation status %d\n", op->status); return NULL; } > > + > [Fiona] are there any negative tests - e.g. that expect to see an auth ve= rify > failure or invalid session - that would be affected by this? If so should= the > actual status be returned? [Adam] Few negative tests had to be updated because now in the case of any op error, the process request function returns NULL. The negative tests now= check for the NULL instead of checking for nonzero op status. This was done in test_authenticated_decryption_fail_when_corruption, test_authentication_ver= ify_GMAC_fail_when_corruption and test_authentication_verify_fail_when_data= _corruption.