From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9214A051A; Fri, 17 Jan 2020 10:54:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 837701D412; Fri, 17 Jan 2020 10:54:02 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 804361D40E for ; Fri, 17 Jan 2020 10:54:00 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jan 2020 01:53:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,329,1574150400"; d="scan'208";a="274312203" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by FMSMGA003.fm.intel.com with ESMTP; 17 Jan 2020 01:53:59 -0800 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.164]) by IRSMSX104.ger.corp.intel.com ([169.254.5.203]) with mapi id 14.03.0439.000; Fri, 17 Jan 2020 09:53:57 +0000 From: "Dybkowski, AdamX" To: "dev@dpdk.org" Thread-Topic: [PATCH v5 0/4] Refactor crypto unit tests. Thread-Index: AQHVzGpvBdm4QszFFU+Pu8iWXE/es6funvTw Date: Fri, 17 Jan 2020 09:53:56 +0000 Message-ID: <522B1A062D56224ABC0C6BDBCD64D9D38CA9B944@IRSMSX103.ger.corp.intel.com> References: <20200116104044.588-1-adamx.dybkowski@intel.com> <20200116124232.22282-1-adamx.dybkowski@intel.com> In-Reply-To: <20200116124232.22282-1-adamx.dybkowski@intel.com> Accept-Language: pl-PL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 0/4] Refactor crypto unit tests. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" BTW: As the series 7792 was merged already, this patch set doesn't have any= special requirements now. Adam > -----Original Message----- > From: Dybkowski, AdamX > Sent: Thursday, 16 January, 2020 13:42 > To: dev@dpdk.org; Trahe, Fiona ; > akhil.goyal@nxp.com > Cc: Dybkowski, AdamX > Subject: [PATCH v5 0/4] Refactor crypto unit tests. >=20 > This patch set is a first step to refactor the overly complex symmetric c= rypto > unit tests. It merges many separate arrays of the tests for these PMDs: n= ull, > aesni_mb, aesni_gcm, openssl, qat, sw_snow3g, sw_kasumi, sw_zuc into one > big array that's then used when running unit tests on these PMDs. >=20 > Individual test functions check the capabilities and execute the rest of = the > test or skip (return -ENOTSUP) based on the particular test requirements = - > e.g. test if PMD supports ZUC algo or even a particular key length in few > cases. Few edge cases required to check the PMD itself (e.g. run on QAT o= nly, > or skip on AES NI / AES GCM). >=20 > It's the first step of bigger refactoring. Maintainers of other PMDs are > encouraged to add their PMD unit tests also into this big central array a= nd > remove individual test macro arrays. >=20 > This patch doesn't address next refactoring steps to be done in the > future: geting rid of many small (usually 1-2 line) test functions, creat= ed > separately for every test case; and simplifying many bigger functions tha= t > currently do similar things but work on different test vector structures. >=20 > NOTICE: This patch set depends on the series > http://patches.dpdk.org/project/dpdk/list/?series=3D7792 > that must be applied first. >=20 > A simple script to check if symmetric crypto unit tests work properly on > multiple PMDs at once, update the PMDs list to your needs: >=20 > for PMD in null aesni_mb aesni_gcm openssl qat scheduler sw_snow3g > sw_kasumi sw_zuc do > echo +++++ $PMD +++++ > echo cryptodev_${PMD}_autotest | build/app/test -c7 -n1 --log-level= =3D7 | > grep ' Tests [Failed|Passed]' > done >=20 > --- > v2: > * Update the cover letter, regenerate the patch file. > v3: > * Break very large commit into four smaller commits, easier to review. > * Show in the cover letter how to run unit tests on multiple PMDs at once= . > v4: > * Rebase. > v5: > * Fix a test failing on SW ZUC PMD. >=20 > Adam Dybkowski (4): > test/crypto: refactor unit tests > test/crypto: refactor unit tests - continuation > test/crypto: add capability checks > test/crypto: refactor unit tests into one combined array >=20 > app/test/test_cryptodev.c | 15883 +++++++++---------- > app/test/test_cryptodev_blockcipher.c | 2 +- > app/test/test_cryptodev_des_test_vectors.h | 6 +- > 3 files changed, 7298 insertions(+), 8593 deletions(-) >=20 > -- > 2.17.1