Re: [dpdk-dev] [PATCH] test/crypto: replace wireless algos test vectors

["Dybkowski, AdamX" <adamx.dybkowski@intel.com>]

Hi.

The reason for changing these vectors is the same as for a bit similar Artur's compression vectors change patch: http://patches.dpdk.org/patch/65616/
Basically speaking, we'd like to remove everything with unclear license. To do that, I replaced all wireless crypto (SNOW3G, ZUC, KASUMI etc) algorithms' test vectors (input arrays) with completely randomized data.

Outputs for the test vectors were calculated using Intel's QuickAssist PMD and software-only PMDs (sw_snow3g, sw_zuc etc), and cross-checked to ensure all unit tests are passing correctly. I hope this answers your question about the interoperability.

This patch changes unit test vectors only. No internal PMDs' code has been changed so it won't affect other applications that use DPDK.

It'll be great of course if anyone can verify whether new unit tests pass correctly on other hardware-based PMDs that can handle wireless algorithms like OcteonTX / DPAA / DPAA2.

Adam

> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Wednesday, 12 February, 2020 14:23
> To: Dybkowski, AdamX <adamx.dybkowski@intel.com>; dev@dpdk.org;
> Trahe, Fiona <fiona.trahe@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] test/crypto: replace wireless algos test
> vectors
> 
> Hi Adam/Fiona,
> >
> > This patch replaces all KASUMI, SNOW3G, ZUC and all mixed crypto unit
> > test vectors with randomly generated input arrays.
> > All outputs were calculated and verified on both QAT PMD and
> > appropriate software-only PMDs wherever possible.
> >
> > Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> > ---
> I have few doubts about this patch
> 
> -> What is the reason for changing the test vectors?
> -> Are these based on some standard test vectors somewhere?
> -> Have you done any interoperability tests on these vectors?
> 
> Regards,
> Akhil
>