From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DAB1EA0542; Thu, 13 Feb 2020 14:44:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0367D1BFEB; Thu, 13 Feb 2020 14:44:21 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 79C9F3B5 for ; Thu, 13 Feb 2020 14:44:19 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Feb 2020 05:44:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,436,1574150400"; d="scan'208";a="234120263" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga003.jf.intel.com with ESMTP; 13 Feb 2020 05:44:17 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.149]) by IRSMSX104.ger.corp.intel.com ([169.254.5.240]) with mapi id 14.03.0439.000; Thu, 13 Feb 2020 13:44:16 +0000 From: "Dybkowski, AdamX" To: Akhil Goyal , "dev@dpdk.org" , "Trahe, Fiona" Thread-Topic: [dpdk-dev] [PATCH] test/crypto: replace wireless algos test vectors Thread-Index: AQHV3OAOZWTh5pa9kUSYveGq+7kZ8agXlXEAgAGUuvA= Date: Thu, 13 Feb 2020 13:44:16 +0000 Message-ID: <522B1A062D56224ABC0C6BDBCD64D9D38CB24FC9@irsmsx105.ger.corp.intel.com> References: <20200206112447.31488-1-adamx.dybkowski@intel.com> In-Reply-To: Accept-Language: pl-PL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] test/crypto: replace wireless algos test vectors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi. The reason for changing these vectors is the same as for a bit similar Artu= r's compression vectors change patch: http://patches.dpdk.org/patch/65616/ Basically speaking, we'd like to remove everything with unclear license. To= do that, I replaced all wireless crypto (SNOW3G, ZUC, KASUMI etc) algorith= ms' test vectors (input arrays) with completely randomized data. Outputs for the test vectors were calculated using Intel's QuickAssist PMD = and software-only PMDs (sw_snow3g, sw_zuc etc), and cross-checked to ensure= all unit tests are passing correctly. I hope this answers your question ab= out the interoperability. This patch changes unit test vectors only. No internal PMDs' code has been = changed so it won't affect other applications that use DPDK. It'll be great of course if anyone can verify whether new unit tests pass c= orrectly on other hardware-based PMDs that can handle wireless algorithms l= ike OcteonTX / DPAA / DPAA2. Adam > -----Original Message----- > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > Sent: Wednesday, 12 February, 2020 14:23 > To: Dybkowski, AdamX ; dev@dpdk.org; > Trahe, Fiona > Subject: RE: [dpdk-dev] [PATCH] test/crypto: replace wireless algos test > vectors >=20 > Hi Adam/Fiona, > > > > This patch replaces all KASUMI, SNOW3G, ZUC and all mixed crypto unit > > test vectors with randomly generated input arrays. > > All outputs were calculated and verified on both QAT PMD and > > appropriate software-only PMDs wherever possible. > > > > Signed-off-by: Adam Dybkowski > > --- > I have few doubts about this patch >=20 > -> What is the reason for changing the test vectors? > -> Are these based on some standard test vectors somewhere? > -> Have you done any interoperability tests on these vectors? >=20 > Regards, > Akhil >=20