From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 25F8B803D for ; Wed, 18 Apr 2018 09:25:59 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 94B6F215AC; Wed, 18 Apr 2018 03:25:58 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 18 Apr 2018 03:25:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=xtgsK29tXU3Cely9Q1qx7xKIgI uh5OyS/VGweLsbieQ=; b=gxrDG6ER8boPsYsT/ml0oGPMy9DIN7Bh0iItbauDXb zw72egB5VRk9cCGqkK0Xf6KwutUqhNfzPy3pURO4JGKs6fNl7n8uAAb4wMXDH41a rUpW167AQ3TQbM9arP65cI87PflvhX6T5W1cYbKpoenMYUmxYo0QTUa/brXcHyim 0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=xtgsK2 9tXU3Cely9Q1qx7xKIgIuh5OyS/VGweLsbieQ=; b=YKtxVTYSXm1gaExFQr3U0e K3CZjSDurIywR/CBOjslQWumlWEGiufHvTm+pr7y/1xh8ofT4XWr+CBjgSDkVZaw EIKWR42sHZHQqtHbmYut6GsOpaJDvF5euMQUP25B8To/p7INil4/7tfknwSMPxlI SMOUlu2itHSsHpemtqnJew/NXK+0xdRjM3Ox37bc1AzLWtG22JaoL6gIY12TZW0I p0MPX0ymg6uE8J/8nfOc0bqycSDlQUve6iLynaIgEl99ZiKuQK1CfXcqEfznbd4G vBgO/+XmSbZO6pM+mLBCb+zpjg71eQDGuh7Z04fNFpl0h2vcByOqXBSoaQ1pJEQg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id CA49AE4350; Wed, 18 Apr 2018 03:25:57 -0400 (EDT) From: Thomas Monjalon To: "Chen, Junjie J" Cc: dev@dpdk.org, "Richardson, Bruce" , "Ananyev, Konstantin" Date: Wed, 18 Apr 2018 09:25:56 +0200 Message-ID: <5237986.PrAvHOT1FH@xps> In-Reply-To: References: <20180412051636.240746-1-junjie.j.chen@intel.com> <20180417145734.GA89464@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: force gcc to inline rte_movX function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Apr 2018 07:25:59 -0000 18/04/2018 04:43, Chen, Junjie J: > Thanks to point this out. I agree for the title change. > > Do you want me to send v2 patch? Or you can handle it when committing? > > > > > Sometimes gcc does not inline the function despite keyword *inline*, > > > > we obeserve rte_movX is not inline when doing performance profiling, > > > > so use *always_inline* keyword to force gcc to inline the function. > > > > > > > > Signed-off-by: Chen, Junjie > > > > --- > > > > .../common/include/arch/x86/rte_memcpy.h | 22 > > +++++++++++----------- > > > > 1 file changed, 11 insertions(+), 11 deletions(-) > > > > > > The title should start with "eal/x86:" > > > Something like that: > > > eal/x86: force inlining of memcpy sub-functions > > > > > > Bruce, Konstantin, any review of the content/optimization? > > > > > No objection here. > > > > Acked-by: Bruce Richardson Applied, thanks